LinkId::handle() - Code Metrics - LinkStackOrg/LinkStack - Measure and Improve Code Quality continuously with Scrutinizer

LinkId::handle() A
last analyzed 2025-06-03 11:02 UTC

↳ Parent: LinkId

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	8
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	16
rs	10

<?php

namespace App\Http\Middleware;

use Closure;
use Auth;
use App\Models\Link;
use Illuminate\Http\Request;

class LinkId
{
    public function handle($request, Closure $next)
    {
        $linkId = $request->route('id');
        $user = Auth::user();
    
        $link = Link::find($linkId);
    
        if (!$link) {
            return abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }
    
        if ($user->id != $link->user_id) {

            return abort(403);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }
    
        return $next($request);
    }
}


1			<?php
2
3			namespace App\Http\Middleware;
4
5			use Closure;
6			use Auth;
7			use App\Models\Link;
8			use Illuminate\Http\Request;
9
10			class LinkId
11			{
12			public function handle($request, Closure $next)
13			{
14			$linkId = $request->route('id');
15			$user = Auth::user();
16
17			$link = Link::find($linkId);
18
19			if (!$link) {
20			return abort(404);
			0 ignored issues – show Bug introduced 2024-01-15 17:11 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(404)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
21			}
22
23			if ($user->id != $link->user_id) {
			0 ignored issues – show Bug introduced 2024-01-15 17:11 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
24			return abort(403);
			0 ignored issues – show Bug introduced 2024-01-15 17:11 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(403)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
25			}
26
27			return $next($request);
28			}
29			}
30

LinkStackOrg / LinkStack

LinkId::handle() A last analyzed 2025-06-03 11:02 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

LinkId::handle() A
last analyzed 2025-06-03 11:02 UTC