Completed
Push — master ( db6d82...fcd2b1 )
by Tom
09:17
created
src/Property/Content.php 2 patches
Doc Comments   +13 added lines patch added patch discarded remove patch
@@ -34,6 +34,10 @@  discard block
 block discarded – undo
34 34
 		return (isset($rules['content-mode'])) ? $rules['content-mode'] : 'append';
35 35
 	}
36 36
 
37
+	/**
38
+	 * @param \DOMElement $element
39
+	 * @param \Transphporm\Hook\PropertyHook $rule
40
+	 */
37 41
 	private function processPseudo($value, $element, $rule) {
38 42
 		return $this->pseudoAttr($value, $element, $rule) || $this->pseudoHeader($value, $element, $rule) || $this->pseudoBefore($value, $element, $rule) || $this->pseudoAfter($value, $element, $rule);
39 43
 	}
@@ -96,6 +100,9 @@  discard block
 block discarded – undo
96 100
 		foreach ($remove as $r) $r->parentNode->removeChild($r);
97 101
 	}
98 102
 
103
+	/**
104
+	 * @param \DOMElement $element
105
+	 */
99 106
 	private function replaceContent($element, $content) {
100 107
 		//If this rule was cached, the elements that were added last time need to be removed prior to running the rule again.
101 108
 		$this->removeAdded($element);
@@ -105,12 +112,18 @@  discard block
 block discarded – undo
105 112
 		$element->setAttribute('transphporm', 'remove');
106 113
 	}
107 114
 
115
+	/**
116
+	 * @param \DOMElement $element
117
+	 */
108 118
 	private function appendContent($element, $content) {
109 119
 		foreach ($this->getNode($content, $element->ownerDocument) as $node) {
110 120
 			$element->appendChild($node);
111 121
 		}
112 122
 	}
113 123
 
124
+	/**
125
+	 * @param \DOMElement $element
126
+	 */
114 127
 	private function removeAllChildren($element) {
115 128
 		while ($element->hasChildNodes()) $element->removeChild($element->firstChild);
116 129
 	}
Please login to merge, or discard this patch.
Braces   +21 added lines, -9 removed lines patch added patch discarded remove patch
@@ -18,15 +18,20 @@  discard block
 block discarded – undo
18 18
 	}
19 19
 
20 20
 	public function run($value, \DomElement $element, \Transphporm\Hook\PropertyHook $rule) {
21
-		if ($element->getAttribute('transphporm') === 'remove') return;
21
+		if ($element->getAttribute('transphporm') === 'remove') {
22
+			return;
23
+		}
22 24
 				
23 25
 		$value = $this->formatter->format($value, $rule->getRules());
24 26
 		if (!$this->processPseudo($value, $element, $rule)) {
25 27
 			//Remove the current contents
26 28
 			$this->removeAllChildren($element);
27 29
 			//Now make a text node
28
-			if ($this->getContentMode($rule->getRules()) === 'replace') $this->replaceContent($element, $value);
29
-			else $this->appendContent($element, $value);
30
+			if ($this->getContentMode($rule->getRules()) === 'replace') {
31
+				$this->replaceContent($element, $value);
32
+			} else {
33
+				$this->appendContent($element, $value);
34
+			}
30 35
 		}
31 36
 	}
32 37
 
@@ -57,10 +62,13 @@  discard block
 block discarded – undo
57 62
 			if ($n instanceof \DomElement) {
58 63
 				$new = $document->importNode($n, true);
59 64
 				$new->setAttribute('transphporm', 'added');
60
-			}
61
-			else {
62
-				if ($n instanceof \DomText) $n = $n->nodeValue;
63
-				if ($n == '') continue;
65
+			} else {
66
+				if ($n instanceof \DomText) {
67
+					$n = $n->nodeValue;
68
+				}
69
+				if ($n == '') {
70
+					continue;
71
+				}
64 72
 
65 73
 				$new = $document->createElement('text');
66 74
 				$new->appendChild($document->createTextNode($n));
@@ -93,7 +101,9 @@  discard block
 block discarded – undo
93 101
 		while ($e = $e->previousSibling && $e->getAttribute('transphporm') != null && $e->getAttribute('transphporm') != 'remove') {
94 102
 			$remove[] = $e;
95 103
 		}
96
-		foreach ($remove as $r) $r->parentNode->removeChild($r);
104
+		foreach ($remove as $r) {
105
+			$r->parentNode->removeChild($r);
106
+		}
97 107
 	}
98 108
 
99 109
 	private function replaceContent($element, $content) {
@@ -112,6 +122,8 @@  discard block
 block discarded – undo
112 122
 	}
113 123
 
114 124
 	private function removeAllChildren($element) {
115
-		while ($element->hasChildNodes()) $element->removeChild($element->firstChild);
125
+		while ($element->hasChildNodes()) {
126
+			$element->removeChild($element->firstChild);
127
+		}
116 128
 	}
117 129
 }
118 130
\ No newline at end of file
Please login to merge, or discard this patch.
src/Hook/PostProcess.php 1 patch
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,9 +9,13 @@
 block discarded – undo
9 9
 class PostProcess implements \Transphporm\Hook {
10 10
 	public function run(\DomElement $element) {
11 11
 		$transphporm = $element->getAttribute('transphporm');
12
-		if ($transphporm === 'remove') $element->parentNode->removeChild($element);
13
-		else if ($transphporm === 'text') $element->parentNode->replaceChild($element->firstChild, $element);
14
-		else $element->removeAttribute('transphporm');
12
+		if ($transphporm === 'remove') {
13
+			$element->parentNode->removeChild($element);
14
+		} else if ($transphporm === 'text') {
15
+			$element->parentNode->replaceChild($element->firstChild, $element);
16
+		} else {
17
+			$element->removeAttribute('transphporm');
18
+		}
15 19
 	}
16 20
 
17 21
 }
18 22
\ No newline at end of file
Please login to merge, or discard this patch.