Completed
Pull Request — master (#112)
by Richard
02:30
created
src/Formatter/Date.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/** Converts $val into a \DateTime object if it's not already */
12 12
 	private function getDate($val) {
13 13
 		$tz = new \DateTimeZone($this->locale['timezone']);
14
-		$date =  $val instanceof \DateTime ? $val : new \DateTime($val, $tz);
14
+		$date = $val instanceof \DateTime ? $val : new \DateTime($val, $tz);
15 15
 		$date->setTimeZone($tz);
16 16
 		return $date;
17 17
 	}
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
 	/** Formats \DateTime as Date and Time using formats from $locale */
32 32
 	public function dateTime($val) {
33
-		return $this->date($val, $this->locale['date_format'] . ' ' . $this->locale['time_format']);
33
+		return $this->date($val, $this->locale['date_format'].' '.$this->locale['time_format']);
34 34
 	}
35 35
 
36 36
 	/** Generates relative time offsets based on system clock. e.g "10 minutes ago" or "In 6 months"
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 		$diff = $now->diff($date);
43 43
 
44 44
 
45
-		$diffDays = $diff->invert === 1 ? $diff->days : 0- $diff->days;
45
+		$diffDays = $diff->invert === 1 ? $diff->days : 0-$diff->days;
46 46
 
47 47
 		if ($diffDays !== 0) return $this->dayOffset($diffDays);
48 48
 		else return $this->timeOffset($diff);
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 
69 69
 	/** Gets date ranges to represent uses of weeks/months/days/etc */
70 70
 	private function getRanges($strings) {
71
-		$ranges =  [
71
+		$ranges = [
72 72
 			[1, 1, $strings['yesterday'], 1, ''],
73 73
 			[1, 13, $strings['past'], 1, 'days'],
74 74
 			[13, 28, $strings['past'], 7, 'weeks'],
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
 	/** Converts "week" to "weeks", "month" to "months" etc when plural is required using language from $locale */
89 89
 	private function getPlural($strings, $num, $interval) {
90
-		if ($interval !== '') return $num == 1 ? $strings[$interval . '_singular'] : $strings[$interval . '_plural'];
90
+		if ($interval !== '') return $num == 1 ? $strings[$interval.'_singular'] : $strings[$interval.'_plural'];
91 91
 		else return '';
92 92
 	}
93 93
 
Please login to merge, or discard this patch.
Braces   +16 added lines, -6 removed lines patch added patch discarded remove patch
@@ -44,8 +44,11 @@  discard block
 block discarded – undo
44 44
 
45 45
 		$diffDays = $diff->invert === 1 ? $diff->days : 0- $diff->days;
46 46
 
47
-		if ($diffDays !== 0) return $this->dayOffset($diffDays);
48
-		else return $this->timeOffset($diff);
47
+		if ($diffDays !== 0) {
48
+			return $this->dayOffset($diffDays);
49
+		} else {
50
+			return $this->timeOffset($diff);
51
+		}
49 52
 	}
50 53
 
51 54
 	/** Calculates offset in hours/minutes/seconds */
@@ -80,15 +83,22 @@  discard block
 block discarded – undo
80 83
 			[-365, -28, $strings['future'], 28, 'months'],
81 84
 			[-999999, -365, $strings['future'], 365, 'years'],
82 85
 		];
83
-		if (isset($strings['day_before_yesterday'])) array_unshift($ranges, [2, 2, $strings['day_before_yesterday'], 1, '']);
84
-		if (isset($strings['day_after_tomorrow'])) array_unshift($ranges, [-2, -2, $strings['day_after_tomorrow'], 1, '']);
86
+		if (isset($strings['day_before_yesterday'])) {
87
+			array_unshift($ranges, [2, 2, $strings['day_before_yesterday'], 1, '']);
88
+		}
89
+		if (isset($strings['day_after_tomorrow'])) {
90
+			array_unshift($ranges, [-2, -2, $strings['day_after_tomorrow'], 1, '']);
91
+		}
85 92
 		return $ranges;
86 93
 	}
87 94
 
88 95
 	/** Converts "week" to "weeks", "month" to "months" etc when plural is required using language from $locale */
89 96
 	private function getPlural($strings, $num, $interval) {
90
-		if ($interval !== '') return $num == 1 ? $strings[$interval . '_singular'] : $strings[$interval . '_plural'];
91
-		else return '';
97
+		if ($interval !== '') {
98
+			return $num == 1 ? $strings[$interval . '_singular'] : $strings[$interval . '_plural'];
99
+		} else {
100
+			return '';
101
+		}
92 102
 	}
93 103
 
94 104
 	/** Calculates offset in days/weeks/month/years */
Please login to merge, or discard this patch.
src/Formatter/Number.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
 	public function currency($num) {
15 15
 		$num = $this->decimal($num, $this->locale['currency_decimals']);
16
-		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'] . $num;
17
-		else return $num . $this->locale['currency'];
16
+		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'].$num;
17
+		else return $num.$this->locale['currency'];
18 18
 	}
19 19
 }
20 20
\ No newline at end of file
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,10 @@
 block discarded – undo
13 13
 
14 14
 	public function currency($num) {
15 15
 		$num = $this->decimal($num, $this->locale['currency_decimals']);
16
-		if ($this->locale['currency_position'] === 'before') return $this->locale['currency'] . $num;
17
-		else return $num . $this->locale['currency'];
16
+		if ($this->locale['currency_position'] === 'before') {
17
+			return $this->locale['currency'] . $num;
18
+		} else {
19
+			return $num . $this->locale['currency'];
20
+		}
18 21
 	}
19 22
 }
20 23
\ No newline at end of file
Please login to merge, or discard this patch.
src/Template.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 		if ($document) return $this->document;
56 56
 
57 57
 
58
-		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype) . "\n" : '';
58
+		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype)."\n" : '';
59 59
 
60 60
 		if ($this->document->documentElement->tagName !== 'template') $output .= $this->document->saveXml($this->document->documentElement, LIBXML_NOEMPTYTAG);
61 61
 		else $output = $this->printDocument($this->document);
Please login to merge, or discard this patch.
Braces   +14 added lines, -5 removed lines patch added patch discarded remove patch
@@ -33,14 +33,18 @@  discard block
 block discarded – undo
33 33
 	/** Loops through all assigned hooks, runs the Xpath query and calls the hook */
34 34
 	private function processHooks() {
35 35
 		foreach ($this->hooks as list($query, $hook)) {
36
-			foreach ($this->xpath->query($query) as $element) $hook->run($element);
36
+			foreach ($this->xpath->query($query) as $element) {
37
+				$hook->run($element);
38
+			}
37 39
 		}
38 40
 	}
39 41
 
40 42
 	/** Prints out the current DomDocument as HTML */
41 43
 	private function printDocument(\DomDocument $doc) {
42 44
 		$output = '';
43
-		foreach ($doc->documentElement->childNodes as $node) $output .= $doc->saveXML($node, LIBXML_NOEMPTYTAG);
45
+		foreach ($doc->documentElement->childNodes as $node) {
46
+			$output .= $doc->saveXML($node, LIBXML_NOEMPTYTAG);
47
+		}
44 48
 		return $output;
45 49
 	}
46 50
 
@@ -52,13 +56,18 @@  discard block
 block discarded – undo
52 56
 		//Generate the document by taking only the childnodes of the template, ignoring the <template> and </template> tags
53 57
 		//TODO: Is there a faster way of doing this without string manipulation on the output or this loop through childnodes?
54 58
 		 //Either return a whole DomDocument or return the output HTML
55
-		if ($document) return $this->document;
59
+		if ($document) {
60
+			return $this->document;
61
+		}
56 62
 
57 63
 
58 64
 		$output = ($this->document->doctype) ? $this->document->saveXml($this->document->doctype) . "\n" : '';
59 65
 
60
-		if ($this->document->documentElement->tagName !== 'template') $output .= $this->document->saveXml($this->document->documentElement, LIBXML_NOEMPTYTAG);
61
-		else $output = $this->printDocument($this->document);
66
+		if ($this->document->documentElement->tagName !== 'template') {
67
+			$output .= $this->document->saveXml($this->document->documentElement, LIBXML_NOEMPTYTAG);
68
+		} else {
69
+			$output = $this->printDocument($this->document);
70
+		}
62 71
 
63 72
 		//repair empty tags. Browsers break on <script /> and <div /> so can't avoid LIBXML_NOEMPTYTAG but they also break on <base></base> so repair them
64 73
 		$output = str_replace(['></img>', '></br>', '></meta>', '></base>', '></link>', '></hr>', '></input>'], ' />', $output);
Please login to merge, or discard this patch.
src/Cache.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,8 @@
 block discarded – undo
20 20
 	public function load($key, $modified = 0) {
21 21
 		if (isset($this->cache[$key]) && $this->cache[$key]['timestamp'] >= $modified) {
22 22
 			return $this->cache[$key]['content'];
23
+		} else {
24
+			return false;
23 25
 		}
24
-		else return false;
25 26
 	}
26 27
 }
27 28
\ No newline at end of file
Please login to merge, or discard this patch.
src/Rule.php 2 patches
Braces   +15 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,24 +35,33 @@
 block discarded – undo
35 35
 	}
36 36
 
37 37
 	private function timeFrequency($frequency, $time = null) {
38
-		if ($time === null) $time = time();
38
+		if ($time === null) {
39
+			$time = time();
40
+		}
39 41
 		$num = (int) $frequency;
40 42
 		$unit = strtoupper(trim(str_replace($num, '', $frequency)));
41 43
 			
42 44
 		$offset = $num * constant(self::class . '::' . $unit);
43 45
 
44
-		if ($time > $this->lastRun + $offset) return true;
45
-		else return false;
46
+		if ($time > $this->lastRun + $offset) {
47
+			return true;
48
+		} else {
49
+			return false;
50
+		}
46 51
 	}
47 52
 
48 53
 	public function shouldRun($time = null) {
49 54
 		if (isset($this->properties['update-frequency']) && $this->lastRun !== 0) {
50 55
 			$frequency = $this->properties['update-frequency'];
51 56
 			$static = ['always' => true, 'never' => false];
52
-			if (isset($static[$frequency])) return $static[$frequency];
53
-			else return $this->timeFrequency($frequency, $time);
57
+			if (isset($static[$frequency])) {
58
+				return $static[$frequency];
59
+			} else {
60
+				return $this->timeFrequency($frequency, $time);
61
+			}
54 62
 
63
+		} else {
64
+			return true;
55 65
 		}
56
-		else return true;
57 66
 	}
58 67
 }
59 68
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,9 +39,9 @@
 block discarded – undo
39 39
 		$num = (int) $frequency;
40 40
 		$unit = strtoupper(trim(str_replace($num, '', $frequency)));
41 41
 			
42
-		$offset = $num * constant(self::class . '::' . $unit);
42
+		$offset = $num * constant(self::class.'::'.$unit);
43 43
 
44
-		if ($time > $this->lastRun + $offset) return true;
44
+		if ($time > $this->lastRun+$offset) return true;
45 45
 		else return false;
46 46
 	}
47 47
 
Please login to merge, or discard this patch.
src/Hook/PostProcess.php 1 patch
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,9 +9,13 @@
 block discarded – undo
9 9
 class PostProcess implements \Transphporm\Hook {
10 10
 	public function run(\DomElement $element) {
11 11
 		$transphporm = $element->getAttribute('transphporm');
12
-		if ($transphporm === 'remove') $element->parentNode->removeChild($element);
13
-		else if ($transphporm === 'text') $element->parentNode->replaceChild($element->firstChild, $element);
14
-		else $element->removeAttribute('transphporm');
12
+		if ($transphporm === 'remove') {
13
+			$element->parentNode->removeChild($element);
14
+		} else if ($transphporm === 'text') {
15
+			$element->parentNode->replaceChild($element->firstChild, $element);
16
+		} else {
17
+			$element->removeAttribute('transphporm');
18
+		}
15 19
 	}
16 20
 
17 21
 }
18 22
\ No newline at end of file
Please login to merge, or discard this patch.
src/Pseudo/Nth.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,8 +15,11 @@
 block discarded – undo
15 15
 			$bracketMatcher = new \Transphporm\Parser\BracketMatcher($element->getNodePath());
16 16
 			$num = $bracketMatcher->match('[', ']');
17 17
 			
18
-			if (is_callable([$this, $criteria])) return $this->$criteria($num);
19
-			else return $num == $criteria;			
18
+			if (is_callable([$this, $criteria])) {
19
+				return $this->$criteria($num);
20
+			} else {
21
+				return $num == $criteria;
22
+			}
20 23
 		}
21 24
 		return true;
22 25
 	}
Please login to merge, or discard this patch.
src/Pseudo/Not.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,9 @@
 block discarded – undo
30 30
 			//Find all nodes matched by the expressions in the brackets :not(EXPR)
31 31
 			foreach ($xpath->query($xpathString) as $matchedElement) {
32 32
 				//Check to see whether this node was matched by the not query
33
-				if ($element->isSameNode($matchedElement)) return false;
33
+				if ($element->isSameNode($matchedElement)) {
34
+					return false;
35
+				}
34 36
 			}
35 37
 		}
36 38
 		return true;
Please login to merge, or discard this patch.
src/Parser/Sheet.php 3 patches
Doc Comments   +19 added lines patch added patch discarded remove patch
@@ -12,6 +12,9 @@  discard block
 block discarded – undo
12 12
 	private $prefix;
13 13
 	private $valueParser;
14 14
 
15
+	/**
16
+	 * @param string $tss
17
+	 */
15 18
 	public function __construct($tss, $baseDir, Value $valueParser, $prefix = '') {
16 19
 		$this->tss = $this->stripComments($tss, '/*', '*/');
17 20
 		$this->tss = $this->stripComments($this->tss, '//', "\n");
@@ -38,6 +41,10 @@  discard block
 block discarded – undo
38 41
 		return $rules;
39 42
 	}
40 43
 
44
+	/**
45
+	 * @param string $selector
46
+	 * @param integer $index
47
+	 */
41 48
 	private function CssToRules($selector, $index, $properties) {
42 49
 		$parts = explode(',', $selector);
43 50
 		$rules = [];
@@ -60,6 +67,11 @@  discard block
 block discarded – undo
60 67
 		return $rules;
61 68
 	}
62 69
 
70
+	/**
71
+	 * @param integer $pos
72
+	 * @param integer $next
73
+	 * @param integer $indexStart
74
+	 */
63 75
 	private function processingInstructions($tss, $pos, $next, $indexStart) {
64 76
 		$rules = [];
65 77
 		while (($atPos = strpos($tss, '@', $pos)) !== false) {
@@ -90,6 +102,10 @@  discard block
 block discarded – undo
90 102
 		return ($a->depth < $b->depth) ? -1 : 1;
91 103
 	}
92 104
 
105
+	/**
106
+	 * @param string $open
107
+	 * @param string $close
108
+	 */
93 109
 	private function stripComments($str, $open, $close) {
94 110
 		$pos = 0;
95 111
 		while (($pos = strpos($str, $open, $pos)) !== false) {
@@ -100,6 +116,9 @@  discard block
 block discarded – undo
100 116
 		return $str;
101 117
 	}
102 118
 
119
+	/**
120
+	 * @param string $str
121
+	 */
103 122
 	private function getProperties($str) {
104 123
 		$stringExtractor = new StringExtractor($str);
105 124
 		$rules = explode(';', $stringExtractor);
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 			}
29 29
 
30 30
 			$selector = trim(substr($this->tss, $pos, $next-$pos));
31
-			$pos =  strpos($this->tss, '}', $next)+1;
31
+			$pos = strpos($this->tss, '}', $next)+1;
32 32
 			$newRules = $this->cssToRules($selector, count($rules)+$indexStart, $this->getProperties(trim(substr($this->tss, $next+1, $pos-2-$next))));
33 33
 			$rules = $this->writeRule($rules, $newRules);
34 34
 		}
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	private function processingInstructions($tss, $pos, $next, $indexStart) {
63 63
 		$rules = [];
64 64
 		while (($atPos = strpos($tss, '@', $pos)) !== false) {
65
-			if ($atPos  <= (int) $next) {
65
+			if ($atPos <= (int) $next) {
66 66
 				$spacePos = strpos($tss, ' ', $atPos);
67 67
 				$funcName = substr($tss, $atPos+1, $spacePos-$atPos-1);
68 68
 				$pos = strpos($tss, ';', $spacePos);
@@ -78,12 +78,12 @@  discard block
 block discarded – undo
78 78
 	}
79 79
 
80 80
 	private function import($args, $indexStart) {
81
-		if (is_file(trim($args,'\'" '))) $fileName = trim($args,'\'" ');
81
+		if (is_file(trim($args, '\'" '))) $fileName = trim($args, '\'" ');
82 82
 		else $fileName = $this->valueParser->parse($args)[0];
83 83
 
84
-		if (is_file($this->baseDir . $fileName)) $tssFile = $this->baseDir . $fileName;
84
+		if (is_file($this->baseDir.$fileName)) $tssFile = $this->baseDir.$fileName;
85 85
 		elseif (is_file($fileName)) $tssFile = $fileName;
86
-		else throw new \Exception('Imported TSS File "' . $fileName .'" does not exist');
86
+		else throw new \Exception('Imported TSS File "'.$fileName.'" does not exist');
87 87
 
88 88
 		$sheet = new Sheet(file_get_contents($tssFile), $this->baseDir, $this->xPath, $this->valueParser);
89 89
 		return $sheet->parse(0, [], $indexStart);
Please login to merge, or discard this patch.
Braces   +25 added lines, -11 removed lines patch added patch discarded remove patch
@@ -33,7 +33,9 @@  discard block
 block discarded – undo
33 33
 			$rules = $this->writeRule($rules, $newRules);
34 34
 		}
35 35
 		//there may be processing instructions at the end
36
-		if ($processing = $this->processingInstructions($this->tss, $pos, strlen($this->tss), count($rules)+$indexStart)) $rules = array_merge($rules, $processing['rules']);
36
+		if ($processing = $this->processingInstructions($this->tss, $pos, strlen($this->tss), count($rules)+$indexStart)) {
37
+			$rules = array_merge($rules, $processing['rules']);
38
+		}
37 39
 		usort($rules, [$this, 'sortRules']);
38 40
 		return $rules;
39 41
 	}
@@ -68,8 +70,7 @@  discard block
 block discarded – undo
68 70
 				$pos = strpos($tss, ';', $spacePos);
69 71
 				$args = substr($tss, $spacePos+1, $pos-$spacePos-1);
70 72
 				$rules = array_merge($rules, $this->$funcName($args, $indexStart));
71
-			}
72
-			else {
73
+			} else {
73 74
 				break;
74 75
 			}
75 76
 		}
@@ -78,12 +79,19 @@  discard block
 block discarded – undo
78 79
 	}
79 80
 
80 81
 	private function import($args, $indexStart) {
81
-		if (is_file(trim($args,'\'" '))) $fileName = trim($args,'\'" ');
82
-		else $fileName = $this->valueParser->parse($args)[0];
82
+		if (is_file(trim($args,'\'" '))) {
83
+			$fileName = trim($args,'\'" ');
84
+		} else {
85
+			$fileName = $this->valueParser->parse($args)[0];
86
+		}
83 87
 
84
-		if (is_file($this->baseDir . $fileName)) $tssFile = $this->baseDir . $fileName;
85
-		elseif (is_file($fileName)) $tssFile = $fileName;
86
-		else throw new \Exception('Imported TSS File "' . $fileName .'" does not exist');
88
+		if (is_file($this->baseDir . $fileName)) {
89
+			$tssFile = $this->baseDir . $fileName;
90
+		} elseif (is_file($fileName)) {
91
+			$tssFile = $fileName;
92
+		} else {
93
+			throw new \Exception('Imported TSS File "' . $fileName .'" does not exist');
94
+		}
87 95
 
88 96
 		$sheet = new Sheet(file_get_contents($tssFile), $this->baseDir, $this->xPath, $this->valueParser);
89 97
 		return $sheet->parse(0, [], $indexStart);
@@ -91,7 +99,9 @@  discard block
 block discarded – undo
91 99
 
92 100
 	private function sortRules($a, $b) {
93 101
 		//If they have the same depth, compare on index
94
-		if ($a->depth === $b->depth) return $a->index < $b->index ? -1 : 1;
102
+		if ($a->depth === $b->depth) {
103
+			return $a->index < $b->index ? -1 : 1;
104
+		}
95 105
 
96 106
 		return ($a->depth < $b->depth) ? -1 : 1;
97 107
 	}
@@ -100,7 +110,9 @@  discard block
 block discarded – undo
100 110
 		$pos = 0;
101 111
 		while (($pos = strpos($str, $open, $pos)) !== false) {
102 112
 			$end = strpos($str, $close, $pos);
103
-			if ($end === false) break;
113
+			if ($end === false) {
114
+				break;
115
+			}
104 116
 			$str = substr_replace($str, '', $pos, $end-$pos+2);
105 117
 		}
106 118
 
@@ -113,7 +125,9 @@  discard block
 block discarded – undo
113 125
 		$return = [];
114 126
 
115 127
 		foreach ($rules as $rule) {
116
-			if (trim($rule) === '') continue;
128
+			if (trim($rule) === '') {
129
+				continue;
130
+			}
117 131
 			$parts = explode(':', $rule, 2);
118 132
 			$parts[1] = $stringExtractor->rebuild($parts[1]);
119 133
 			$return[trim($parts[0])] = isset($parts[1]) ? trim($parts[1]) : '';
Please login to merge, or discard this patch.