Passed
Push — master ( 693d98...8cf93f )
by Tom
02:05
created
maphper/maphper.php 3 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -104,10 +104,10 @@  discard block
 block discarded – undo
104 104
 
105 105
 	public function offsetExists($offset) {
106 106
 		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
107
-        if (!empty($this->settings['filter'])) {
108
-            $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
109
-            return isset($data[0]);
110
-        }
107
+		if (!empty($this->settings['filter'])) {
108
+			$data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
109
+			return isset($data[0]);
110
+		}
111 111
 		return (bool) $this->dataSource->findById($offset);
112 112
 	}
113 113
 
@@ -117,10 +117,10 @@  discard block
 block discarded – undo
117 117
 
118 118
 	public function offsetGet($offset) {
119 119
 		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
120
-        if (!empty($this->settings['filter'])) {
121
-            $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
122
-            return $this->entity->create(isset($data[0]) ? $data[0] : null, $this->relations);
123
-        }
120
+		if (!empty($this->settings['filter'])) {
121
+			$data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
122
+			return $this->entity->create(isset($data[0]) ? $data[0] : null, $this->relations);
123
+		}
124 124
 		return $this->entity->create($this->dataSource->findById($offset), $this->relations);
125 125
 	}
126 126
 
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1,19 +1,19 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace Maphper;
3 3
 class Maphper implements \Countable, \ArrayAccess, \IteratorAggregate {
4
-	const FIND_EXACT 		= 	0x1;
5
-	const FIND_LIKE 		= 	0x2;
6
-	const FIND_STARTS 		= 	0x4;
7
-	const FIND_ENDS 		= 	0x8;
8
-	const FIND_BIT 			= 	0x10;
9
-	const FIND_GREATER 		= 	0x20;
10
-	const FIND_LESS 		=	0x40;
11
-	const FIND_EXPRESSION 	= 	0x80;
12
-	const FIND_AND 			= 	0x100;
13
-	const FIND_OR 			= 	0x200;
14
-	const FIND_NOT 			= 	0x400;
15
-	const FIND_BETWEEN		= 	0x800;
16
-	const FIND_NOCASE		= 	0x1000;
4
+	const FIND_EXACT = 0x1;
5
+	const FIND_LIKE 		= 0x2;
6
+	const FIND_STARTS = 0x4;
7
+	const FIND_ENDS 		= 0x8;
8
+	const FIND_BIT 			= 0x10;
9
+	const FIND_GREATER = 0x20;
10
+	const FIND_LESS 		= 0x40;
11
+	const FIND_EXPRESSION = 0x80;
12
+	const FIND_AND 			= 0x100;
13
+	const FIND_OR = 0x200;
14
+	const FIND_NOT 			= 0x400;
15
+	const FIND_BETWEEN = 0x800;
16
+	const FIND_NOCASE		= 0x1000;
17 17
 
18 18
 	private $dataSource;
19 19
 	private $relations = [];
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 			}
58 58
 		}
59 59
 		$results = $this->dataSource->findByField($this->settings['filter'],
60
-			['order' => $this->settings['sort'], 'limit' => $this->settings['limit'], 'offset' => $this->settings['offset'] ]);
60
+			['order' => $this->settings['sort'], 'limit' => $this->settings['limit'], 'offset' => $this->settings['offset']]);
61 61
 
62 62
 		$siblings = new \ArrayObject();
63 63
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
109 109
             return isset($data[0]);
110 110
         }
111
-		return (bool) $this->dataSource->findById($offset);
111
+		return (bool)$this->dataSource->findById($offset);
112 112
 	}
113 113
 
114 114
 	public function offsetUnset($id) {
Please login to merge, or discard this patch.
Braces   +25 added lines, -9 removed lines patch added patch discarded remove patch
@@ -61,7 +61,9 @@  discard block
 block discarded – undo
61 61
 
62 62
 		$siblings = new \ArrayObject();
63 63
 
64
-		foreach ($results as &$result) $result = $this->entity->create($result, $this->relations, $siblings);
64
+		foreach ($results as &$result) {
65
+			$result = $this->entity->create($result, $this->relations, $siblings);
66
+		}
65 67
 
66 68
 		return $results;
67 69
 	}
@@ -78,13 +80,17 @@  discard block
 block discarded – undo
78 80
 	private function processFilters($value) {
79 81
 		//When saving to a mapper with filters, write the filters back into the object being stored
80 82
 		foreach ($this->settings['filter'] as $key => $filterValue) {
81
-			if (empty($value->$key) && !is_array($filterValue)) $value->$key = $filterValue;
83
+			if (empty($value->$key) && !is_array($filterValue)) {
84
+				$value->$key = $filterValue;
85
+			}
82 86
 		}
83 87
 		return $value;
84 88
 	}
85 89
 
86 90
 	public function offsetSet($offset, $valueObj) {
87
-		if ($valueObj instanceof \Maphper\Relation) throw new \Exception();
91
+		if ($valueObj instanceof \Maphper\Relation) {
92
+			throw new \Exception();
93
+		}
88 94
 
89 95
 		//Extract private properties from the object
90 96
 		$propertyReader = new \Maphper\Lib\VisibilityOverride();
@@ -92,7 +98,9 @@  discard block
 block discarded – undo
92 98
 
93 99
 		$value = $this->processFilters($value);
94 100
 		$pk = $this->dataSource->getPrimaryKey();
95
-		if ($offset !== null) $value->{$pk[0]} = $offset;
101
+		if ($offset !== null) {
102
+			$value->{$pk[0]} = $offset;
103
+		}
96 104
 		$valueCopy = clone $value;
97 105
 		$value = $this->entity->wrap($this->relations, $value);
98 106
 		$this->dataSource->save($value);
@@ -103,7 +111,9 @@  discard block
 block discarded – undo
103 111
 	}
104 112
 
105 113
 	public function offsetExists($offset) {
106
-		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
114
+		if (count($this->dataSource->getPrimaryKey()) > 1) {
115
+			return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
116
+		}
107 117
         if (!empty($this->settings['filter'])) {
108 118
             $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
109 119
             return isset($data[0]);
@@ -116,7 +126,9 @@  discard block
 block discarded – undo
116 126
 	}
117 127
 
118 128
 	public function offsetGet($offset) {
119
-		if (count($this->dataSource->getPrimaryKey()) > 1) return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
129
+		if (count($this->dataSource->getPrimaryKey()) > 1) {
130
+			return new MultiPk($this, $offset, $this->dataSource->getPrimaryKey());
131
+		}
120 132
         if (!empty($this->settings['filter'])) {
121 133
             $data = $this->dataSource->findByField(array_merge($this->settings['filter'], [$this->dataSource->getPrimaryKey()[0] => $offset]));
122 134
             return $this->entity->create(isset($data[0]) ? $data[0] : null, $this->relations);
@@ -127,11 +139,15 @@  discard block
 block discarded – undo
127 139
 	public function __call($method, $args) {
128 140
 		if (array_key_exists($method, $this->settings)) {
129 141
 			$maphper = new Maphper($this->dataSource, $this->settings, $this->relations);
130
-			if (is_array($maphper->settings[$method])) $maphper->settings[$method] = $args[0] + $maphper->settings[$method];
131
-			else $maphper->settings[$method] = $args[0];
142
+			if (is_array($maphper->settings[$method])) {
143
+				$maphper->settings[$method] = $args[0] + $maphper->settings[$method];
144
+			} else {
145
+				$maphper->settings[$method] = $args[0];
146
+			}
132 147
 			return $maphper;
148
+		} else {
149
+			throw new \Exception('Method Maphper::' . $method . ' does not exist');
133 150
 		}
134
-		else throw new \Exception('Method Maphper::' . $method . ' does not exist');
135 151
 	}
136 152
 
137 153
 	public function findAggregate($function, $field, $group = null) {
Please login to merge, or discard this patch.
maphper/lib/entity.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 	public function wrap($relations, $object, $siblings = []) {
22 22
 		//see if any relations need overwriting
23 23
 		foreach ($relations as $name => $relation) {
24
-			if (isset($object->$name) && !($object->$name instanceof \Maphper\Relation) ) {
24
+			if (isset($object->$name) && !($object->$name instanceof \Maphper\Relation)) {
25 25
 				//After overwriting the relation, does the parent object ($object) need overwriting as well?
26 26
 				if ($relation->overwrite($object, $object->$name)) $this->parent[] = $object;
27 27
 			}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,9 @@
 block discarded – undo
23 23
 		foreach ($relations as $name => $relation) {
24 24
 			if (isset($object->$name) && !($object->$name instanceof \Maphper\Relation) ) {
25 25
 				//After overwriting the relation, does the parent object ($object) need overwriting as well?
26
-				if ($relation->overwrite($object, $object->$name)) $this->parent[] = $object;
26
+				if ($relation->overwrite($object, $object->$name)) {
27
+					$this->parent[] = $object;
28
+				}
27 29
 			}
28 30
 
29 31
 			$object->$name = $relation->getData($object, $siblings);
Please login to merge, or discard this patch.