Inspection of "new check: resourceHttpStatus" - Leankoala/HealthFoundation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

unknown

created 2019-02-06 22:19 UTC

Status

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@  discard block
 block discarded – undo
     public function init($destination,$httpStatus)
     {
         $this->destination = $destination;
-		$this->httpStatus = $httpStatus;
+        $this->httpStatus = $httpStatus;
     }
 
     /**
@@ -25,39 +25,39 @@  discard block
 block discarded – undo
      */
     public function run()
     {
-		$ch = curl_init();
+        $ch = curl_init();
 
-		curl_setopt( $ch, CURLOPT_URL, $this->destination );
+        curl_setopt( $ch, CURLOPT_URL, $this->destination );
 
-		curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
-		curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
-		curl_setopt( $ch, CURLOPT_HEADER, true );
-		curl_setopt( $ch, CURLOPT_NOBODY, true );
+        curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
+        curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
+        curl_setopt( $ch, CURLOPT_HEADER, true );
+        curl_setopt( $ch, CURLOPT_NOBODY, true );
 
-		curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
-		curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
+        curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
+        curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
 
-		// @todo configurable timeouts (do not put hundreds of parameters to the init method)
-		// @todo Handle SSL support on self-signed cert errors
-		// @todo Optional setup outgoing proxy host and port configuration
+        // @todo configurable timeouts (do not put hundreds of parameters to the init method)
+        // @todo Handle SSL support on self-signed cert errors
+        // @todo Optional setup outgoing proxy host and port configuration
 
-		$httpError = null;
-		$httpStatus = null;
-		if ( curl_exec( $ch ) === false ) {
-			$httpError = curl_error( $ch );
-		} else {
-			$httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );			
-		}
+        $httpError = null;
+        $httpStatus = null;
+        if ( curl_exec( $ch ) === false ) {
+            $httpError = curl_error( $ch );
+        } else {
+            $httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );			
+        }
 
-		curl_close( $ch );
+        curl_close( $ch );
 
-		if ( !is_null( $httpError ) ) {
-    	    return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
-		} elseif ( $httpStatus == $this->httpStatus ) {
-    	    return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
-		} else {
-	        return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
-		}
+        if ( !is_null( $httpError ) ) {
+            return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
+        } elseif ( $httpStatus == $this->httpStatus ) {
+            return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
+        } else {
+            return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
+        }
     }
 
     public function getIdentifier()

Please login to merge, or discard this patch.

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@  discard block
 block discarded – undo
     private $destination = null;
     private $httpStatus = null;
 
-    public function init($destination,$httpStatus)
+    public function init($destination, $httpStatus)
     {
         $this->destination = $destination;
 		$this->httpStatus = $httpStatus;
@@ -27,15 +27,15 @@  discard block
 block discarded – undo
     {
 		$ch = curl_init();
 
-		curl_setopt( $ch, CURLOPT_URL, $this->destination );
+		curl_setopt($ch, CURLOPT_URL, $this->destination);
 
-		curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
-		curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
-		curl_setopt( $ch, CURLOPT_HEADER, true );
-		curl_setopt( $ch, CURLOPT_NOBODY, true );
+		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
+		curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'HEAD');
+		curl_setopt($ch, CURLOPT_HEADER, true);
+		curl_setopt($ch, CURLOPT_NOBODY, true);
 
-		curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
-		curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
+		curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5); // connect timeout
+		curl_setopt($ch, CURLOPT_TIMEOUT, 10); // curl timeout
 
 		// @todo configurable timeouts (do not put hundreds of parameters to the init method)
 		// @todo Handle SSL support on self-signed cert errors
@@ -43,20 +43,20 @@  discard block
 block discarded – undo
 
 		$httpError = null;
 		$httpStatus = null;
-		if ( curl_exec( $ch ) === false ) {
-			$httpError = curl_error( $ch );
+		if (curl_exec($ch) === false) {
+			$httpError = curl_error($ch);
 		} else {
-			$httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );			
+			$httpStatus = curl_getinfo($ch, CURLINFO_HTTP_CODE);			
 		}
 
-		curl_close( $ch );
+		curl_close($ch);
 
-		if ( !is_null( $httpError ) ) {
-    	    return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
-		} elseif ( $httpStatus == $this->httpStatus ) {
-    	    return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
+		if (!is_null($httpError)) {
+    	    return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error [' . $httpError . ']');
+		} elseif ($httpStatus == $this->httpStatus) {
+    	    return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok [' . $httpStatus . ']');
 		} else {
-	        return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
+	        return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different [' . $this->httpStatus . ' was expected but ' . $httpStatus . ' was delivered]');
 		}
     }
 

Please login to merge, or discard this patch.

examples/resourceHttpStatus.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@
 block discarded – undo
 
 // http resource status check
 $httpStatusCheck = new \Leankoala\HealthFoundation\Check\Resource\Http\StatusCheck();
-$httpStatusCheck->init('https://about.google/intl/com/',200); // PASS
+$httpStatusCheck->init('https://about.google/intl/com/', 200); // PASS
 //$httpStatusCheck->init('https://about.google/intl/com/',404); // WARN
 //$httpStatusCheck->init('https://www.there-is-no-domain-connected-'.time().'.com/index.html',200); // FAIL
 $foundation->registerCheck($httpStatusCheck);

Please login to merge, or discard this patch.

		@@ -12,7 +12,7 @@ discard block
		block discarded – undo
12	12	private $destination = null;
13	13	private $httpStatus = null;
14	14
15		- public function init($destination,$httpStatus)
	15	+ public function init($destination, $httpStatus)
16	16	{
17	17	$this->destination = $destination;
18	18	$this->httpStatus = $httpStatus;
		@@ -27,15 +27,15 @@ discard block
		block discarded – undo
27	27	{
28	28	$ch = curl_init();
29	29
30		- curl_setopt( $ch, CURLOPT_URL, $this->destination );
	30	+ curl_setopt($ch, CURLOPT_URL, $this->destination);
31	31
32		- curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
33		- curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
34		- curl_setopt( $ch, CURLOPT_HEADER, true );
35		- curl_setopt( $ch, CURLOPT_NOBODY, true );
	32	+ curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
	33	+ curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'HEAD');
	34	+ curl_setopt($ch, CURLOPT_HEADER, true);
	35	+ curl_setopt($ch, CURLOPT_NOBODY, true);
36	36
37		- curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
38		- curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
	37	+ curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5); // connect timeout
	38	+ curl_setopt($ch, CURLOPT_TIMEOUT, 10); // curl timeout
39	39
40	40	// @todo configurable timeouts (do not put hundreds of parameters to the init method)
41	41	// @todo Handle SSL support on self-signed cert errors
		@@ -43,20 +43,20 @@ discard block
		block discarded – undo
43	43
44	44	$httpError = null;
45	45	$httpStatus = null;
46		- if ( curl_exec( $ch ) === false ) {
47		- $httpError = curl_error( $ch );
	46	+ if (curl_exec($ch) === false) {
	47	+ $httpError = curl_error($ch);
48	48	} else {
49		- $httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );
	49	+ $httpStatus = curl_getinfo($ch, CURLINFO_HTTP_CODE);
50	50	}
51	51
52		- curl_close( $ch );
	52	+ curl_close($ch);
53	53
54		- if ( !is_null( $httpError ) ) {
55		- return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
56		- } elseif ( $httpStatus == $this->httpStatus ) {
57		- return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
	54	+ if (!is_null($httpError)) {
	55	+ return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error [' . $httpError . ']');
	56	+ } elseif ($httpStatus == $this->httpStatus) {
	57	+ return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok [' . $httpStatus . ']');
58	58	} else {
59		- return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
	59	+ return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different [' . $this->httpStatus . ' was expected but ' . $httpStatus . ' was delivered]');
60	60	}
61	61	}
62	62

		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	public function init($destination,$httpStatus)
16	16	{
17	17	$this->destination = $destination;
18		- $this->httpStatus = $httpStatus;
	18	+ $this->httpStatus = $httpStatus;
19	19	}
20	20
21	21	/**
		@@ -25,39 +25,39 @@ discard block
		block discarded – undo
25	25	*/
26	26	public function run()
27	27	{
28		- $ch = curl_init();
	28	+ $ch = curl_init();
29	29
30		- curl_setopt( $ch, CURLOPT_URL, $this->destination );
	30	+ curl_setopt( $ch, CURLOPT_URL, $this->destination );
31	31
32		- curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
33		- curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
34		- curl_setopt( $ch, CURLOPT_HEADER, true );
35		- curl_setopt( $ch, CURLOPT_NOBODY, true );
	32	+ curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
	33	+ curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'HEAD' );
	34	+ curl_setopt( $ch, CURLOPT_HEADER, true );
	35	+ curl_setopt( $ch, CURLOPT_NOBODY, true );
36	36
37		- curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
38		- curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
	37	+ curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, 5 ); // connect timeout
	38	+ curl_setopt( $ch, CURLOPT_TIMEOUT, 10 ); // curl timeout
39	39
40		- // @todo configurable timeouts (do not put hundreds of parameters to the init method)
41		- // @todo Handle SSL support on self-signed cert errors
42		- // @todo Optional setup outgoing proxy host and port configuration
	40	+ // @todo configurable timeouts (do not put hundreds of parameters to the init method)
	41	+ // @todo Handle SSL support on self-signed cert errors
	42	+ // @todo Optional setup outgoing proxy host and port configuration
43	43
44		- $httpError = null;
45		- $httpStatus = null;
46		- if ( curl_exec( $ch ) === false ) {
47		- $httpError = curl_error( $ch );
48		- } else {
49		- $httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );
50		- }
	44	+ $httpError = null;
	45	+ $httpStatus = null;
	46	+ if ( curl_exec( $ch ) === false ) {
	47	+ $httpError = curl_error( $ch );
	48	+ } else {
	49	+ $httpStatus = curl_getinfo( $ch, CURLINFO_HTTP_CODE );
	50	+ }
51	51
52		- curl_close( $ch );
	52	+ curl_close( $ch );
53	53
54		- if ( !is_null( $httpError ) ) {
55		- return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
56		- } elseif ( $httpStatus == $this->httpStatus ) {
57		- return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
58		- } else {
59		- return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
60		- }
	54	+ if ( !is_null( $httpError ) ) {
	55	+ return new Result(Result::STATUS_FAIL, 'Http resource request ' . $this->destination . ' has an error ['.$httpError.']');
	56	+ } elseif ( $httpStatus == $this->httpStatus ) {
	57	+ return new Result(Result::STATUS_PASS, 'Http resource status for ' . $this->destination . ' is ok ['.$httpStatus.']');
	58	+ } else {
	59	+ return new Result(Result::STATUS_WARN, 'Http resource status for ' . $this->destination . ' is different ['.$this->httpStatus.' was expected but '.$httpStatus.' was delivered]' );
	60	+ }
61	61	}
62	62
63	63	public function getIdentifier()

		@@ -6,7 +6,7 @@
		block discarded – undo
6	6
7	7	// http resource status check
8	8	$httpStatusCheck = new \Leankoala\HealthFoundation\Check\Resource\Http\StatusCheck();
9		-$httpStatusCheck->init('https://about.google/intl/com/',200); // PASS
	9	+$httpStatusCheck->init('https://about.google/intl/com/', 200); // PASS
10	10	//$httpStatusCheck->init('https://about.google/intl/com/',404); // WARN
11	11	//$httpStatusCheck->init('https://www.there-is-no-domain-connected-'.time().'.com/index.html',200); // FAIL
12	12	$foundation->registerCheck($httpStatusCheck);

Leankoala / HealthFoundation

Pull Request — master (#1)

Status

Category

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch