Inspection of "Adjustment permissions" - LauLamanApps/iZettleApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Laurens

created 2018-08-21 15:30 UTC

Status

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -68,29 +68,29 @@
 block discarded – undo
     {
         $scope = [];
         if ($this->finance !== null) {
-		$scope[] = $this->finance->getValue().':'.self::FINANCE;
-		if($this->finance->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::FINANCE;
+        $scope[] = $this->finance->getValue().':'.self::FINANCE;
+        if($this->finance->getValue() == Rights::WRITE)
+            $scope[] = Rights::READ.':'.self::FINANCE;
         }
         if ($this->purchase !== null) {
-		$scope[] = $this->purchase->getValue().':'.self::PURCHASE;
-		if($this->purchase->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::PURCHASE;
+        $scope[] = $this->purchase->getValue().':'.self::PURCHASE;
+        if($this->purchase->getValue() == Rights::WRITE)
+            $scope[] = Rights::READ.':'.self::PURCHASE;
         }
         if ($this->product !== null) {
-        	$scope[] = $this->product->getValue().':'.self::PRODUCT;
-		if($this->product->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::PRODUCT;
+            $scope[] = $this->product->getValue().':'.self::PRODUCT;
+        if($this->product->getValue() == Rights::WRITE)
+            $scope[] = Rights::READ.':'.self::PRODUCT;
         }
         if ($this->inventory !== null) {
-		$scope[] = $this->inventory->getValue().':'.self::INVENTORY;
-		if($this->inventory->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::INVENTORY;
+        $scope[] = $this->inventory->getValue().':'.self::INVENTORY;
+        if($this->inventory->getValue() == Rights::WRITE)
+            $scope[] = Rights::READ.':'.self::INVENTORY;
         }
         if ($this->image !== null) {
-		$scope[] = $this->image->getValue().':'.self::IMAGE;
-		if($this->image->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::IMAGE;
+        $scope[] = $this->image->getValue().':'.self::IMAGE;
+        if($this->image->getValue() == Rights::WRITE)
+            $scope[] = Rights::READ.':'.self::IMAGE;
         }
         return implode(' ', $scope);
     }

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -69,27 +69,27 @@
 block discarded – undo
         $scope = [];
         if ($this->finance !== null) {
 		$scope[] = $this->finance->getValue().':'.self::FINANCE;
-		if($this->finance->getValue() == Rights::WRITE)
+		if ($this->finance->getValue() == Rights::WRITE)
 			$scope[] = Rights::READ.':'.self::FINANCE;
         }
         if ($this->purchase !== null) {
 		$scope[] = $this->purchase->getValue().':'.self::PURCHASE;
-		if($this->purchase->getValue() == Rights::WRITE)
+		if ($this->purchase->getValue() == Rights::WRITE)
 			$scope[] = Rights::READ.':'.self::PURCHASE;
         }
         if ($this->product !== null) {
         	$scope[] = $this->product->getValue().':'.self::PRODUCT;
-		if($this->product->getValue() == Rights::WRITE)
+		if ($this->product->getValue() == Rights::WRITE)
 			$scope[] = Rights::READ.':'.self::PRODUCT;
         }
         if ($this->inventory !== null) {
 		$scope[] = $this->inventory->getValue().':'.self::INVENTORY;
-		if($this->inventory->getValue() == Rights::WRITE)
+		if ($this->inventory->getValue() == Rights::WRITE)
 			$scope[] = Rights::READ.':'.self::INVENTORY;
         }
         if ($this->image !== null) {
 		$scope[] = $this->image->getValue().':'.self::IMAGE;
-		if($this->image->getValue() == Rights::WRITE)
+		if ($this->image->getValue() == Rights::WRITE)
 			$scope[] = Rights::READ.':'.self::IMAGE;
         }
         return implode(' ', $scope);

Please login to merge, or discard this patch.

Braces +15 added lines, -10 removed lines patch added patch discarded remove patch

@@ -69,28 +69,33 @@
 block discarded – undo
         $scope = [];
         if ($this->finance !== null) {
 		$scope[] = $this->finance->getValue().':'.self::FINANCE;
-		if($this->finance->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::FINANCE;
+		if($this->finance->getValue() == Rights::WRITE) {
+					$scope[] = Rights::READ.':'.self::FINANCE;
+		}
         }
         if ($this->purchase !== null) {
 		$scope[] = $this->purchase->getValue().':'.self::PURCHASE;
-		if($this->purchase->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::PURCHASE;
+		if($this->purchase->getValue() == Rights::WRITE) {
+					$scope[] = Rights::READ.':'.self::PURCHASE;
+		}
         }
         if ($this->product !== null) {
         	$scope[] = $this->product->getValue().':'.self::PRODUCT;
-		if($this->product->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::PRODUCT;
+		if($this->product->getValue() == Rights::WRITE) {
+					$scope[] = Rights::READ.':'.self::PRODUCT;
+		}
         }
         if ($this->inventory !== null) {
 		$scope[] = $this->inventory->getValue().':'.self::INVENTORY;
-		if($this->inventory->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::INVENTORY;
+		if($this->inventory->getValue() == Rights::WRITE) {
+					$scope[] = Rights::READ.':'.self::INVENTORY;
+		}
         }
         if ($this->image !== null) {
 		$scope[] = $this->image->getValue().':'.self::IMAGE;
-		if($this->image->getValue() == Rights::WRITE)
-			$scope[] = Rights::READ.':'.self::IMAGE;
+		if($this->image->getValue() == Rights::WRITE) {
+					$scope[] = Rights::READ.':'.self::IMAGE;
+		}
         }
         return implode(' ', $scope);
     }

Please login to merge, or discard this patch.

		@@ -68,29 +68,29 @@
		block discarded – undo
68	68	{
69	69	$scope = [];
70	70	if ($this->finance !== null) {
71		- $scope[] = $this->finance->getValue().':'.self::FINANCE;
72		- if($this->finance->getValue() == Rights::WRITE)
73		- $scope[] = Rights::READ.':'.self::FINANCE;
	71	+ $scope[] = $this->finance->getValue().':'.self::FINANCE;
	72	+ if($this->finance->getValue() == Rights::WRITE)
	73	+ $scope[] = Rights::READ.':'.self::FINANCE;
74	74	}
75	75	if ($this->purchase !== null) {
76		- $scope[] = $this->purchase->getValue().':'.self::PURCHASE;
77		- if($this->purchase->getValue() == Rights::WRITE)
78		- $scope[] = Rights::READ.':'.self::PURCHASE;
	76	+ $scope[] = $this->purchase->getValue().':'.self::PURCHASE;
	77	+ if($this->purchase->getValue() == Rights::WRITE)
	78	+ $scope[] = Rights::READ.':'.self::PURCHASE;
79	79	}
80	80	if ($this->product !== null) {
81		- $scope[] = $this->product->getValue().':'.self::PRODUCT;
82		- if($this->product->getValue() == Rights::WRITE)
83		- $scope[] = Rights::READ.':'.self::PRODUCT;
	81	+ $scope[] = $this->product->getValue().':'.self::PRODUCT;
	82	+ if($this->product->getValue() == Rights::WRITE)
	83	+ $scope[] = Rights::READ.':'.self::PRODUCT;
84	84	}
85	85	if ($this->inventory !== null) {
86		- $scope[] = $this->inventory->getValue().':'.self::INVENTORY;
87		- if($this->inventory->getValue() == Rights::WRITE)
88		- $scope[] = Rights::READ.':'.self::INVENTORY;
	86	+ $scope[] = $this->inventory->getValue().':'.self::INVENTORY;
	87	+ if($this->inventory->getValue() == Rights::WRITE)
	88	+ $scope[] = Rights::READ.':'.self::INVENTORY;
89	89	}
90	90	if ($this->image !== null) {
91		- $scope[] = $this->image->getValue().':'.self::IMAGE;
92		- if($this->image->getValue() == Rights::WRITE)
93		- $scope[] = Rights::READ.':'.self::IMAGE;
	91	+ $scope[] = $this->image->getValue().':'.self::IMAGE;
	92	+ if($this->image->getValue() == Rights::WRITE)
	93	+ $scope[] = Rights::READ.':'.self::IMAGE;
94	94	}
95	95	return implode(' ', $scope);
96	96	}

		@@ -69,27 +69,27 @@
		block discarded – undo
69	69	$scope = [];
70	70	if ($this->finance !== null) {
71	71	$scope[] = $this->finance->getValue().':'.self::FINANCE;
72		- if($this->finance->getValue() == Rights::WRITE)
	72	+ if ($this->finance->getValue() == Rights::WRITE)
73	73	$scope[] = Rights::READ.':'.self::FINANCE;
74	74	}
75	75	if ($this->purchase !== null) {
76	76	$scope[] = $this->purchase->getValue().':'.self::PURCHASE;
77		- if($this->purchase->getValue() == Rights::WRITE)
	77	+ if ($this->purchase->getValue() == Rights::WRITE)
78	78	$scope[] = Rights::READ.':'.self::PURCHASE;
79	79	}
80	80	if ($this->product !== null) {
81	81	$scope[] = $this->product->getValue().':'.self::PRODUCT;
82		- if($this->product->getValue() == Rights::WRITE)
	82	+ if ($this->product->getValue() == Rights::WRITE)
83	83	$scope[] = Rights::READ.':'.self::PRODUCT;
84	84	}
85	85	if ($this->inventory !== null) {
86	86	$scope[] = $this->inventory->getValue().':'.self::INVENTORY;
87		- if($this->inventory->getValue() == Rights::WRITE)
	87	+ if ($this->inventory->getValue() == Rights::WRITE)
88	88	$scope[] = Rights::READ.':'.self::INVENTORY;
89	89	}
90	90	if ($this->image !== null) {
91	91	$scope[] = $this->image->getValue().':'.self::IMAGE;
92		- if($this->image->getValue() == Rights::WRITE)
	92	+ if ($this->image->getValue() == Rights::WRITE)
93	93	$scope[] = Rights::READ.':'.self::IMAGE;
94	94	}
95	95	return implode(' ', $scope);

		@@ -69,28 +69,33 @@
		block discarded – undo
69	69	$scope = [];
70	70	if ($this->finance !== null) {
71	71	$scope[] = $this->finance->getValue().':'.self::FINANCE;
72		- if($this->finance->getValue() == Rights::WRITE)
73		- $scope[] = Rights::READ.':'.self::FINANCE;
	72	+ if($this->finance->getValue() == Rights::WRITE) {
	73	+ $scope[] = Rights::READ.':'.self::FINANCE;
	74	+ }
74	75	}
75	76	if ($this->purchase !== null) {
76	77	$scope[] = $this->purchase->getValue().':'.self::PURCHASE;
77		- if($this->purchase->getValue() == Rights::WRITE)
78		- $scope[] = Rights::READ.':'.self::PURCHASE;
	78	+ if($this->purchase->getValue() == Rights::WRITE) {
	79	+ $scope[] = Rights::READ.':'.self::PURCHASE;
	80	+ }
79	81	}
80	82	if ($this->product !== null) {
81	83	$scope[] = $this->product->getValue().':'.self::PRODUCT;
82		- if($this->product->getValue() == Rights::WRITE)
83		- $scope[] = Rights::READ.':'.self::PRODUCT;
	84	+ if($this->product->getValue() == Rights::WRITE) {
	85	+ $scope[] = Rights::READ.':'.self::PRODUCT;
	86	+ }
84	87	}
85	88	if ($this->inventory !== null) {
86	89	$scope[] = $this->inventory->getValue().':'.self::INVENTORY;
87		- if($this->inventory->getValue() == Rights::WRITE)
88		- $scope[] = Rights::READ.':'.self::INVENTORY;
	90	+ if($this->inventory->getValue() == Rights::WRITE) {
	91	+ $scope[] = Rights::READ.':'.self::INVENTORY;
	92	+ }
89	93	}
90	94	if ($this->image !== null) {
91	95	$scope[] = $this->image->getValue().':'.self::IMAGE;
92		- if($this->image->getValue() == Rights::WRITE)
93		- $scope[] = Rights::READ.':'.self::IMAGE;
	96	+ if($this->image->getValue() == Rights::WRITE) {
	97	+ $scope[] = Rights::READ.':'.self::IMAGE;
	98	+ }
94	99	}
95	100	return implode(' ', $scope);
96	101	}

LauLamanApps / iZettleApi

Pull Request — master (#24)

Status

Category

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Braces +15 added lines, -10 removed lines patch added patch discarded remove patch