LaravelRUS / SleepingOwlAdmin

src/Display/DisplayTabbed.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     }
 
     /**
-     * @return TabInterface[]|DisplayTabsCollection
+     * @return \SleepingOwl\Admin\Form\FormElementsCollection
      */
     public function getTabs()
     {

src/Form/Element/Custom.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
     }
 
     /**
-     * @return $this|Custom|mixed
+     * @return string
      */
     public function render()
     {

src/Form/FormDefault.php

Doc Comments +2 added lines, -2 removed lines

@@ -213,7 +213,7 @@ 
      * @deprecated 4.5.0
      * @see getElements()
      *
-     * @return Collection[]
+     * @return FormElementsCollection
      */
     public function getItems()
     {
@@ -301,7 +301,7 @@ 
      *
      * @param ModelConfigurationInterface $modelConfiguration
      *
-     * @return bool
+     * @return null|boolean
      */
     public function saveForm(ModelConfigurationInterface $modelConfiguration)
     {

tests/Admin/Form/Element/NamedFormElementTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
      * @param string $path
      * @param string|null $label
      *
-     * @return NamedFormElement
+     * @return PHPUnit_Framework_MockObject_MockObject
      */
     protected function getElement($path = 'path', $label = null)
     {

Spacing +11 added lines, -11 removed lines

@@ -97,7 +97,7 @@ 
         $element = $this->getElement('key');
 
         $element->required();
-        $this->assertEquals(['key' => ['required']], $element->getValidationRules());
+        $this->assertEquals([ 'key' => [ 'required' ] ], $element->getValidationRules());
     }
 
     /**
@@ -110,7 +110,7 @@ 
 
         $element->required('required field');
 
-        $this->assertEquals(['key.required' => 'required field'], $element->getValidationMessages());
+        $this->assertEquals([ 'key.required' => 'required field' ], $element->getValidationMessages());
     }
 
     /**
@@ -127,7 +127,7 @@ 
         $model->shouldReceive('getTable')->once()->andReturn('test_table');
 
         $element->unique();
-        $this->assertEquals(['key' => ['unique:test_table,key']], $element->getValidationRules());
+        $this->assertEquals([ 'key' => [ 'unique:test_table,key' ] ], $element->getValidationRules());
     }
 
     /**
@@ -139,7 +139,7 @@ 
         $element = $this->getElement('key');
 
         $element->unique('must be unique');
-        $this->assertEquals(['key.unique' => 'must be unique'], $element->getValidationMessages());
+        $this->assertEquals([ 'key.unique' => 'must be unique' ], $element->getValidationMessages());
     }
 
     /**
@@ -152,7 +152,7 @@ 
 
         $element->addValidationMessage('test', 'test message');
         $element->addValidationMessage('hello', 'hello message');
-        $this->assertEquals(['key.test' => 'test message', 'key.hello' => 'hello message'], $element->getValidationMessages());
+        $this->assertEquals([ 'key.test' => 'test message', 'key.hello' => 'hello message' ], $element->getValidationMessages());
     }
 
     /**
@@ -162,7 +162,7 @@ 
     {
         $element = $this->getElement('key.subkey', 'Label');
 
-        $this->assertEquals(['key.subkey' => 'Label'], $element->getValidationLabels());
+        $this->assertEquals([ 'key.subkey' => 'Label' ], $element->getValidationLabels());
     }
 
     /**
@@ -170,7 +170,7 @@ 
      */
     public function test_gets_session_value_from_request()
     {
-        $request = $this->app['request'];
+        $request = $this->app[ 'request' ];
         $session = $request->getSession();
 
         $element = $this->getElement('key.subkey', 'Label');
@@ -185,7 +185,7 @@ 
     public function test_gets_value_from_request()
     {
         /** @var \Illuminate\Http\Request $request */
-        $request = $this->app['request'];
+        $request = $this->app[ 'request' ];
         $request->offsetSet('key', [
             'subkey1' => 'hello world',
         ]);
@@ -202,7 +202,7 @@ 
      */
     public function test_gets_value_with_request()
     {
-        $request = $this->app['request'];
+        $request = $this->app[ 'request' ];
 
         $session = $request->getSession();
         $session->shouldReceive('getOldInput')->andReturn(null);
@@ -220,7 +220,7 @@ 
      */
     public function test_gets_value()
     {
-        $request = $this->app['request'];
+        $request = $this->app[ 'request' ];
         $session = $request->getSession();
         $session->shouldReceive('getOldInput')->andReturn(null);
 
@@ -286,7 +286,7 @@ 
     {
         $element = $this->getElement('key2.subkey', 'Label');
 
-        $request = $this->app['request'];
+        $request = $this->app[ 'request' ];
         $session = $request->getSession();
         $session->shouldReceive('getOldInput')->andReturn(null);
 

tests/Admin/Form/FormElementTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 class FormElementTest extends TestCase
 {
     /**
-     * @return FormElement
+     * @return PHPUnit_Framework_MockObject_MockObject
      */
     protected function getElement()
     {

Spacing +9 added lines, -9 removed lines

@@ -35,7 +35,7 @@ 
 
         $rule = 'some_rule';
         $element->addValidationRule($rule);
-        $this->assertEquals([$rule], $element->getValidationRules());
+        $this->assertEquals([ $rule ], $element->getValidationRules());
     }
 
     /**
@@ -56,8 +56,8 @@ 
             $message = 'my custom message'
         );
 
-        $this->assertEquals([$rule], $element->getValidationRules());
-        $this->assertEquals([$rule => $message], $element->getValidationMessages());
+        $this->assertEquals([ $rule ], $element->getValidationRules());
+        $this->assertEquals([ $rule => $message ], $element->getValidationMessages());
     }
 
     /**
@@ -79,7 +79,7 @@ 
             $message1 = 'my custom message 1'
         );
 
-        $this->assertEquals(['min' => $message, $rule1 => $message1], $element->getValidationMessages());
+        $this->assertEquals([ 'min' => $message, $rule1 => $message1 ], $element->getValidationMessages());
     }
 
     /**
@@ -96,13 +96,13 @@ 
             'max' => 'test',
         ]);
 
-        $this->assertEquals(['min' => 'test', 'max' => 'test'], $element->getValidationMessages());
+        $this->assertEquals([ 'min' => 'test', 'max' => 'test' ], $element->getValidationMessages());
 
         $element->setValidationMessages([
             'max' => 'test',
         ]);
 
-        $this->assertEquals(['max' => 'test'], $element->getValidationMessages());
+        $this->assertEquals([ 'max' => 'test' ], $element->getValidationMessages());
     }
 
     /**
@@ -184,7 +184,7 @@ 
     {
         $array = $this->getElement()->toArray();
         $this->assertTrue(is_array($array));
-        $this->assertEquals(['value', 'readonly', 'model'], array_keys($array));
+        $this->assertEquals([ 'value', 'readonly', 'model' ], array_keys($array));
     }
 
     /**
@@ -233,7 +233,7 @@ 
 
         $element->setModel($model);
 
-        $element->setReadonly(function ($model) {
+        $element->setReadonly(function($model) {
             return $model->isAuthor();
         });
 
@@ -251,7 +251,7 @@ 
         $model->shouldReceive('isAuthor')->andReturn(true)->once();
         $element->setModel($model);
 
-        $element->setVisibilityCondition(function ($model) {
+        $element->setVisibilityCondition(function($model) {
             return $model->isAuthor();
         });
 

src/Form/FormElement.php

Spacing +7 added lines, -7 removed lines

@@ -30,12 +30,12 @@ 
     /**
      * @var array
      */
-    protected $validationRules = [];
+    protected $validationRules = [ ];
 
     /**
      * @var array
      */
-    protected $validationMessages = [];
+    protected $validationMessages = [ ];
 
     /**
      * @var bool
@@ -72,7 +72,7 @@ 
             $rule = substr($rule, 0, $pos);
         }
 
-        $this->validationMessages[$rule] = $message;
+        $this->validationMessages[ $rule ] = $message;
 
         return $this;
     }
@@ -94,7 +94,7 @@ 
      */
     public function getValidationLabels()
     {
-        return [];
+        return [ ];
     }
 
     /**
@@ -113,7 +113,7 @@ 
      */
     public function addValidationRule($rule, $message = null)
     {
-        $this->validationRules[] = $rule;
+        $this->validationRules[ ] = $rule;
 
         if (is_null($message)) {
             return $this;
@@ -129,11 +129,11 @@ 
      */
     public function setValidationRules($validationRules)
     {
-        if (! is_array($validationRules)) {
+        if (!is_array($validationRules)) {
             $validationRules = func_get_args();
         }
 
-        $this->validationRules = [];
+        $this->validationRules = [ ];
         foreach ($validationRules as $rule) {
             $rules = explode('|', $rule);
 

src/Form/Element/DependentSelect.php

Spacing +14 added lines, -14 removed lines

@@ -17,16 +17,16 @@ 
     {
         $routeName = 'admin.form.element.dependent-select';
 
-        if (! $router->has($routeName)) {
-            $router->post('{adminModel}/dependent-select/{field}/{id?}', ['as' => $routeName, function (
+        if (!$router->has($routeName)) {
+            $router->post('{adminModel}/dependent-select/{field}/{id?}', [ 'as' => $routeName, function(
                 Request $request,
                 ModelConfigurationInterface $model,
                 $field,
                 $id = null
             ) {
-                if (! is_null($id)) {
+                if (!is_null($id)) {
                     $item = $model->getRepository()->find($id);
-                    if (is_null($item) || ! $model->isEditable($item)) {
+                    if (is_null($item) || !$model->isEditable($item)) {
                         return new JsonResponse([
                             'message' => trans('lang.message.access_denied'),
                         ], 403);
@@ -34,7 +34,7 @@ 
 
                     $form = $model->fireEdit($id);
                 } else {
-                    if (! $model->isCreatable()) {
+                    if (!$model->isCreatable()) {
                         return new JsonResponse([
                             'message' => trans('lang.message.access_denied'),
                         ], 403);
@@ -50,24 +50,24 @@ 
                 }
 
                 $element->setAjaxParameters(
-                    $request->input('depdrop_all_params', [])
+                    $request->input('depdrop_all_params', [ ])
                 );
 
                 $options = $element->getOptions();
 
                 if ($element->isNullable()) {
-                    $options = [null => trans('sleeping_owl::lang.select.nothing')] + $options;
+                    $options = [ null => trans('sleeping_owl::lang.select.nothing') ] + $options;
                 }
 
                 $options = array_except($options, $element->exclude);
 
                 return new JsonResponse([
-                    'output' => collect($options)->map(function ($value, $key) {
-                        return ['id' => $key, 'name' => $value];
+                    'output' => collect($options)->map(function($value, $key) {
+                        return [ 'id' => $key, 'name' => $value ];
                     }),
                     'selected' => $element->getValue(),
                 ]);
-            }]);
+            } ]);
         }
     }
 
@@ -79,7 +79,7 @@ 
     /**
      * @var array
      */
-    protected $dataDepends = [];
+    protected $dataDepends = [ ];
 
     /**
      * @var array
@@ -93,9 +93,9 @@ 
      * @param null $label
      * @param array $depends
      */
-    public function __construct($path, $label = null, array $depends = [])
+    public function __construct($path, $label = null, array $depends = [ ])
     {
-        parent::__construct($path, $label, []);
+        parent::__construct($path, $label, [ ]);
 
         $this->setDataDepends($depends);
     }
@@ -179,7 +179,7 @@ 
         ];
 
         if ($this->isReadonly()) {
-            $attributes['disabled'] = 'disabled';
+            $attributes[ 'disabled' ] = 'disabled';
         }
 
         return [

src/Form/Element/NamedFormElement.php

Spacing +9 added lines, -9 removed lines

@@ -83,7 +83,7 @@ 
     {
         $name = array_shift($parts);
 
-        while (! empty($parts)) {
+        while (!empty($parts)) {
             $part = array_shift($parts);
             $name .= "[$part]";
         }
@@ -236,7 +236,7 @@ 
     {
         $this->addValidationRule('_unique');
 
-        if (! is_null($message)) {
+        if (!is_null($message)) {
             $this->addValidationMessage('unique', $message);
         }
 
@@ -251,8 +251,8 @@ 
         $messages = parent::getValidationMessages();
 
         foreach ($messages as $rule => $message) {
-            $messages[$this->getName().'.'.$rule] = $message;
-            unset($messages[$rule]);
+            $messages[ $this->getName().'.'.$rule ] = $message;
+            unset($messages[ $rule ]);
         }
 
         return $messages;
@@ -263,7 +263,7 @@ 
      */
     public function getValidationLabels()
     {
-        return [$this->getPath() => $this->getLabel()];
+        return [ $this->getPath() => $this->getLabel() ];
     }
 
     /**
@@ -271,7 +271,7 @@ 
      */
     public function getValueFromRequest()
     {
-        if (Request::hasSession() && ! is_null($value = Request::old($this->getPath()))) {
+        if (Request::hasSession() && !is_null($value = Request::old($this->getPath()))) {
             return $value;
         }
 
@@ -284,14 +284,14 @@ 
      */
     public function getValue()
     {
-        if (! is_null($value = $this->getValueFromRequest())) {
+        if (!is_null($value = $this->getValueFromRequest())) {
             return $value;
         }
 
         $model = $this->getModel();
         $value = $this->getDefaultValue();
 
-        if (is_null($model) or ! $model->exists) {
+        if (is_null($model) or !$model->exists) {
             return $value;
         }
 
@@ -343,7 +343,7 @@ 
         }
         unset($rule);
 
-        return [$this->getPath() => $rules];
+        return [ $this->getPath() => $rules ];
     }
 
     /**

src/Form/FormElementsCollection.php

Spacing +3 added lines, -3 removed lines

@@ -12,9 +12,9 @@ 
      */
     public function onlyActive()
     {
-        return $this->filter(function ($element) {
+        return $this->filter(function($element) {
             if ($element instanceof FormElementInterface) {
-                return ! $element->isReadonly();
+                return !$element->isReadonly();
             }
 
             return true;
@@ -26,7 +26,7 @@ 
      */
     public function onlyVisible()
     {
-        return $this->filter(function ($element) {
+        return $this->filter(function($element) {
             if ($element instanceof FormElementInterface) {
                 return $element->isVisible();
             }