SleepingOwl\Admin\Form\Related\HasUniqueValidation::addUniqueValidation()

Complexity

Conditions	5
Paths	4

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function addUniqueValidation()
    {
        if (count((array) $this->unique) > 0) {
            $pairs = [];
            $parameters = array_unique(array_merge([
                $mainKey = $this->getModel()->getForeignKey(),

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ], $this->unique));

            $errorColumns = array_filter($parameters, function ($param) use ($mainKey) {
                return $param !== $mainKey;
            });

            $relations = (array) request($this->relationName);

            foreach ($relations as $index => $relation) {
                $relation[$mainKey] = $this->getModel()->getKey();
                $key = $this->getCompositeKey($relation, (array) $parameters);

It seems like getCompositeKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                if (array_key_exists($key, $pairs)) {
                    foreach ($errorColumns as $column) {
                        $this->validationRules[$this->relationName.'.'.$index.'.'.$column] = 'unique_related';

The property validationRules does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    }
                } else {
                    $pairs[$key] = true;
                }