SleepingOwl\Admin\Form\Related\HasUniqueValidation

Complexity

Total Complexity

8

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeUniqueValidator()	0	5	1
A	getValidationRules()	0	5	1
B	addUniqueValidation()	0	24	5
A	unique()	0	6	1

<?php

namespace SleepingOwl\Admin\Form\Related;

use Validator;

trait HasUniqueValidation
{
    protected $unique;

    /**
     * @param array $columns
     * @param string|null $message
     *
     * @return static
     */
    public function unique(array $columns, $message = null)
    {
        $this->initializeUniqueValidator($message);
        $this->unique = $columns;

        return $this;
    }

    protected function initializeUniqueValidator($message = null)
    {
        Validator::extendImplicit('unique_related', function () {
            return false;
        }, $message);
    }

    public function getValidationRules()
    {
        $this->addUniqueValidation();

        return parent::getValidationRules();
    }

    protected function addUniqueValidation()
    {
        if (count((array) $this->unique) > 0) {
            $pairs = [];
            $parameters = array_unique(array_merge([
                $mainKey = $this->getModel()->getForeignKey(),

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ], $this->unique));

            $errorColumns = array_filter($parameters, function ($param) use ($mainKey) {
                return $param !== $mainKey;
            });

            $relations = (array) request($this->relationName);

            foreach ($relations as $index => $relation) {
                $relation[$mainKey] = $this->getModel()->getKey();
                $key = $this->getCompositeKey($relation, (array) $parameters);

It seems like getCompositeKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                if (array_key_exists($key, $pairs)) {
                    foreach ($errorColumns as $column) {
                        $this->validationRules[$this->relationName.'.'.$index.'.'.$column] = 'unique_related';

The property validationRules does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    }
                } else {
                    $pairs[$key] = true;
                }
            }
        }
    }
}