LaravelRUS / GitterBot

app/Core/Mappers/MessageMapperTrait.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use App\Message;
 use Carbon\Carbon;
 use App\Gitter\Support\AttributeMapper;
-use Illuminate\Database\Eloquent\Model;
 
 /**
  * Class MessageMapperTrait

Spacing +6 added lines, -6 removed lines

@@ -36,19 +36,19 @@ 
         $values = (new AttributeMapper($attributes))
             ->rename('readBy', 'read_by')
             ->rename('id', 'gitter_id')
-            ->value('editedAt', function ($val) {
+            ->value('editedAt', function($val) {
                 return !!$val;
             }, 'edited')
-            ->value('fromUser', function ($user) {
+            ->value('fromUser', function($user) {
                 return User::fromGitterObject($user);
             }, 'user')
-            ->value('sent', function ($date) {
+            ->value('sent', function($date) {
                 return (new Carbon($date))->setTimezone('Europe/Moscow');
             }, 'created_at')
-            ->value('editedAt', function ($date) {
+            ->value('editedAt', function($date) {
                 return (new Carbon($date))->setTimezone('Europe/Moscow');
             }, 'updated_at')
-            ->value('mentions', function ($mentions) {
+            ->value('mentions', function($mentions) {
                 return static::parseMentions($mentions);
             })
             ->only($fields)
@@ -58,7 +58,7 @@ 
             $values['room_id'] = \App::make(Room::class)->id;
         }
 
-        return static::unguarded(function () use ($values) {
+        return static::unguarded(function() use ($values) {
             return new static($values);
         });
     }

app/Domains/Bot/Middlewares/KarmaRenderMiddleware.php

Doc Comments +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 {
     /**
      * @param Message $message
-     * @return mixed
+     * @return null|Message
      */
     public function handle(Message $message)
     {

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     {
         $achievements = [];
         foreach ($message->user->achievements as $achieve) {
-            $achievements[] = '"' . $achieve->title . '"';
+            $achievements[] = '"'.$achieve->title.'"';
         }
 
         if (count($achievements)) {

app/Domains/User.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
     }
 
     /**
-     * @param $roomId
+     * @param string $roomId
      * @return Carbon
      */
     public function getLastKarmaTimeForRoom($roomId)

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     {
         $karma = $this->karma->count();
 
-        return ($karma > 0 ? '+' : '') . $karma;
+        return ($karma > 0 ? '+' : '').$karma;
     }
 
     /**

app/Interfaces/Console/Commands/StartGitterBot.php

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use Illuminate\Console\Command;
 use Illuminate\Contracts\Config\Repository;
 use Illuminate\Contracts\Container\Container;
-use Illuminate\Support\Facades\Log;
 
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
      */
     protected function makePidFile()
     {
-        $this->pid = storage_path('pids/' . date('Y_m_d_tis_') . microtime(1) . '.pid');
+        $this->pid = storage_path('pids/'.date('Y_m_d_tis_').microtime(1).'.pid');
         file_put_contents($this->pid, getmypid());
     }
 

app/Core/Providers/RouteServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      */
     public function map(Router $router)
     {
-        $router->group(['namespace' => $this->namespace], function ($router) {
+        $router->group(['namespace' => $this->namespace], function($router) {
             require app_path('Http/routes.php');
         });
     }

app/Domains/Karma.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     {
         parent::boot();
 
-        static::creating(function (Karma $karma) {
+        static::creating(function(Karma $karma) {
             if (!$karma->created_at) {
                 $karma->created_at = $karma->freshTimestamp();
             }

app/Domains/Achieve.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
     {
         parent::boot();
 
-        static::creating(function (Achieve $achieve) {
+        static::creating(function(Achieve $achieve) {
             if (!$achieve->created_at) {
                 $achieve->created_at = $achieve->freshTimestamp();
             }

app/Interfaces/Gitter/Http/Stream.php

Spacing +5 added lines, -5 removed lines

@@ -85,7 +85,7 @@ 
 
         $this->headers['Connection'] = 'Keep-Alive';
 
-        $this->buffer->subscribe(function ($message) {
+        $this->buffer->subscribe(function($message) {
             $message = trim($message);
 
             if ($message) {
@@ -117,20 +117,20 @@ 
             ->getHttpClient()
             ->request($this->method, $this->url, $this->headers);
 
-        $request->on('response', function (Response $response) {
-            $response->on('data', function ($data, Response $response) {
+        $request->on('response', function(Response $response) {
+            $response->on('data', function($data, Response $response) {
                 $data = (string)$data;
                 $this->events->fire(static::EVENT_CHUNK, [$this, $data, $response]);
                 $this->buffer->add($data);
             });
         });
 
-        $request->on('end', function () {
+        $request->on('end', function() {
             $this->buffer->clear();
             $this->events->fire(static::EVENT_END, [$this]);
         });
 
-        $request->on('error', function ($exception) {
+        $request->on('error', function($exception) {
             $this->events->fire(static::EVENT_ERROR, [$this, $exception]);
         });
 

app/Interfaces/Http/Controllers/Api/AchievementsController.php

Spacing +3 added lines, -3 removed lines

@@ -27,20 +27,20 @@
      */
     public function index()
     {
-        return \Cache::remember('achievements', 10, function () {
+        return \Cache::remember('achievements', 10, function() {
             $achieveStorage = [];
 
             (new Achieve())
                 ->selectRaw('name, count(user_id) as count')
                 ->groupBy('name')
                 ->get()
-                ->each(function ($item) use (&$achieveStorage) {
+                ->each(function($item) use (&$achieveStorage) {
                     $achieveStorage[$item->name] = $item->count;
                 });
 
             return (new AchieveSubscriber())
                 ->toCollection()
-                ->each(function (AbstractAchieve $achieve) use ($achieveStorage) {
+                ->each(function(AbstractAchieve $achieve) use ($achieveStorage) {
                     $achieve->users = $achieveStorage[$achieve->name] ?? 0;
                 })
                 ->toArray();