GitterRoomListenCommand::listen() - Code Metrics - Inspection of "Improve api" - LaravelRUS/GitterBot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b4fba5...9773af )

by Kirill

created 2016-01-26 02:39 UTC

GitterRoomListenCommand::listen() A

↳ Parent: GitterRoomListenCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	1
eloc	7
nc	1
nop	1

<?php
namespace App\Console\Commands;


use App\Room;
use Gitter\Client;
use React\EventLoop\LoopInterface;
use Gitter\Models\Room as GitterRoom;
use Gitter\Models\Message as GitterMessage;
use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Container\Container;
use Gitter\Iterators\PromiseIterator\Controls;



/**
 * Class GitterRoomListenCommand
 * @package App\Console\Commands
 *
 * Прослушивание сообщений требуемой комнаты
 */
class GitterRoomListenCommand extends AbstractCommand
{
    /**
     * @var string
     */
    protected $signature = 'gitter:listen {room}';

    /**
     * @var string
     */
    protected $description = 'Listen gitter room';

    /**
     * Execute the console command.
     *
     * @param Repository $config
     * @param Container $container
     *
     * @return mixed
     */
    public function handle(Repository $config, Container $container)

    {
        /** @var Client $client */
        $client = $this->createClient($container, $config->get('gitter.token'));

        $this->findRoom($client, $this->argument('room'), function(GitterRoom $room) {

            try {
                $this->listen($room);
            } catch (\Throwable $e) {
                $this->error($e->getMessage());
            }
        });


        /** @var LoopInterface $loop */
        $loop = $container->make(LoopInterface::class);
        $loop->run();
    }

    /**
     * @param GitterRoom $gitter
     */
    protected function listen(GitterRoom $gitter)
    {
        /** @var Room $room */
        $room = Room::make($gitter, function(Room $room) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            //
        });

        /** @var LoopInterface $loop */
        $loop = app(LoopInterface::class);


        $gitter->onMessage(function(GitterMessage $msg) {
            $this->onMessage($msg);
        }, function(\Throwable $e) use ($loop, $gitter) {

            $this->onMessageFallback($loop, $gitter);
        });
    }

    /**
     * Message stream throw http api
     *
     * @param LoopInterface $loop
     * @param GitterRoom $gitter
     */
    protected function onMessageFallback(LoopInterface $loop, GitterRoom $gitter)
    {
        $this->warn('Stream not available. Use message fallback fetch mode.');

        $gitter->getMessages()
            ->fetch(function(GitterMessage $message, Controls $controls) {
                $this->onMessage($message);

                if ($controls->index() <= 100) {
                    $controls->next();
                }
            });

        $loop->addTimer(10, function() use ($gitter) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->warn('Connection retries.');
            $this->listen($gitter);
        });
    }

    protected function onMessage(GitterMessage $gitter)

    {
        //
    }
}







1		<?php
2		namespace App\Console\Commands;
3
4
5		use App\Room;
6		use Gitter\Client;
7		use React\EventLoop\LoopInterface;
8		use Gitter\Models\Room as GitterRoom;
9		use Gitter\Models\Message as GitterMessage;
10		use Illuminate\Contracts\Config\Repository;
11		use Illuminate\Contracts\Container\Container;
12		use Gitter\Iterators\PromiseIterator\Controls;
13
14
15
16		/**
17		* Class GitterRoomListenCommand
18		* @package App\Console\Commands
19		*
20		* Прослушивание сообщений требуемой комнаты
21		*/
22		class GitterRoomListenCommand extends AbstractCommand
23		{
24		/**
25		* @var string
26		*/
27		protected $signature = 'gitter:listen {room}';
28
29		/**
30		* @var string
31		*/
32		protected $description = 'Listen gitter room';
33
34		/**
35		* Execute the console command.
36		*
37		* @param Repository $config
38		* @param Container $container
39		*
40		* @return mixed
41		*/
42	View Code Duplication	public function handle(Repository $config, Container $container)
		0 ignored issues – show Duplication introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		/** @var Client $client */
45		$client = $this->createClient($container, $config->get('gitter.token'));
46
47		$this->findRoom($client, $this->argument('room'), function(GitterRoom $room) {
		0 ignored issues – show Bug introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report It seems like `$this->argument('room')` targeting `Illuminate\Console\Command::argument()` can also be of type `array`; however, `App\Console\Commands\AbstractCommand::findRoom()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
48		try {
49		$this->listen($room);
50		} catch (\Throwable $e) {
51		$this->error($e->getMessage());
52		}
53		});
54
55
56		/** @var LoopInterface $loop */
57		$loop = $container->make(LoopInterface::class);
58		$loop->run();
59		}
60
61		/**
62		* @param GitterRoom $gitter
63		*/
64		protected function listen(GitterRoom $gitter)
65		{
66		/** @var Room $room */
67		$room = Room::make($gitter, function(Room $room) {
		0 ignored issues – show Unused Code introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report `$room` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report The parameter `$room` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
68		//
69		});
70
71		/** @var LoopInterface $loop */
72		$loop = app(LoopInterface::class);
73
74
75		$gitter->onMessage(function(GitterMessage $msg) {
76		$this->onMessage($msg);
77		}, function(\Throwable $e) use ($loop, $gitter) {
		0 ignored issues – show Unused Code introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
78		$this->onMessageFallback($loop, $gitter);
79		});
80		}
81
82		/**
83		* Message stream throw http api
84		*
85		* @param LoopInterface $loop
86		* @param GitterRoom $gitter
87		*/
88		protected function onMessageFallback(LoopInterface $loop, GitterRoom $gitter)
89		{
90		$this->warn('Stream not available. Use message fallback fetch mode.');
91
92		$gitter->getMessages()
93		->fetch(function(GitterMessage $message, Controls $controls) {
94		$this->onMessage($message);
95
96		if ($controls->index() <= 100) {
97		$controls->next();
98		}
99		});
100
101		$loop->addTimer(10, function() use ($gitter) {
		0 ignored issues – show Documentation introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report `10` is of type `integer`, but the function expects a `object<React\EventLoop\numeric>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
102		$this->warn('Connection retries.');
103		$this->listen($gitter);
104		});
105		}
106
107		protected function onMessage(GitterMessage $gitter)
		0 ignored issues – show Unused Code introduced 2016-01-26 02:51 UTC by Report Bug Copy Issue Report The parameter `$gitter` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
108		{
109		//
110		}
111		}
112
113
114
115
116
117

LaravelRUS / GitterBot

Push — develop ( b4fba5...9773af )

GitterRoomListenCommand::listen() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like