App\Console\Commands\GitterRoomListenCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	90
Duplicated Lines	20 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	5
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	18	18	2
A	listen()	0	17	1
A	onMessageFallback()	0	18	2
A	onMessage()	0	4	1

<?php
namespace App\Console\Commands;


use App\Room;
use Gitter\Client;
use React\EventLoop\LoopInterface;
use Gitter\Models\Room as GitterRoom;
use Gitter\Models\Message as GitterMessage;
use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Container\Container;
use Gitter\Iterators\PromiseIterator\Controls;



/**
 * Class GitterRoomListenCommand
 * @package App\Console\Commands
 *
 * Прослушивание сообщений требуемой комнаты
 */
class GitterRoomListenCommand extends AbstractCommand
{
    /**
     * @var string
     */
    protected $signature = 'gitter:listen {room}';

    /**
     * @var string
     */
    protected $description = 'Listen gitter room';

    /**
     * Execute the console command.
     *
     * @param Repository $config
     * @param Container $container
     *
     * @return mixed
     */
    public function handle(Repository $config, Container $container)

This method seems to be duplicated in your project.

    {
        /** @var Client $client */
        $client = $this->createClient($container, $config->get('gitter.token'));

        $this->findRoom($client, $this->argument('room'), function(GitterRoom $room) {

It seems like $this->argument('room') targeting Illuminate\Console\Command::argument() can also be of type array; however, App\Console\Commands\AbstractCommand::findRoom() does only seem to accept string, maybe add an additional type check?

            try {
                $this->listen($room);
            } catch (\Throwable $e) {
                $this->error($e->getMessage());
            }
        });


        /** @var LoopInterface $loop */
        $loop = $container->make(LoopInterface::class);
        $loop->run();
    }

    /**
     * @param GitterRoom $gitter
     */
    protected function listen(GitterRoom $gitter)
    {
        /** @var Room $room */
        $room = Room::make($gitter, function(Room $room) {

$room is not used, you could remove the assignment.

The parameter $room is not used and could be removed.

            //
        });

        /** @var LoopInterface $loop */
        $loop = app(LoopInterface::class);


        $gitter->onMessage(function(GitterMessage $msg) {
            $this->onMessage($msg);
        }, function(\Throwable $e) use ($loop, $gitter) {

The parameter $e is not used and could be removed.

            $this->onMessageFallback($loop, $gitter);
        });
    }

    /**
     * Message stream throw http api
     *
     * @param LoopInterface $loop
     * @param GitterRoom $gitter
     */
    protected function onMessageFallback(LoopInterface $loop, GitterRoom $gitter)
    {
        $this->warn('Stream not available. Use message fallback fetch mode.');

        $gitter->getMessages()
            ->fetch(function(GitterMessage $message, Controls $controls) {
                $this->onMessage($message);

                if ($controls->index() <= 100) {
                    $controls->next();
                }
            });

        $loop->addTimer(10, function() use ($gitter) {

10 is of type integer, but the function expects a object<React\EventLoop\numeric>.

            $this->warn('Connection retries.');
            $this->listen($gitter);
        });
    }

    protected function onMessage(GitterMessage $gitter)

The parameter $gitter is not used and could be removed.

    {
        //
    }
}