Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#4988)
by Cristian
32:23 queued 17:21
created
src/app/Library/CrudPanel/Uploads/Interfaces/UploaderInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
     public function deleteUploadedFile(Model $entry);
14 14
 
15
-    public static function for(array $field, array $configuration);
15
+    public static function for (array $field, array $configuration);
16 16
 
17 17
     public function __construct(array $crudObject, array $configuration);
18 18
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
      */
139 139
     public function afterField($targetFieldName)
140 140
     {
141
-        $this->transformFields(function ($fields) use ($targetFieldName) {
141
+        $this->transformFields(function($fields) use ($targetFieldName) {
142 142
             return $this->moveField($fields, $targetFieldName, false);
143 143
         });
144 144
     }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
      */
151 151
     public function beforeField($targetFieldName)
152 152
     {
153
-        $this->transformFields(function ($fields) use ($targetFieldName) {
153
+        $this->transformFields(function($fields) use ($targetFieldName) {
154 154
             return $this->moveField($fields, $targetFieldName, true);
155 155
         });
156 156
     }
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function makeFirstField()
164 164
     {
165
-        if (! $this->fields()) {
165
+        if (!$this->fields()) {
166 166
             return false;
167 167
         }
168 168
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      */
178 178
     public function removeField($name)
179 179
     {
180
-        $this->transformFields(function ($fields) use ($name) {
180
+        $this->transformFields(function($fields) use ($name) {
181 181
             Arr::forget($fields, $name);
182 182
 
183 183
             return $fields;
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      */
192 192
     public function removeFields($array_of_names)
193 193
     {
194
-        if (! empty($array_of_names)) {
194
+        if (!empty($array_of_names)) {
195 195
             foreach ($array_of_names as $name) {
196 196
                 $this->removeField($name);
197 197
             }
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     public function removeAllFields()
205 205
     {
206 206
         $current_fields = $this->getCleanStateFields();
207
-        if (! empty($current_fields)) {
207
+        if (!empty($current_fields)) {
208 208
             foreach ($current_fields as $field) {
209 209
                 $this->removeField($field['name']);
210 210
             }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
                 $jsonCastables = ['array', 'object', 'json'];
300 300
                 $fieldCasting = $casted_attributes[$field['name']];
301 301
 
302
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
302
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
303 303
                     try {
304 304
                         $input[$field['name']] = json_decode($input[$field['name']]);
305 305
                     } catch (\Exception $e) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      */
329 329
     public function orderFields($order)
330 330
     {
331
-        $this->transformFields(function ($fields) use ($order) {
331
+        $this->transformFields(function($fields) use ($order) {
332 332
             return $this->applyOrderToFields($fields, $order);
333 333
         });
334 334
     }
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     public function hasUploadFields()
355 355
     {
356 356
         $fields = $this->getCleanStateFields();
357
-        $upload_fields = Arr::where($fields, function ($value, $key) {
357
+        $upload_fields = Arr::where($fields, function($value, $key) {
358 358
             // check if any subfields have uploads
359 359
             if (isset($value['subfields'])) {
360 360
                 foreach ($value['subfields'] as $subfield) {
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
         $alreadyLoaded = $this->getLoadedFieldTypes();
427 427
         $type = $this->getFieldTypeWithNamespace($field);
428 428
 
429
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
429
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
430 430
             $alreadyLoaded[] = $type;
431 431
             $this->setLoadedFieldTypes($alreadyLoaded);
432 432
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
      */
468 468
     public function fieldTypeNotLoaded($field)
469 469
     {
470
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
470
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
471 471
     }
472 472
 
473 473
     /**
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
      */
517 517
     public function hasFieldWhere($attribute, $value)
518 518
     {
519
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
519
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
520 520
             return isset($field[$attribute]) && $field[$attribute] == $value;
521 521
         });
522 522
 
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
      */
533 533
     public function firstFieldWhere($attribute, $value)
534 534
     {
535
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
535
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
536 536
             return isset($field[$attribute]) && $field[$attribute] == $value;
537 537
         });
538 538
     }
Please login to merge, or discard this patch.
src/BackpackServiceProvider.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -66,24 +66,24 @@  discard block
 block discarded – undo
66 66
         include_once __DIR__.'/macros.php';
67 67
 
68 68
         // Bind the CrudPanel object to Laravel's service container
69
-        $this->app->scoped('crud', function ($app) {
69
+        $this->app->scoped('crud', function($app) {
70 70
             return new CrudPanel();
71 71
         });
72 72
 
73
-        $this->app->scoped('DatabaseSchema', function ($app) {
73
+        $this->app->scoped('DatabaseSchema', function($app) {
74 74
             return new DatabaseSchema();
75 75
         });
76 76
 
77
-        $this->app->singleton('BackpackViewNamespaces', function ($app) {
77
+        $this->app->singleton('BackpackViewNamespaces', function($app) {
78 78
             return new ViewNamespaces();
79 79
         });
80 80
 
81 81
         // Bind the widgets collection object to Laravel's service container
82
-        $this->app->singleton('widgets', function ($app) {
82
+        $this->app->singleton('widgets', function($app) {
83 83
             return new Collection();
84 84
         });
85 85
 
86
-        $this->app->scoped('UploadersRepository', function ($app) {
86
+        $this->app->scoped('UploadersRepository', function($app) {
87 87
             return new UploadersRepository();
88 88
         });
89 89
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $middleware_key = config('backpack.base.middleware_key');
100 100
         $middleware_class = config('backpack.base.middleware_class');
101 101
 
102
-        if (! is_array($middleware_class)) {
102
+        if (!is_array($middleware_class)) {
103 103
             $router->pushMiddlewareToGroup($middleware_key, $middleware_class);
104 104
 
105 105
             return;
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         $operationConfigs = scandir(__DIR__.'/config/backpack/operations/');
216 216
         $operationConfigs = array_diff($operationConfigs, ['.', '..']);
217 217
 
218
-        if (! count($operationConfigs)) {
218
+        if (!count($operationConfigs)) {
219 219
             return;
220 220
         }
221 221
 
Please login to merge, or discard this patch.
src/macros.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null) {
39 39
         /** @var CrudField|CrudColumn $this */
40 40
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield);
41 41
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
     });
44 44
 }
45 45
 
46
-if (! CrudField::hasMacro('withFiles')) {
47
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null) {
46
+if (!CrudField::hasMacro('withFiles')) {
47
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null) {
48 48
         /** @var CrudField|CrudColumn $this */
49 49
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield);
50 50
 
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
  *
59 59
  * It will go to the given CrudController and get the setupRoutes() method on it.
60 60
  */
61
-if (! Route::hasMacro('crud')) {
62
-    Route::macro('crud', function ($name, $controller) {
61
+if (!Route::hasMacro('crud')) {
62
+    Route::macro('crud', function($name, $controller) {
63 63
         // put together the route name prefix,
64 64
         // as passed to the Route::group() statements
65 65
         $routeName = '';
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Uploads/Uploaders/SingleBase64Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $entry->getOriginal($this->getName());
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Uploads/Uploaders/SingleFile.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
         }
27 27
 
28 28
         foreach ($previousFiles as $row => $file) {
29
-            if ($file && ! isset($orderedFiles[$row])) {
29
+            if ($file && !isset($orderedFiles[$row])) {
30 30
                 $orderedFiles[$row] = null;
31 31
                 Storage::disk($this->getDisk())->delete($file);
32 32
             }
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
             return $this->getPath().$fileName;
53 53
         }
54 54
 
55
-        if (! $value && CrudPanelFacade::getRequest()->has($this->getName()) && $previousFile) {
55
+        if (!$value && CrudPanelFacade::getRequest()->has($this->getName()) && $previousFile) {
56 56
             Storage::disk($this->getDisk())->delete($previousFile);
57 57
 
58 58
             return null;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Uploads/UploadersRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      */
40 40
     public function markAsHandled(string $objectName)
41 41
     {
42
-        if (! in_array($objectName, $this->handledUploaders)) {
42
+        if (!in_array($objectName, $this->handledUploaders)) {
43 43
             $this->handledUploaders[] = $objectName;
44 44
         }
45 45
     }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
      */
112 112
     public function registerUploader(string $uploadName, UploaderInterface $uploader)
113 113
     {
114
-        if (! array_key_exists($uploadName, $this->registeredUploaders) || ! in_array($uploader, $this->registeredUploaders[$uploadName])) {
114
+        if (!array_key_exists($uploadName, $this->registeredUploaders) || !in_array($uploader, $this->registeredUploaders[$uploadName])) {
115 115
             $this->registeredUploaders[$uploadName][] = $uploader;
116 116
         }
117 117
     }
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
      */
159 159
     public function getRegisteredUploadNames(string $uploadName)
160 160
     {
161
-        return array_map(function ($uploader) {
161
+        return array_map(function($uploader) {
162 162
             return $uploader->getName();
163 163
         }, $this->getRegisteredUploadersFor($uploadName));
164 164
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Uploads/RegisterUploadEvents.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -13,13 +13,13 @@  discard block
 block discarded – undo
13 13
     private string $crudObjectType;
14 14
 
15 15
     public function __construct(
16
-        private readonly CrudField|CrudColumn $crudObject,
16
+        private readonly CrudField | CrudColumn $crudObject,
17 17
         private readonly array $uploaderConfiguration,
18 18
         private readonly string $macro
19 19
         ) {
20 20
         $this->crudObjectType = is_a($crudObject, CrudField::class) ? 'field' : (is_a($crudObject, CrudColumn::class) ? 'column' : null);
21 21
 
22
-        if (! $this->crudObjectType) {
22
+        if (!$this->crudObjectType) {
23 23
             abort(500, 'Upload handlers only work for CrudField and CrudColumn classes.');
24 24
         }
25 25
     }
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         if ($this->crudObjectType === 'field') {
59
-            $model::saving(function ($entry) use ($uploader) {
59
+            $model::saving(function($entry) use ($uploader) {
60 60
                 $updatedCountKey = 'uploaded_'.($uploader->getRepeatableContainerName() ?? $uploader->getName()).'_count';
61 61
 
62 62
                 CRUD::set($updatedCountKey, CRUD::get($updatedCountKey) ?? 0);
@@ -69,11 +69,11 @@  discard block
 block discarded – undo
69 69
             });
70 70
         }
71 71
 
72
-        $model::retrieved(function ($entry) use ($uploader) {
72
+        $model::retrieved(function($entry) use ($uploader) {
73 73
             $entry = $uploader->retrieveUploadedFile($entry);
74 74
         });
75 75
 
76
-        $model::deleting(function ($entry) use ($uploader) {
76
+        $model::deleting(function($entry) use ($uploader) {
77 77
             $uploader->deleteUploadedFile($entry);
78 78
         });
79 79
 
@@ -86,9 +86,9 @@  discard block
 block discarded – undo
86 86
      * @param  array|null  $subfield
87 87
      * @return void
88 88
      */
89
-    public function registerEvents(array|null $subfield = [])
89
+    public function registerEvents(array | null $subfield = [])
90 90
     {
91
-        if (! empty($subfield)) {
91
+        if (!empty($subfield)) {
92 92
             $this->registerSubfieldEvent($subfield);
93 93
 
94 94
             return;
@@ -135,12 +135,12 @@  discard block
 block discarded – undo
135 135
 
136 136
         // for subfields, we only register one event so that we have access to the repeatable container name.
137 137
         // all the uploaders for a given container are stored in the UploadersRepository.
138
-        if (! app('UploadersRepository')->hasUploadersRegisteredFor($uploader->getRepeatableContainerName())) {
138
+        if (!app('UploadersRepository')->hasUploadersRegisteredFor($uploader->getRepeatableContainerName())) {
139 139
             $this->setupModelEvents($model, $uploader);
140 140
         }
141 141
 
142 142
         $subfields = collect($this->crudObject->getAttributes()['subfields']);
143
-        $subfields = $subfields->map(function ($item) use ($subfield, $uploader) {
143
+        $subfields = $subfields->map(function($item) use ($subfield, $uploader) {
144 144
             if ($item['name'] === $subfield['name']) {
145 145
                 $item['upload'] = true;
146 146
                 $item['disk'] = $uploader->getDisk();
@@ -176,11 +176,11 @@  discard block
 block discarded – undo
176 176
     private function getUploader(array $crudObject, array $uploaderConfiguration)
177 177
     {
178 178
         if (isset($uploaderConfiguration['uploaderType'])) {
179
-            return $uploaderConfiguration['uploaderType']::for($crudObject, $uploaderConfiguration);
179
+            return $uploaderConfiguration['uploaderType']::for ($crudObject, $uploaderConfiguration);
180 180
         }
181 181
 
182 182
         if (app('UploadersRepository')->hasUploadFor($crudObject['type'], $this->macro)) {
183
-            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for($crudObject, $uploaderConfiguration);
183
+            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for ($crudObject, $uploaderConfiguration);
184 184
         }
185 185
 
186 186
         throw new Exception('Undefined upload type for '.$this->crudObjectType.' type: '.$crudObject['type']);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Uploads/Traits/HandleFileNaming.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,11 +31,11 @@
 block discarded – undo
31 31
     {
32 32
         $fileGeneratorClass = $fileNameGenerator ?? config('backpack.crud.file_name_generator');
33 33
 
34
-        if (! class_exists($fileGeneratorClass)) {
34
+        if (!class_exists($fileGeneratorClass)) {
35 35
             throw new \Exception("The file name generator class [{$fileGeneratorClass}] does not exist.");
36 36
         }
37 37
 
38
-        if (! class_implements($fileGeneratorClass, FileNameGeneratorInterface::class)) {
38
+        if (!class_implements($fileGeneratorClass, FileNameGeneratorInterface::class)) {
39 39
             throw new \Exception("The file name generator class [{$fileGeneratorClass}] must implement the [".FileNameGeneratorInterface::class.'] interface.');
40 40
         }
41 41
 
Please login to merge, or discard this patch.