Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1360)
by Ihsan
10:18 queued 02:50
created
src/ModelTraits/SpatieTranslatable/SluggableObserver.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6 5
 use Illuminate\Contracts\Events\Dispatcher;
6
+use Illuminate\Database\Eloquent\Model;
7 7
 
8 8
 class SluggableObserver extends \Cviebrock\EloquentSluggable\SluggableObserver
9 9
 {
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/Sluggable.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Cviebrock\EloquentSluggable\Sluggable as OriginalSluggable;
6
+use Illuminate\Database\Eloquent\Builder;
7
+use Illuminate\Database\Eloquent\Model;
8 8
 
9 9
 trait Sluggable
10 10
 {
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Unused Use Statements   +5 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,19 +3,17 @@
 block discarded – undo
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5 5
 use Backpack\CRUD\CrudPanel;
6
-use Illuminate\Http\Request;
7
-use Illuminate\Support\Facades\Form as Form;
6
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
7
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
8 8
 use Illuminate\Foundation\Bus\DispatchesJobs;
9
-use Illuminate\Routing\Controller as BaseController;
10 9
 use Illuminate\Foundation\Validation\ValidatesRequests;
11
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
12
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
10
+use Illuminate\Http\Request;
11
+use Illuminate\Routing\Controller as BaseController;
13 12
 // CRUD Traits for non-core features
14 13
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
15 14
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
16
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
17
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
18 15
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
16
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
19 17
 
20 18
 class CrudController extends BaseController
21 19
 {
Please login to merge, or discard this patch.
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -124,8 +124,9 @@  discard block
 block discarded – undo
124 124
         $this->data['entry'] = $this->crud->entry = $item;
125 125
 
126 126
         // show a success message
127
-        if($this->crud->model::find($item->id))
128
-         \Alert::success(trans('backpack::crud.insert_success'))->flash();
127
+        if($this->crud->model::find($item->id)) {
128
+                 \Alert::success(trans('backpack::crud.insert_success'))->flash();
129
+        }
129 130
 
130 131
         // save the redirect choice for next time
131 132
         $this->setSaveAction();
@@ -156,8 +157,8 @@  discard block
 block discarded – undo
156 157
 
157 158
         $this->data['id'] = $id;
158 159
 
159
-        if($this->crud->eagerLoad && !empty($this->crud->eagerLoad))
160
-        foreach($this->crud->eagerLoad as $relation_name)
160
+        if($this->crud->eagerLoad && !empty($this->crud->eagerLoad)) {
161
+                foreach($this->crud->eagerLoad as $relation_name)
161 162
         {
162 163
          if($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
163 164
          {
@@ -166,6 +167,7 @@  discard block
 block discarded – undo
166 167
            if(starts_with($field_name, $relation_name))
167 168
            {
168 169
             $column_name = str_replace("{$relation_name}.", '', $field_name);
170
+        }
169 171
 
170 172
             $this->data['fields'][$field_name]['value'] = $rel->{$column_name};
171 173
            }
@@ -284,10 +286,11 @@  discard block
 block discarded – undo
284 286
       })
285 287
       ->toArray();
286 288
 
287
-      if(!$rel = $item->{$relation_name})
288
-       $item->{$relation_name}()->create($data);
289
-      else
290
-       $item->{$relation_name}->update($data);
289
+      if(!$rel = $item->{$relation_name}) {
290
+             $item->{$relation_name}()->create($data);
291
+      } else {
292
+             $item->{$relation_name}->update($data);
293
+      }
291 294
      });
292 295
     }
293 296
 }
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD;
4 4
 
5
-use Route;
6 5
 use Illuminate\Support\ServiceProvider;
7 6
 
8 7
 class CrudServiceProvider extends ServiceProvider
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
4 4
 
5
-use Faker\Factory;
6
-use Backpack\CRUD\Tests\Unit\Models\User;
7 5
 use Backpack\CRUD\Tests\Unit\Models\Article;
6
+use Backpack\CRUD\Tests\Unit\Models\User;
7
+use Faker\Factory;
8 8
 
9 9
 class CrudPanelCreateTest extends BaseDBCrudPanelTest
10 10
 {
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelDeleteTest.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
4 4
 
5
-use Illuminate\Support\Facades\DB;
6 5
 use Backpack\CRUD\Tests\Unit\Models\Article;
7 6
 use Illuminate\Database\Eloquent\ModelNotFoundException;
7
+use Illuminate\Support\Facades\DB;
8 8
 
9 9
 class CrudPanelDeleteTest extends BaseDBCrudPanelTest
10 10
 {
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelReadTest.php 1 patch
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,11 +2,11 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
4 4
 
5
-use Illuminate\Support\Collection;
6
-use Illuminate\Support\Facades\DB;
7
-use Backpack\CRUD\Tests\Unit\Models\User;
8 5
 use Backpack\CRUD\Tests\Unit\Models\Article;
6
+use Backpack\CRUD\Tests\Unit\Models\User;
9 7
 use Illuminate\Database\Eloquent\ModelNotFoundException;
8
+use Illuminate\Support\Collection;
9
+use Illuminate\Support\Facades\DB;
10 10
 
11 11
 class CrudPanelReadTest extends BaseDBCrudPanelTest
12 12
 {
Please login to merge, or discard this patch.
src/CrudTrait.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 namespace Backpack\CRUD;
4 4
 
5 5
 use DB;
6
-use Traversable;
7
-use Illuminate\Support\Facades\Config;
8 6
 use Illuminate\Database\Eloquent\Model;
7
+use Illuminate\Support\Facades\Config;
8
+use Traversable;
9 9
 
10 10
 trait CrudTrait
11 11
 {
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Console\Commands;
4 4
 
5
-use Illuminate\Console\Command;
6
-use Symfony\Component\Process\Process;
7 5
 use Backpack\Base\app\Console\Commands\Install as BaseInstall;
8 6
 
9 7
 class Install extends BaseInstall
Please login to merge, or discard this patch.