Laravel-Backpack / CRUD

src/app/Http/Controllers/CrudController.php

Unused Use Statements +5 added lines, -7 removed lines

@@ -3,19 +3,17 @@
 namespace Backpack\CRUD\app\Http\Controllers;
 
 use Backpack\CRUD\CrudPanel;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Form as Form;
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
 use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Routing\Controller as BaseController;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
+use Illuminate\Http\Request;
+use Illuminate\Routing\Controller as BaseController;
 // CRUD Traits for non-core features
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 
 class CrudController extends BaseController
 {

Indentation +28 added lines, -28 removed lines

@@ -125,7 +125,7 @@ 
 
         // show a success message
         if($this->crud->model::find($item->id))
-         \Alert::success(trans('backpack::crud.insert_success'))->flash();
+            \Alert::success(trans('backpack::crud.insert_success'))->flash();
 
         // save the redirect choice for next time
         $this->setSaveAction();
@@ -159,18 +159,18 @@ 
         if($this->crud->eagerLoad && !empty($this->crud->eagerLoad))
         foreach($this->crud->eagerLoad as $relation_name)
         {
-         if($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
-         {
-          foreach($this->data['fields'] as $field_name => $field)
-          {
-           if(starts_with($field_name, $relation_name))
-           {
+            if($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
+            {
+            foreach($this->data['fields'] as $field_name => $field)
+            {
+            if(starts_with($field_name, $relation_name))
+            {
             $column_name = str_replace("{$relation_name}.", '', $field_name);
 
             $this->data['fields'][$field_name]['value'] = $rel->{$column_name};
-           }
-          }
-         }
+            }
+            }
+            }
         }
 
         // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
@@ -271,23 +271,23 @@ 
 
     public function handleEagerLoad($item)
     {
-     collect($this->crud->eagerLoad)->each(function($relation_name, $key) use ($item)
-     {
-      $data = collect(request()->all())
-      ->filter(function($value, $key) use ($relation_name)
-      {
-       return starts_with($key, $relation_name);
-      })
-      ->mapWithKeys(function($value, $key) use ($relation_name)
-      {
-       return [str_replace("{$relation_name}_", '', $key) => $value ?? ''];
-      })
-      ->toArray();
-
-      if(!$rel = $item->{$relation_name})
-       $item->{$relation_name}()->create($data);
-      else
-       $item->{$relation_name}->update($data);
-     });
+        collect($this->crud->eagerLoad)->each(function($relation_name, $key) use ($item)
+        {
+        $data = collect(request()->all())
+        ->filter(function($value, $key) use ($relation_name)
+        {
+        return starts_with($key, $relation_name);
+        })
+        ->mapWithKeys(function($value, $key) use ($relation_name)
+        {
+        return [str_replace("{$relation_name}_", '', $key) => $value ?? ''];
+        })
+        ->toArray();
+
+        if(!$rel = $item->{$relation_name})
+        $item->{$relation_name}()->create($data);
+        else
+        $item->{$relation_name}->update($data);
+        });
     }
 }

Spacing +11 added lines, -11 removed lines

@@ -33,13 +33,13 @@ 
 
     public function __construct()
     {
-        if (! $this->crud) {
+        if (!$this->crud) {
             $this->crud = app()->make(CrudPanel::class);
-            $this->crud->ajax_table=false;
+            $this->crud->ajax_table = false;
 
             // call the setup function inside this closure to also have the request there
             // this way, developers can use things stored in session (auth variables, etc)
-            $this->middleware(function ($request, $next) {
+            $this->middleware(function($request, $next) {
                 $this->request = $request;
                 $this->crud->request = $request;
                 $this->setup();
@@ -69,7 +69,7 @@ 
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
 
         // get all entries if AJAX is not enabled
-        if (! $this->data['crud']->ajaxTable()) {
+        if (!$this->data['crud']->ajaxTable()) {
             $this->data['entries'] = $this->data['crud']->getEntries();
         }
 
@@ -124,7 +124,7 @@ 
         $this->data['entry'] = $this->crud->entry = $item;
 
         // show a success message
-        if($this->crud->model::find($item->id))
+        if ($this->crud->model::find($item->id))
          \Alert::success(trans('backpack::crud.insert_success'))->flash();
 
         // save the redirect choice for next time
@@ -156,14 +156,14 @@ 
 
         $this->data['id'] = $id;
 
-        if($this->crud->eagerLoad && !empty($this->crud->eagerLoad))
-        foreach($this->crud->eagerLoad as $relation_name)
+        if ($this->crud->eagerLoad && !empty($this->crud->eagerLoad))
+        foreach ($this->crud->eagerLoad as $relation_name)
         {
-         if($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
+         if ($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
          {
-          foreach($this->data['fields'] as $field_name => $field)
+          foreach ($this->data['fields'] as $field_name => $field)
           {
-           if(starts_with($field_name, $relation_name))
+           if (starts_with($field_name, $relation_name))
            {
             $column_name = str_replace("{$relation_name}.", '', $field_name);
 
@@ -284,7 +284,7 @@ 
       })
       ->toArray();
 
-      if(!$rel = $item->{$relation_name})
+      if (!$rel = $item->{$relation_name})
        $item->{$relation_name}()->create($data);
       else
        $item->{$relation_name}->update($data);

Braces +11 added lines, -8 removed lines

@@ -124,8 +124,9 @@ 
         $this->data['entry'] = $this->crud->entry = $item;
 
         // show a success message
-        if($this->crud->model::find($item->id))
-         \Alert::success(trans('backpack::crud.insert_success'))->flash();
+        if($this->crud->model::find($item->id)) {
+                 \Alert::success(trans('backpack::crud.insert_success'))->flash();
+        }
 
         // save the redirect choice for next time
         $this->setSaveAction();
@@ -156,8 +157,8 @@ 
 
         $this->data['id'] = $id;
 
-        if($this->crud->eagerLoad && !empty($this->crud->eagerLoad))
-        foreach($this->crud->eagerLoad as $relation_name)
+        if($this->crud->eagerLoad && !empty($this->crud->eagerLoad)) {
+                foreach($this->crud->eagerLoad as $relation_name)
         {
          if($this->data['entry'] && $rel = $this->data['entry']->{$relation_name})
          {
@@ -166,6 +167,7 @@ 
            if(starts_with($field_name, $relation_name))
            {
             $column_name = str_replace("{$relation_name}.", '', $field_name);
+        }
 
             $this->data['fields'][$field_name]['value'] = $rel->{$column_name};
            }
@@ -284,10 +286,11 @@ 
       })
       ->toArray();
 
-      if(!$rel = $item->{$relation_name})
-       $item->{$relation_name}()->create($data);
-      else
-       $item->{$relation_name}->update($data);
+      if(!$rel = $item->{$relation_name}) {
+             $item->{$relation_name}()->create($data);
+      } else {
+             $item->{$relation_name}->update($data);
+      }
      });
     }
 }

src/CrudPanel.php

Unused Use Statements +12 added lines, -12 removed lines

@@ -2,27 +2,27 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
+use Backedin\BackpackTraits\Backpack\Buttons;
 use Backedin\BackpackTraits\Backpack\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backedin\BackpackTraits\Backpack\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
+use Backpack\CRUD\PanelTraits\Read;
 use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
-use Backpack\CRUD\PanelTraits\FakeFields;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

Indentation +15 added lines, -15 removed lines

@@ -268,26 +268,26 @@
      */
     public function getRelationModel($relationString, $length = null, $model = null)
     {
-     if(!$model = $this->model->find($this->getLastParameter()))
-     {
-      $model = $this->model;
-     }
+        if(!$model = $this->model->find($this->getLastParameter()))
+        {
+        $model = $this->model;
+        }
      
-     $relationArray = explode('.', $relationString);
+        $relationArray = explode('.', $relationString);
 
-     if (! isset($length)) {
-         $length = count($relationArray);
-     }
+        if (! isset($length)) {
+            $length = count($relationArray);
+        }
 
-     if (! isset($model)) {
-         $model = $this->model;
-     }
+        if (! isset($model)) {
+            $model = $this->model;
+        }
 
-     $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
-         return $obj->$method()->getRelated();
-     }, $model);
+        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+            return $obj->$method()->getRelated();
+        }, $model);
 
-     return get_class($result);
+        return get_class($result);
     }
 
     /**

Spacing +13 added lines, -13 removed lines

@@ -90,7 +90,7 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('This model does not exist.', 404);
         }
 
@@ -140,7 +140,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -190,7 +190,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -207,8 +207,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -240,8 +240,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -268,22 +268,22 @@ 
      */
     public function getRelationModel($relationString, $length = null, $model = null)
     {
-     if(!$model = $this->model->find($this->getLastParameter()))
+     if (!$model = $this->model->find($this->getLastParameter()))
      {
       $model = $this->model;
      }
      
      $relationArray = explode('.', $relationString);
 
-     if (! isset($length)) {
+     if (!isset($length)) {
          $length = count($relationArray);
      }
 
-     if (! isset($model)) {
+     if (!isset($model)) {
          $model = $this->model;
      }
 
-     $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+     $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
          return $obj->$method()->getRelated();
      }, $model);
 
@@ -330,7 +330,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -339,7 +339,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }