Laravel-Backpack / CRUD

src/PanelTraits/Tabs.php

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
 
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled;
+        return !$this->tabsEnabled;
     }
 
     public function setTabsType($type)
@@ -91,8 +91,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -103,7 +103,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -119,11 +119,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         return $this->tabsEnabled;
     }
 
+    /**
+     * @return boolean
+     */
     public function tabsEnabled()
     {
         return $this->tabsEnabled;

src/resources/lang/pt/crud.php

Indentation +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     'delete_confirmation_not_deleted_title'       => 'Não apagado',
     'delete_confirmation_not_deleted_message'     => 'Está tudo bem!. O item não foi apagado.',
 
-     // DataTables translation
+        // DataTables translation
     'emptyTable'     => 'Sem dados disponíveis na tabela',
     'info'           => 'A mostrar _START_ a _END_ de _TOTAL_ registos',
     'infoEmpty'      => 'A mostrar 0 a 0 de 0 registos',

src/PanelTraits/FakeColumns.php

Spacing +3 added lines, -3 removed lines

@@ -24,19 +24,19 @@
             if (isset($field['fake']) && $field['fake'] == true) {
                 // add it to the request in its appropriate variable - the one defined, if defined
                 if (isset($field['store_in'])) {
-                    if (! in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
+                    if (!in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, $field['store_in']);
                     }
                 } else {
                     //otherwise in the one defined in the $crud variable
-                    if (! in_array('extras', $fakeFieldsColumnsArray, true)) {
+                    if (!in_array('extras', $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, 'extras');
                     }
                 }
             }
         }
 
-        if (! count($fakeFieldsColumnsArray)) {
+        if (!count($fakeFieldsColumnsArray)) {
             $fakeFieldsColumnsArray = ['extras'];
         }
 

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
      * been found.
      *
      * @param string $form The CRUD form. Can be 'create', 'update' or 'both'. Default is 'create'.
-     * @param int|bool $id Optional entity ID needed in the case of the update form.
+     * @param integer $id Optional entity ID needed in the case of the update form.
      * @return array The fake columns array.
      */
     public function getFakeColumnsAsArray($form = 'create', $id = false)

src/PanelTraits/Access.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function hasAccess($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             return false;
         }
 
@@ -68,7 +68,7 @@ 
     public function hasAccessToAll($permission_array)
     {
         foreach ($permission_array as $key => $permission) {
-            if (! in_array($permission, $this->access)) {
+            if (!in_array($permission, $this->access)) {
                 return false;
             }
         }
@@ -86,7 +86,7 @@ 
      */
     public function hasAccessOrFail($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access'));
         }
 

Doc Comments +6 added lines

@@ -12,12 +12,18 @@
     |--------------------------------------------------------------------------
     */
 
+    /**
+     * @param string $access
+     */
     public function allowAccess($access)
     {
         // $this->addButtons((array)$access);
         return $this->access = array_merge(array_diff((array) $access, $this->access), $this->access);
     }
 
+    /**
+     * @param string $access
+     */
     public function denyAccess($access)
     {
         // $this->removeButtons((array)$access);

src/PanelTraits/Delete.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      *
      * @param  int $id The id of the item to be deleted.
      *
-     * @return bool True if the item was deleted.
+     * @return string True if the item was deleted.
      *
      * @throws \Illuminate\Database\Eloquent\ModelNotFoundException if the model was not found.
      *

src/CrudPanel.php

Doc Comments +1 added lines

@@ -123,6 +123,7 @@
      *
      * @param [string] Route name.
      * @param [array] Parameters.
+     * @param string $route
      */
     public function setRouteName($route, $parameters = [])
     {

Unused Use Statements +12 added lines, -12 removed lines

@@ -2,27 +2,27 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
+use Backedin\BackpackTraits\Backpack\Buttons;
 use Backedin\BackpackTraits\Backpack\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backedin\BackpackTraits\Backpack\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
+use Backpack\CRUD\PanelTraits\Read;
 use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
-use Backpack\CRUD\PanelTraits\FakeFields;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

Indentation +15 added lines, -15 removed lines

@@ -268,26 +268,26 @@
      */
     public function getRelationModel($relationString, $length = null, $model = null)
     {
-     if(!$model = $this->model->find($this->getLastParameter()))
-     {
-      $model = $this->model;
-     }
+        if(!$model = $this->model->find($this->getLastParameter()))
+        {
+        $model = $this->model;
+        }
      
-     $relationArray = explode('.', $relationString);
+        $relationArray = explode('.', $relationString);
 
-     if (! isset($length)) {
-         $length = count($relationArray);
-     }
+        if (! isset($length)) {
+            $length = count($relationArray);
+        }
 
-     if (! isset($model)) {
-         $model = $this->model;
-     }
+        if (! isset($model)) {
+            $model = $this->model;
+        }
 
-     $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
-         return $obj->$method()->getRelated();
-     }, $model);
+        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+            return $obj->$method()->getRelated();
+        }, $model);
 
-     return get_class($result);
+        return get_class($result);
     }
 
     /**

Spacing +13 added lines, -13 removed lines

@@ -90,7 +90,7 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('This model does not exist.', 404);
         }
 
@@ -140,7 +140,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -190,7 +190,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -207,8 +207,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -240,8 +240,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -268,22 +268,22 @@ 
      */
     public function getRelationModel($relationString, $length = null, $model = null)
     {
-     if(!$model = $this->model->find($this->getLastParameter()))
+     if (!$model = $this->model->find($this->getLastParameter()))
      {
       $model = $this->model;
      }
      
      $relationArray = explode('.', $relationString);
 
-     if (! isset($length)) {
+     if (!isset($length)) {
          $length = count($relationArray);
      }
 
-     if (! isset($model)) {
+     if (!isset($model)) {
          $model = $this->model;
      }
 
-     $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+     $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
          return $obj->$method()->getRelated();
      }, $model);
 
@@ -330,7 +330,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -339,7 +339,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,9 +2,9 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Faker\Factory;
-use Backpack\CRUD\Tests\Unit\Models\User;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Backpack\CRUD\Tests\Unit\Models\User;
+use Faker\Factory;
 
 class CrudPanelCreateTest extends BaseDBCrudPanelTest
 {

tests/Unit/CrudPanel/CrudPanelDeleteTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,9 +2,9 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelDeleteTest extends BaseDBCrudPanelTest
 {

tests/Unit/CrudPanel/CrudPanelReadTest.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -2,11 +2,11 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Collection;
-use Illuminate\Support\Facades\DB;
-use Backpack\CRUD\Tests\Unit\Models\User;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Backpack\CRUD\Tests\Unit\Models\User;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Support\Collection;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelReadTest extends BaseDBCrudPanelTest
 {