Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5478)
by Cristian
30:16 queued 15:12
created
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                     // - a single dimensional array: [1,2,3]
123 123
                     // - an array of arrays: [[1][2][3]]
124 124
                     // if is as single dimensional array we can only attach.
125
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
125
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
126 126
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
127 127
                     } else {
128 128
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
         }
294 294
         // if column is not nullable in database, and there is no column default (null),
295 295
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
296
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
296
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
297 297
             return $removedEntries->lazy()->each->delete();
298 298
         }
299 299
 
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         }
339 339
 
340 340
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
341
-        if (! empty($relatedItemsSent)) {
341
+        if (!empty($relatedItemsSent)) {
342 342
             // we perform the cleanup of removed database items
343 343
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
344 344
         }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $connection = DB::connection($this->getConnectionName());
24 24
 
25
-        if (! method_exists($connection, 'getDoctrineSchemaManager')) {
25
+        if (!method_exists($connection, 'getDoctrineSchemaManager')) {
26 26
             return $connection;
27 27
         }
28 28
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         if (self::isSqlConnection()) {
36 36
             $platform = $connection->getDoctrineSchemaManager()->getDatabasePlatform();
37 37
             foreach ($types as $type_key => $type_value) {
38
-                if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
38
+                if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
39 39
                     $platform->registerDoctrineTypeMapping($type_key, $type_value);
40 40
                 }
41 41
             }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getColumnType($columnName)
67 67
     {
68
-        if (! self::isSqlConnection()) {
68
+        if (!self::isSqlConnection()) {
69 69
             return 'text';
70 70
         }
71 71
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public static function isColumnNullable($columnName)
82 82
     {
83
-        if (! self::isSqlConnection()) {
83
+        if (!self::isSqlConnection()) {
84 84
             return true;
85 85
         }
86 86
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public static function dbColumnHasDefault($columnName)
97 97
     {
98
-        if (! self::isSqlConnection()) {
98
+        if (!self::isSqlConnection()) {
99 99
             return false;
100 100
         }
101 101
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public static function getDbColumnDefault($columnName)
112 112
     {
113
-        if (! self::isSqlConnection()) {
113
+        if (!self::isSqlConnection()) {
114 114
             return false;
115 115
         }
116 116
 
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // if that widget name already exists in the widgets collection
38 38
         // then pick up all widget attributes from that entry
39 39
         // and overwrite them with the ones passed in $attributes
40
-        if ($existingItem = self::collection()->filter(function ($item) use ($attributes) {
40
+        if ($existingItem = self::collection()->filter(function($item) use ($attributes) {
41 41
             return $item->attributes['name'] === $attributes['name'];
42 42
         })->first()) {
43 43
             $attributes = array_merge($existingItem->attributes, $attributes);
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
             }
160 160
         }
161 161
         $type = $this->attributes['type'];
162
-        $paths = array_map(function ($item) use ($type) {
162
+        $paths = array_map(function($item) use ($type) {
163 163
             return $item.'.'.$type;
164 164
         }, ViewNamespaces::getWithFallbackFor('widgets', 'backpack.ui.component_view_namespaces.widgets'));
165 165
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             }
170 170
         }
171 171
         // if no view exists, in any of the directories above... no bueno
172
-        if (! backpack_pro()) {
172
+        if (!backpack_pro()) {
173 173
             throw new BackpackProRequiredException('Cannot find the widget view: '.$this->attributes['type'].'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO widget, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
174 174
         }
175 175
         abort(500, 'Cannot find the view for «'.$this->attributes['type'].'» widget type. Please check for typos.');
@@ -253,10 +253,10 @@  discard block
 block discarded – undo
253 253
      */
254 254
     private function save()
255 255
     {
256
-        $itemExists = $this->collection()->filter(function ($item) {
256
+        $itemExists = $this->collection()->filter(function($item) {
257 257
             return $item->attributes['name'] === $this->attributes['name'];
258 258
         })->isNotEmpty();
259
-        if (! $itemExists) {
259
+        if (!$itemExists) {
260 260
             $this->collection()->put($this->attributes['name'], $this);
261 261
         } else {
262 262
             $this->collection()[$this->attributes['name']] = $this;
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     private bool $deleteWhenEntryIsDeleted = true;
27 27
 
28
-    private bool|string $attachedToFakeField = false;
28
+    private bool | string $attachedToFakeField = false;
29 29
 
30 30
     /**
31 31
      * Cloud disks have the ability to generate temporary URLs to files, should we do it?
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /*******************************
63 63
      * Static methods
64 64
      *******************************/
65
-    public static function for(array $crudObject, array $definition): UploaderInterface
65
+    public static function for (array $crudObject, array $definition): UploaderInterface
66 66
     {
67 67
         return new static($crudObject, $definition);
68 68
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function deleteUploadedFiles(Model $entry): void
104 104
     {
105 105
         if ($this->deleteWhenEntryIsDeleted) {
106
-            if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
106
+            if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
107 107
                 $this->performFileDeletion($entry);
108 108
 
109 109
                 return;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function getPreviousFiles(Model $entry): mixed
181 181
     {
182
-        if (! $this->attachedToFakeField) {
182
+        if (!$this->attachedToFakeField) {
183 183
             return $this->getOriginalValue($entry);
184 184
         }
185 185
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         $value = $entry->{$this->getAttributeName()};
219 219
 
220 220
         if ($this->handleMultipleFiles) {
221
-            if (! isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
221
+            if (!isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
222 222
                 $entry->{$this->getAttributeName()} = json_decode($value, true);
223 223
             }
224 224
 
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 
251 251
         if ($this->handleMultipleFiles) {
252 252
             // ensure we have an array of values when field is not casted in model.
253
-            if (! isset($entry->getCasts()[$this->name]) && is_string($values)) {
253
+            if (!isset($entry->getCasts()[$this->name]) && is_string($values)) {
254 254
                 $values = json_decode($values, true);
255 255
             }
256 256
             foreach ($values ?? [] as $value) {
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 
268 268
     private function performFileDeletion(Model $entry)
269 269
     {
270
-        if (! $this->handleRepeatableFiles) {
270
+        if (!$this->handleRepeatableFiles) {
271 271
             $this->deleteFiles($entry);
272 272
 
273 273
             return;
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
 
297 297
         $previousValue = $entry->getOriginal($field);
298 298
 
299
-        if (! $previousValue) {
299
+        if (!$previousValue) {
300 300
             return $previousValue;
301 301
         }
302 302
 
Please login to merge, or discard this patch.
src/app/Library/Database/DatabaseSchema.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     private static function generateDatabaseSchema(string $connection)
55 55
     {
56
-        if (! isset(self::$schema[$connection])) {
56
+        if (!isset(self::$schema[$connection])) {
57 57
             self::$schema[$connection] = self::mapTables($connection);
58 58
         }
59 59
     }
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     private static function mapTables(string $connection)
68 68
     {
69
-        return LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function ($table, $key) use ($connection) {
69
+        return LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function($table, $key) use ($connection) {
70 70
             $tableName = is_array($table) ? $table['name'] : $table->getName();
71 71
 
72 72
             if (self::$schema[$connection][$tableName] ?? false) {
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $schemaManager = self::getSchemaManager($connection);
87 87
         $indexes = method_exists($schemaManager, 'listTableIndexes') ? $schemaManager->listTableIndexes($table) : $schemaManager->getIndexes($table);
88 88
 
89
-        $indexes = array_map(function ($index) {
89
+        $indexes = array_map(function($index) {
90 90
             return is_array($index) ? $index['columns'] : $index->getColumns();
91 91
         }, $indexes);
92 92
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         $indexedColumns = self::getIndexColumnNames($connection, $table);
101 101
 
102
-        return LazyCollection::make(self::getSchemaManager($connection)->getColumns($table))->mapWithKeys(function ($column, $key) use ($indexedColumns) {
102
+        return LazyCollection::make(self::getSchemaManager($connection)->getColumns($table))->mapWithKeys(function($column, $key) use ($indexedColumns) {
103 103
             $column['index'] = array_key_exists($column['name'], $indexedColumns) ? true : false;
104 104
 
105 105
             return [$column['name'] => $column];
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@
 block discarded – undo
21 21
         }
22 22
 
23 23
         $previousValues = str_contains($attribute, '.') ?
24
-                            Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) :
25
-                            $entry->{$attribute};
24
+                            Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) : $entry->{$attribute};
26 25
 
27 26
         if (is_string($previousValues)) {
28 27
             $previousValues = json_decode($previousValues, true) ?? [];
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUpload.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     {
21 21
         $entry = CrudPanelFacade::getCurrentEntry();
22 22
 
23
-        if (! array_key_exists($attribute, $this->data)) {
23
+        if (!array_key_exists($attribute, $this->data)) {
24 24
             $requestAttribute = Arr::get($this->data, '_order_'.$attribute);
25 25
 
26 26
             if ($entry && Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) === $requestAttribute) {
@@ -32,14 +32,14 @@  discard block
 block discarded – undo
32 32
 
33 33
         $fieldErrors = $this->validateFieldRules($attribute, $value);
34 34
 
35
-        if (! empty($value) && ! empty($this->getFileRules())) {
35
+        if (!empty($value) && !empty($this->getFileRules())) {
36 36
             $fileErrors = $this->validateFileRules($attribute, $value);
37 37
         }
38 38
 
39 39
         return array_merge($fieldErrors, $fileErrors ?? []);
40 40
     }
41 41
 
42
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
42
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
43 43
     {
44 44
         return parent::field($rules);
45 45
     }
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/BackpackCustomRule.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -28,13 +28,13 @@  discard block
 block discarded – undo
28 28
 
29 29
     public bool $implicit = true;
30 30
 
31
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
31
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
32 32
     {
33 33
         $instance = new static();
34 34
         $instance->fieldRules = self::getRulesAsArray($rules);
35 35
 
36 36
         if ($instance->validatesArrays()) {
37
-            if (! in_array('array', $instance->getFieldRules())) {
37
+            if (!in_array('array', $instance->getFieldRules())) {
38 38
                 $instance->fieldRules[] = 'array';
39 39
             }
40 40
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
     public function getFieldRules(): array
96 96
     {
97
-        return tap($this->fieldRules, function ($rule) {
97
+        return tap($this->fieldRules, function($rule) {
98 98
             if (is_a($rule, BackpackCustomRule::class, true)) {
99 99
                 $rule = $rule->getFieldRules();
100 100
             }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
             $rules = explode('|', $rules);
110 110
         }
111 111
 
112
-        if (! is_array($rules)) {
112
+        if (!is_array($rules)) {
113 113
             $rules = [$rules];
114 114
         }
115 115
 
@@ -118,10 +118,10 @@  discard block
 block discarded – undo
118 118
 
119 119
     protected function ensureValueIsValid($value)
120 120
     {
121
-        if ($this->validatesArrays() && ! is_array($value)) {
121
+        if ($this->validatesArrays() && !is_array($value)) {
122 122
             try {
123 123
                 $value = json_decode($value, true) ?? [];
124
-            } catch(\Exception $e) {
124
+            } catch (\Exception $e) {
125 125
                 return false;
126 126
             }
127 127
         }
@@ -140,14 +140,13 @@  discard block
 block discarded – undo
140 140
             $attribute => $rules,
141 141
         ], $this->validator->customMessages, $this->validator->customAttributes);
142 142
 
143
-        return $validator->errors()->messages()[$attribute] ?? (! empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
143
+        return $validator->errors()->messages()[$attribute] ?? (!empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
144 144
     }
145 145
 
146 146
     protected function getValidationAttributeString(string $attribute)
147 147
     {
148 148
         return Str::substrCount($attribute, '.') > 1 ?
149
-                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') :
150
-                $attribute;
149
+                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') : $attribute;
151 150
     }
152 151
 
153 152
     protected function validateOnSubmit(string $attribute, mixed $value): array
@@ -155,7 +154,7 @@  discard block
 block discarded – undo
155 154
         return $this->validateRules($attribute, $value);
156 155
     }
157 156
 
158
-    protected function validateFieldAndFile(string $attribute, null|array $data = null, array|null $customRules = null): array
157
+    protected function validateFieldAndFile(string $attribute, null | array $data = null, array | null $customRules = null): array
159 158
     {
160 159
         $fieldErrors = $this->validateFieldRules($attribute, $data, $customRules);
161 160
 
@@ -167,7 +166,7 @@  discard block
 block discarded – undo
167 166
     /**
168 167
      * Implementation.
169 168
      */
170
-    public function validateFieldRules(string $attribute, null|array|UploadedFile $data = null, array|null $customRules = null): array
169
+    public function validateFieldRules(string $attribute, null | array | UploadedFile $data = null, array | null $customRules = null): array
171 170
     {
172 171
         $data = $data ?? $this->data;
173 172
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
@@ -176,16 +175,16 @@  discard block
 block discarded – undo
176 175
         return $this->validateAndGetErrors($validationRuleAttribute, $data, $customRules ?? $this->getFieldRules());
177 176
     }
178 177
 
179
-    protected function prepareValidatorData(array|UploadedFile $data, string $attribute): array
178
+    protected function prepareValidatorData(array | UploadedFile $data, string $attribute): array
180 179
     {
181
-        if ($this->validatesArrays() && is_array($data) && ! Str::contains($attribute, '.')) {
180
+        if ($this->validatesArrays() && is_array($data) && !Str::contains($attribute, '.')) {
182 181
             return Arr::has($data, $attribute) ? $data : [$attribute => Arr::get($data, $attribute)];
183 182
         }
184 183
 
185 184
         if (Str::contains($attribute, '.')) {
186 185
             $validData = [];
187 186
 
188
-            Arr::set($validData, $attribute, ! is_array($data) ? $data : Arr::get($data, $attribute));
187
+            Arr::set($validData, $attribute, !is_array($data) ? $data : Arr::get($data, $attribute));
189 188
 
190 189
             return $validData;
191 190
         }
@@ -199,7 +198,7 @@  discard block
 block discarded – undo
199 198
         $items = is_array($items) ? $items : [$items];
200 199
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
201 200
 
202
-        $filesToValidate = array_filter(Arr::get($items, $attribute), function ($item) {
201
+        $filesToValidate = array_filter(Arr::get($items, $attribute), function($item) {
203 202
             return $item instanceof UploadedFile;
204 203
         });
205 204
 
Please login to merge, or discard this patch.