Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5478)
by Cristian
30:16 queued 15:12
created
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => Str::replace(' ', '', $field)];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         }
190 190
         // if there's a model defined, but no attribute
191 191
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
192
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
192
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
193 193
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
194 194
         }
195 195
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      */
206 206
     protected function makeSureFieldHasLabel($field)
207 207
     {
208
-        if (! isset($field['label'])) {
208
+        if (!isset($field['label'])) {
209 209
             $name = str_replace(',', ' ', $field['name']);
210 210
             $name = str_replace('_id', '', $name);
211 211
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      */
224 224
     protected function makeSureFieldHasType($field)
225 225
     {
226
-        if (! isset($field['type'])) {
226
+        if (!isset($field['type'])) {
227 227
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
228 228
         }
229 229
 
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
      */
257 257
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
258 258
     {
259
-        if (! isset($field['subfields']) || ! is_array($field['subfields'])) {
259
+        if (!isset($field['subfields']) || !is_array($field['subfields'])) {
260 260
             return $field;
261 261
         }
262 262
 
263
-        if (! is_multidimensional_array($field['subfields'], true)) {
263
+        if (!is_multidimensional_array($field['subfields'], true)) {
264 264
             abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.');
265 265
         }
266 266
 
267 267
         foreach ($field['subfields'] as $key => $subfield) {
268
-            if (empty($subfield) || ! isset($subfield['name'])) {
268
+            if (empty($subfield) || !isset($subfield['name'])) {
269 269
                 abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.');
270 270
             }
271 271
 
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
             $subfield['baseFieldName'] = is_array($subfield['name']) ? implode(',', $subfield['name']) : $subfield['name'];
281 281
             $subfield['baseFieldName'] = Str::afterLast($subfield['baseFieldName'], '.');
282 282
 
283
-            if (! isset($field['model'])) {
283
+            if (!isset($field['model'])) {
284 284
                 // we're inside a simple 'repeatable' with no model/relationship, so
285 285
                 // we assume all subfields are supposed to be text fields
286 286
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -305,11 +305,11 @@  discard block
 block discarded – undo
305 305
                 case 'BelongsToMany':
306 306
                     $pivotSelectorField = static::getPivotFieldStructure($field);
307 307
 
308
-                    $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) {
308
+                    $pivot = Arr::where($field['subfields'], function($item) use ($pivotSelectorField) {
309 309
                         return $item['name'] === $pivotSelectorField['name'];
310 310
                     });
311 311
 
312
-                    if (! empty($pivot)) {
312
+                    if (!empty($pivot)) {
313 313
                         break;
314 314
                     }
315 315
 
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
                     $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity'];
323 323
                     $relationInstance = $this->getRelationInstance(['entity' => $entity]);
324 324
 
325
-                    $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) {
325
+                    $localKeyField = Arr::where($field['subfields'], function($item) use ($relationInstance) {
326 326
                         return $item['name'] === $relationInstance->getRelated()->getKeyName();
327 327
                     });
328 328
 
329
-                    if (! empty($localKeyField)) {
329
+                    if (!empty($localKeyField)) {
330 330
                         break;
331 331
                     }
332 332
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
     {
352 352
         // if a tab was mentioned, we should enable it
353 353
         if (isset($field['tab'])) {
354
-            if (! $this->tabsEnabled()) {
354
+            if (!$this->tabsEnabled()) {
355 355
                 $this->enableTabs();
356 356
             }
357 357
         }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/UploadersRepository.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function markAsHandled(string $objectName): void
35 35
     {
36
-        if (! in_array($objectName, $this->handledUploaders)) {
36
+        if (!in_array($objectName, $this->handledUploaders)) {
37 37
             $this->handledUploaders[] = $objectName;
38 38
         }
39 39
     }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public function registerRepeatableUploader(string $uploadName, UploaderInterface $uploader): void
85 85
     {
86
-        if (! array_key_exists($uploadName, $this->repeatableUploaders) || ! in_array($uploader, $this->repeatableUploaders[$uploadName])) {
86
+        if (!array_key_exists($uploadName, $this->repeatableUploaders) || !in_array($uploader, $this->repeatableUploaders[$uploadName])) {
87 87
             $this->repeatableUploaders[$uploadName][] = $uploader;
88 88
         }
89 89
     }
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      */
118 118
     public function getRegisteredUploadNames(string $uploadName): array
119 119
     {
120
-        return array_map(function ($uploader) {
120
+        return array_map(function($uploader) {
121 121
             return $uploader->getName();
122 122
         }, $this->getRepeatableUploadersFor($uploadName));
123 123
     }
@@ -154,16 +154,16 @@  discard block
 block discarded – undo
154 154
             abort(500, 'Could not find the field in the CRUD fields.');
155 155
         }
156 156
 
157
-        if (! $uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
157
+        if (!$uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
158 158
             abort(500, 'There is no uploader defined for the given field type.');
159 159
         }
160 160
 
161
-        if (! $this->isValidUploadField($crudObject, $uploaderMacro)) {
161
+        if (!$this->isValidUploadField($crudObject, $uploaderMacro)) {
162 162
             abort(500, 'Invalid field for upload.');
163 163
         }
164 164
 
165 165
         $uploaderConfiguration = $crudObject[$uploaderMacro] ?? [];
166
-        $uploaderConfiguration = ! is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
166
+        $uploaderConfiguration = !is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
167 167
         $uploaderClass = $this->getUploadFor($crudObject['type'], $uploaderMacro);
168 168
 
169 169
         return new $uploaderClass(['name' => $requestInputName], $uploaderConfiguration);
@@ -181,11 +181,11 @@  discard block
 block discarded – undo
181 181
     {
182 182
         if (Str::contains($crudObject['name'], '#')) {
183 183
             $container = Str::before($crudObject['name'], '#');
184
-            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function ($item) use ($crudObject, $uploaderMacro) {
184
+            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function($item) use ($crudObject, $uploaderMacro) {
185 185
                 return $item['name'] === $crudObject['name'] && in_array($item['type'], $this->getAjaxUploadTypes($uploaderMacro));
186 186
             });
187 187
 
188
-            return ! empty($field);
188
+            return !empty($field);
189 189
         }
190 190
 
191 191
         return in_array($crudObject['type'], $this->getAjaxUploadTypes($uploaderMacro));
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@
 block discarded – undo
21 21
         }
22 22
 
23 23
         $previousValues = str_contains($attribute, '.') ?
24
-                            Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) :
25
-                            $entry->{$attribute};
24
+                            Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) : $entry->{$attribute};
26 25
 
27 26
         if (is_string($previousValues)) {
28 27
             $previousValues = json_decode($previousValues, true) ?? [];
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUpload.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     {
21 21
         $entry = CrudPanelFacade::getCurrentEntry();
22 22
 
23
-        if (! array_key_exists($attribute, $this->data)) {
23
+        if (!array_key_exists($attribute, $this->data)) {
24 24
             $requestAttribute = Arr::get($this->data, '_order_'.$attribute);
25 25
 
26 26
             if ($entry && Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) === $requestAttribute) {
@@ -32,14 +32,14 @@  discard block
 block discarded – undo
32 32
 
33 33
         $fieldErrors = $this->validateFieldRules($attribute, $value);
34 34
 
35
-        if (! empty($value) && ! empty($this->getFileRules())) {
35
+        if (!empty($value) && !empty($this->getFileRules())) {
36 36
             $fileErrors = $this->validateFileRules($attribute, $value);
37 37
         }
38 38
 
39 39
         return array_merge($fieldErrors, $fileErrors ?? []);
40 40
     }
41 41
 
42
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
42
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
43 43
     {
44 44
         return parent::field($rules);
45 45
     }
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/BackpackCustomRule.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -28,13 +28,13 @@  discard block
 block discarded – undo
28 28
 
29 29
     public bool $implicit = true;
30 30
 
31
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
31
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
32 32
     {
33 33
         $instance = new static();
34 34
         $instance->fieldRules = self::getRulesAsArray($rules);
35 35
 
36 36
         if ($instance->validatesArrays()) {
37
-            if (! in_array('array', $instance->getFieldRules())) {
37
+            if (!in_array('array', $instance->getFieldRules())) {
38 38
                 $instance->fieldRules[] = 'array';
39 39
             }
40 40
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
     public function getFieldRules(): array
96 96
     {
97
-        return tap($this->fieldRules, function ($rule) {
97
+        return tap($this->fieldRules, function($rule) {
98 98
             if (is_a($rule, BackpackCustomRule::class, true)) {
99 99
                 $rule = $rule->getFieldRules();
100 100
             }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
             $rules = explode('|', $rules);
110 110
         }
111 111
 
112
-        if (! is_array($rules)) {
112
+        if (!is_array($rules)) {
113 113
             $rules = [$rules];
114 114
         }
115 115
 
@@ -118,10 +118,10 @@  discard block
 block discarded – undo
118 118
 
119 119
     protected function ensureValueIsValid($value)
120 120
     {
121
-        if ($this->validatesArrays() && ! is_array($value)) {
121
+        if ($this->validatesArrays() && !is_array($value)) {
122 122
             try {
123 123
                 $value = json_decode($value, true) ?? [];
124
-            } catch(\Exception $e) {
124
+            } catch (\Exception $e) {
125 125
                 return false;
126 126
             }
127 127
         }
@@ -140,14 +140,13 @@  discard block
 block discarded – undo
140 140
             $attribute => $rules,
141 141
         ], $this->validator->customMessages, $this->validator->customAttributes);
142 142
 
143
-        return $validator->errors()->messages()[$attribute] ?? (! empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
143
+        return $validator->errors()->messages()[$attribute] ?? (!empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
144 144
     }
145 145
 
146 146
     protected function getValidationAttributeString(string $attribute)
147 147
     {
148 148
         return Str::substrCount($attribute, '.') > 1 ?
149
-                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') :
150
-                $attribute;
149
+                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') : $attribute;
151 150
     }
152 151
 
153 152
     protected function validateOnSubmit(string $attribute, mixed $value): array
@@ -155,7 +154,7 @@  discard block
 block discarded – undo
155 154
         return $this->validateRules($attribute, $value);
156 155
     }
157 156
 
158
-    protected function validateFieldAndFile(string $attribute, null|array $data = null, array|null $customRules = null): array
157
+    protected function validateFieldAndFile(string $attribute, null | array $data = null, array | null $customRules = null): array
159 158
     {
160 159
         $fieldErrors = $this->validateFieldRules($attribute, $data, $customRules);
161 160
 
@@ -167,7 +166,7 @@  discard block
 block discarded – undo
167 166
     /**
168 167
      * Implementation.
169 168
      */
170
-    public function validateFieldRules(string $attribute, null|array|UploadedFile $data = null, array|null $customRules = null): array
169
+    public function validateFieldRules(string $attribute, null | array | UploadedFile $data = null, array | null $customRules = null): array
171 170
     {
172 171
         $data = $data ?? $this->data;
173 172
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
@@ -176,16 +175,16 @@  discard block
 block discarded – undo
176 175
         return $this->validateAndGetErrors($validationRuleAttribute, $data, $customRules ?? $this->getFieldRules());
177 176
     }
178 177
 
179
-    protected function prepareValidatorData(array|UploadedFile $data, string $attribute): array
178
+    protected function prepareValidatorData(array | UploadedFile $data, string $attribute): array
180 179
     {
181
-        if ($this->validatesArrays() && is_array($data) && ! Str::contains($attribute, '.')) {
180
+        if ($this->validatesArrays() && is_array($data) && !Str::contains($attribute, '.')) {
182 181
             return Arr::has($data, $attribute) ? $data : [$attribute => Arr::get($data, $attribute)];
183 182
         }
184 183
 
185 184
         if (Str::contains($attribute, '.')) {
186 185
             $validData = [];
187 186
 
188
-            Arr::set($validData, $attribute, ! is_array($data) ? $data : Arr::get($data, $attribute));
187
+            Arr::set($validData, $attribute, !is_array($data) ? $data : Arr::get($data, $attribute));
189 188
 
190 189
             return $validData;
191 190
         }
@@ -199,7 +198,7 @@  discard block
 block discarded – undo
199 198
         $items = is_array($items) ? $items : [$items];
200 199
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
201 200
 
202
-        $filesToValidate = array_filter(Arr::get($items, $attribute), function ($item) {
201
+        $filesToValidate = array_filter(Arr::get($items, $attribute), function($item) {
203 202
             return $item instanceof UploadedFile;
204 203
         });
205 204
 
Please login to merge, or discard this patch.