Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — ensure-reorder-items-match-the... ( 0d3fba )
by Pedro
15:05
created
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
 
819 819
     public function testCreateBelongsToFake()
820 820
     {
821
-        $belongsToField = [   // select_grouped
821
+        $belongsToField = [// select_grouped
822 822
             'label' => 'Select_grouped',
823 823
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
824 824
             'name' => 'bang_relation_field',
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
954 954
                 'nickname' => 'i_have_has_one',
955 955
                 'profile_picture' => 'ohh my picture 1.jpg',
956 956
                 'article' => 1,
957
-                'addresses' => [ // HasOne is tested in other test function
957
+                'addresses' => [// HasOne is tested in other test function
958 958
                     [
959 959
                         'city' => 2,
960 960
                         'street' => 'test',
@@ -1707,23 +1707,23 @@  discard block
 block discarded – undo
1707 1707
         $this->crudPanel->addField([
1708 1708
             'name' => 'name',
1709 1709
             'events' => [
1710
-                'created' => function ($entry) {
1710
+                'created' => function($entry) {
1711 1711
                 },
1712
-                'creating' => function ($entry) {
1712
+                'creating' => function($entry) {
1713 1713
                     $entry->email = '[email protected]';
1714 1714
                     $entry->password = Hash::make('password');
1715 1715
                 },
1716
-                'saving' => function ($entry) {
1716
+                'saving' => function($entry) {
1717 1717
                 },
1718
-                'saved' => function ($entry) {
1718
+                'saved' => function($entry) {
1719 1719
                 },
1720
-                'updating' => function ($entry) {
1720
+                'updating' => function($entry) {
1721 1721
                 },
1722
-                'updated' => function ($entry) {
1722
+                'updated' => function($entry) {
1723 1723
                 },
1724
-                'deleting' => function ($entry) {
1724
+                'deleting' => function($entry) {
1725 1725
                 },
1726
-                'deleted' => function ($entry) {
1726
+                'deleted' => function($entry) {
1727 1727
                 },
1728 1728
             ],
1729 1729
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function applySearchTerm($searchTerm)
24 24
     {
25
-        return $this->query->where(function ($query) use ($searchTerm) {
25
+        return $this->query->where(function($query) use ($searchTerm) {
26 26
             foreach ($this->columns() as $column) {
27
-                if (! isset($column['type'])) {
27
+                if (!isset($column['type'])) {
28 28
                     abort(400, 'Missing column type when trying to apply search term.');
29 29
                 }
30 30
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
                 case 'select':
86 86
                 case 'select_multiple':
87
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm, $searchOperator) {
87
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm, $searchOperator) {
88 88
                         $q->where($this->getColumnWithTableNamePrefixed($q, $column['attribute']), $searchOperator, '%'.$searchTerm.'%');
89 89
                     });
90 90
                     break;
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
109 109
                 $column = $this->findColumnById($column_number);
110 110
 
111
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
111
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
112 112
                     if (method_exists($this->model, 'translationEnabled') &&
113 113
                         $this->model->translationEnabled() &&
114 114
                         $this->model->isTranslatableAttribute($column['name']) &&
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         $key = $this->model->getKeyName();
137 137
         $groupBy = $this->query->toBase()->groups;
138 138
 
139
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
139
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
140 140
             return (isset($item['column']) && $item['column'] === $key)
141 141
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
142 142
         });
143 143
 
144
-        if (! $hasOrderByPrimaryKey && empty($groupBy)) {
144
+        if (!$hasOrderByPrimaryKey && empty($groupBy)) {
145 145
             $this->orderByWithPrefix($key, 'DESC');
146 146
         }
147 147
     }
@@ -320,13 +320,13 @@  discard block
 block discarded – undo
320 320
         if (isset($column['type'])) {
321 321
             // create a list of paths to column blade views
322 322
             // including the configured view_namespaces
323
-            $columnPaths = array_map(function ($item) use ($column) {
323
+            $columnPaths = array_map(function($item) use ($column) {
324 324
                 return $item.'.'.$column['type'];
325 325
             }, ViewNamespaces::getFor('columns'));
326 326
 
327 327
             // but always fall back to the stock 'text' column
328 328
             // if a view doesn't exist
329
-            if (! in_array('crud::columns.text', $columnPaths)) {
329
+            if (!in_array('crud::columns.text', $columnPaths)) {
330 330
                 $columnPaths[] = 'crud::columns.text';
331 331
             }
332 332
 
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
      */
366 366
     private function renderCellView($view, $column, $entry, $rowNumber = false)
367 367
     {
368
-        if (! view()->exists($view)) {
368
+        if (!view()->exists($view)) {
369 369
             $view = 'crud::columns.text'; // fallback to text column
370 370
         }
371 371
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             return ['name' => Str::replace(' ', '', $column)];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function makeSureColumnHasLabel($column)
70 70
     {
71
-        if (! isset($column['label'])) {
71
+        if (!isset($column['label'])) {
72 72
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
73 73
         }
74 74
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     protected function makeSureColumnHasKey($column)
155 155
     {
156
-        if (! isset($column['key'])) {
156
+        if (!isset($column['key'])) {
157 157
             $column['key'] = str_replace('.', '__', $column['name']);
158 158
         }
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureColumnHasWrapper($column)
172 172
     {
173
-        if (! isset($column['wrapper'])) {
173
+        if (!isset($column['wrapper'])) {
174 174
             $column['wrapper'] = [];
175 175
         }
176 176
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -292,8 +292,7 @@  discard block
 block discarded – undo
292 292
         $columnsArray = $this->columns();
293 293
 
294 294
         if (array_key_exists($targetColumnName, $columnsArray)) {
295
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
296
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
295
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
297 296
 
298 297
             $element = array_pop($columnsArray);
299 298
 
@@ -322,7 +321,7 @@  discard block
 block discarded – undo
322 321
     {
323 322
         static $cache = [];
324 323
 
325
-        if (! $this->driverIsSql()) {
324
+        if (!$this->driverIsSql()) {
326 325
             return true;
327 326
         }
328 327
 
@@ -338,7 +337,7 @@  discard block
 block discarded – undo
338 337
     /**
339 338
      * Prepare the column attributes and add it to operation settings.
340 339
      */
341
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
340
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
342 341
     {
343 342
         $column = $this->makeSureColumnHasNeededAttributes($column);
344 343
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // Install Backpack Generators
85 85
         $this->progressBlock('Installing Generators');
86
-        if (! file_exists('vendor/backpack/generators/composer.json')) {
86
+        if (!file_exists('vendor/backpack/generators/composer.json')) {
87 87
             // only do this if Generators aren't already required
88 88
             $process = new Process(['composer', 'require', '--dev', 'backpack/generators']);
89 89
             $process->setTimeout(300);
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $this->closeProgressBlock();
98 98
 
99 99
         // Optional commands
100
-        if (! $this->option('no-interaction')) {
100
+        if (!$this->option('no-interaction')) {
101 101
             // Themes
102 102
             $this->installTheme();
103 103
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
             // Addons
108 108
             $this->installAddons();
109
-        } elseif (! $this->isAnyThemeInstalled()) {
109
+        } elseif (!$this->isAnyThemeInstalled()) {
110 110
             // Install default theme
111 111
             $this->progressBlock('Installing default theme');
112 112
             $this->executeArtisanProcess('backpack:require:theme-tabler');
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 
190 190
         $this->deleteLines(3);
191 191
 
192
-        if (! $total) {
192
+        if (!$total) {
193 193
             $this->deleteLines();
194 194
             $this->note('Skipping creating an admin user.');
195 195
             $this->newLine();
@@ -198,14 +198,14 @@  discard block
 block discarded – undo
198 198
 
199 199
     private function isEveryAddonInstalled()
200 200
     {
201
-        return collect($this->addons)->every(function ($addon) {
201
+        return collect($this->addons)->every(function($addon) {
202 202
             return file_exists($addon->path);
203 203
         });
204 204
     }
205 205
 
206 206
     private function updateAddonsStatus()
207 207
     {
208
-        $this->addons = $this->addons->each(function (&$addon) {
208
+        $this->addons = $this->addons->each(function(&$addon) {
209 209
             $isInstalled = file_exists($addon->path);
210 210
             $addon->status = $isInstalled ? 'installed' : 'not installed';
211 211
             $addon->statusColor = $isInstalled ? 'green' : 'yellow';
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         // map the addons
218 218
         $this->addons = collect($this->addons)
219
-            ->map(function ($class) {
219
+            ->map(function($class) {
220 220
                 return (object) $class::$addon;
221 221
             });
222 222
 
@@ -235,15 +235,15 @@  discard block
 block discarded – undo
235 235
 
236 236
         // Calculate the printed line count
237 237
         $printedLines = $this->addons
238
-            ->map(function ($e) {
238
+            ->map(function($e) {
239 239
                 return count($e->description);
240 240
             })
241
-            ->reduce(function ($sum, $item) {
241
+            ->reduce(function($sum, $item) {
242 242
                 return $sum + $item + 2;
243 243
             }, 0);
244 244
 
245 245
         $total = 0;
246
-        while (! $this->isEveryAddonInstalled()) {
246
+        while (!$this->isEveryAddonInstalled()) {
247 247
             $input = (int) $this->listChoice('Would you like to install a premium Backpack add-on? <fg=gray>(enter an option number from above or press any other key to continue the installation)</>', $this->addons->toArray());
248 248
 
249 249
             if ($input < 1 || $input > $this->addons->count()) {
@@ -278,14 +278,14 @@  discard block
 block discarded – undo
278 278
 
279 279
     private function isEveryThemeInstalled()
280 280
     {
281
-        return $this->themes()->every(function ($theme) {
281
+        return $this->themes()->every(function($theme) {
282 282
             return $theme->status == 'installed';
283 283
         });
284 284
     }
285 285
 
286 286
     private function isAnyThemeInstalled()
287 287
     {
288
-        return $this->themes()->filter(function ($theme) {
288
+        return $this->themes()->filter(function($theme) {
289 289
             return $theme->status == 'installed';
290 290
         })->count() > 0;
291 291
     }
@@ -303,10 +303,10 @@  discard block
 block discarded – undo
303 303
 
304 304
         // Calculate the printed line count
305 305
         $printedLines = $this->themes()
306
-            ->map(function ($e) {
306
+            ->map(function($e) {
307 307
                 return count($e->description);
308 308
             })
309
-            ->reduce(function ($sum, $item) {
309
+            ->reduce(function($sum, $item) {
310 310
                 return $sum + $item + 2;
311 311
             }, 0);
312 312
 
@@ -342,9 +342,9 @@  discard block
 block discarded – undo
342 342
     public function themes()
343 343
     {
344 344
         return collect($this->themes)
345
-            ->map(function ($class) {
345
+            ->map(function($class) {
346 346
                 return (object) $class::$addon;
347
-            })->each(function (&$theme) {
347
+            })->each(function(&$theme) {
348 348
                 $isInstalled = file_exists($theme->path);
349 349
                 $theme->status = $isInstalled ? 'installed' : 'not installed';
350 350
                 $theme->statusColor = $isInstalled ? 'green' : 'yellow';
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Input.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         //remove fields that are not in the submitted form input
101
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
101
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
102 102
             return Arr::has($input, $field['name']) || isset($input[$field['name']]) || Arr::has($input, Str::afterLast($field['name'], '.'));
103 103
         });
104 104
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
                     // the key used to store the values is the main relation key
128 128
                     $key = Str::beforeLast($this->getOnlyRelationEntity($field), '.');
129 129
 
130
-                    if (! isset($field['parentFieldName']) && isset($field['entity'])) {
130
+                    if (!isset($field['parentFieldName']) && isset($field['entity'])) {
131 131
                         $mainField = $field;
132 132
                         $mainField['entity'] = Str::beforeLast($field['entity'], '.');
133 133
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
             // when using dot notation if relationMethod is not set we are sure we want to exclude those relations.
187 187
             if ($this->getOnlyRelationEntity($field) !== $field['entity']) {
188
-                if (! $relationMethod) {
188
+                if (!$relationMethod) {
189 189
                     $excludedFields[] = $nameToExclude;
190 190
                 }
191 191
 
@@ -199,8 +199,8 @@  discard block
 block discarded – undo
199 199
             }
200 200
         }
201 201
 
202
-        return Arr::where($input, function ($item, $key) use ($excludedFields) {
203
-            return ! in_array($key, $excludedFields);
202
+        return Arr::where($input, function($item, $key) use ($excludedFields) {
203
+            return !in_array($key, $excludedFields);
204 204
         });
205 205
     }
206 206
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
                 $jsonCastables = ['array', 'object', 'json'];
227 227
                 $fieldCasting = $casted_attributes[$field['name']];
228 228
 
229
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
229
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
230 230
                     try {
231 231
                         $input[$field['name']] = json_decode($input[$field['name']]);
232 232
                     } catch (\Exception $e) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Reorder.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
         $itemKeys = $this->model->query()->select($primaryKey)->get()->pluck($primaryKey);
27 27
 
28 28
         // filter the items that are not in the database and map the request
29
-        $reorderItems = collect($request)->filter(function ($item) use ($itemKeys) {
29
+        $reorderItems = collect($request)->filter(function($item) use ($itemKeys) {
30 30
             return $item['item_id'] !== '' && $item['item_id'] !== null && $itemKeys->contains($item['item_id']);
31
-        })->map(function ($item) use ($primaryKey) {
31
+        })->map(function($item) use ($primaryKey) {
32 32
             $item[$primaryKey] = (int) $item['item_id'];
33 33
             $item['parent_id'] = empty($item['parent_id']) ? null : (int) $item['parent_id'];
34 34
             $item['depth'] = empty($item['depth']) ? null : (int) $item['depth'];
@@ -42,12 +42,12 @@  discard block
 block discarded – undo
42 42
 
43 43
         $sentIds = array_column($reorderItems, $primaryKey);
44 44
 
45
-        $itemKeys = $itemKeys->filter(function ($id) use ($sentIds) {
45
+        $itemKeys = $itemKeys->filter(function($id) use ($sentIds) {
46 46
             return in_array($id, $sentIds);
47 47
         });
48 48
 
49 49
         // wrap the queries in a transaction to avoid partial updates
50
-        DB::transaction(function () use ($reorderItems, $primaryKey, $itemKeys) {
50
+        DB::transaction(function() use ($reorderItems, $primaryKey, $itemKeys) {
51 51
             // create a string of ?,?,?,? to use as bind placeholders for item keys
52 52
             $reorderItemsBindString = implode(',', array_fill(0, count($reorderItems), '?'));
53 53
 
Please login to merge, or discard this patch.