Backpack\CRUD\app\Library\CrudPanel\Support\HasSubfields::subfields()

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function subfields($subfields)
    {
        $callAttributeMacro = ! isset($this->attributes['subfields']);
        $this->attributes['subfields'] = $subfields;

The property attributes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->attributes = $this->crud()->makeSureFieldHasNecessaryAttributes($this->attributes);

It seems like crud() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($callAttributeMacro) {
            $this->callRegisteredAttributeMacros();

It seems like callRegisteredAttributeMacros() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }