Backpack\CRUD\app\Library\CrudPanel\Support\HasSubfields

Complexity

Total Complexity

2

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	subfields()	0	10	2

<?php

namespace Backpack\CRUD\app\Library\CrudPanel\Support;

trait HasSubfields
{
    /**
     * When subfields are defined, pass them through the guessing function
     * so that they have label, relationship attributes, etc.
     *
     * @param  array  $subfields  Subfield definition array
     * @return self
     */
    public function subfields($subfields)
    {
        $callAttributeMacro = ! isset($this->attributes['subfields']);
        $this->attributes['subfields'] = $subfields;

The property attributes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->attributes = $this->crud()->makeSureFieldHasNecessaryAttributes($this->attributes);

It seems like crud() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($callAttributeMacro) {
            $this->callRegisteredAttributeMacros();

It seems like callRegisteredAttributeMacros() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}