Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — CrudButton-fixees ( a4c9f3...1a6e15 )
by Pedro
15:19
created
tests/Unit/CrudPanel/CrudPanelFieldsTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
     {
610 610
         $this->crudPanel->setOperationSetting(
611 611
             'strippedRequest',
612
-            static function (Request $request) {
612
+            static function(Request $request) {
613 613
                 return $request->toArray();
614 614
             },
615 615
             'update'
@@ -743,7 +743,7 @@  discard block
 block discarded – undo
743 743
                         ->validationMessages(['required' => 'is_required', 'min' => 'min_2'])
744 744
                         ->store_in('some')
745 745
                         ->size(6)
746
-                        ->on('created', function () {
746
+                        ->on('created', function() {
747 747
                         })
748 748
                         ->subfields([['name' => 'sub_1']])
749 749
                         ->entity('bang');
@@ -775,7 +775,7 @@  discard block
 block discarded – undo
775 775
                 'class' => 'form-group col-md-6',
776 776
             ],
777 777
             'events' => [
778
-                'created' => function () {
778
+                'created' => function() {
779 779
                 },
780 780
             ],
781 781
             'subfields' => [
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelFiltersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     {
49 49
         $this->crudPanel->setModel(User::class);
50 50
         $request = request()->create('/admin/users', 'GET', ['my_custom_filter' => 'foo']);
51
-        $request->setRouteResolver(function () use ($request) {
51
+        $request->setRouteResolver(function() use ($request) {
52 52
             return (new Route('GET', 'admin/users', ['UserCrudController', 'index']))->bind($request);
53 53
         });
54 54
         $this->crudPanel->setRequest($request);
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
                     ->options(['test' => 'test'])
65 65
                     ->view('simple')
66 66
                     ->viewNamespace('crud::filters')
67
-                    ->ifActive(function () {
67
+                    ->ifActive(function() {
68 68
                         return true;
69 69
                     })
70
-                    ->ifInactive(function () {
70
+                    ->ifInactive(function() {
71 71
                         return true;
72 72
                     });
73 73
 
@@ -84,10 +84,10 @@  discard block
 block discarded – undo
84 84
     public function testWhenActiveAndWhenInactiveAliases()
85 85
     {
86 86
         $filter = CrudFilter::name('my_filter')
87
-                        ->whenActive(function () {
87
+                        ->whenActive(function() {
88 88
                             return true;
89 89
                         })
90
-                        ->whenInactive(function () {
90
+                        ->whenInactive(function() {
91 91
                             return true;
92 92
                         });
93 93
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 
99 99
     public function testWhenNotActiveAlias()
100 100
     {
101
-        $filter = CrudFilter::name('my_filter')->whenNotActive(function () {
101
+        $filter = CrudFilter::name('my_filter')->whenNotActive(function() {
102 102
             return true;
103 103
         });
104 104
         $this->assertCount(1, $this->crudPanel->filters());
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
     public function testIfNotActiveAlias()
109 109
     {
110
-        $filter = CrudFilter::name('my_filter')->ifNotActive(function () {
110
+        $filter = CrudFilter::name('my_filter')->ifNotActive(function() {
111 111
             return true;
112 112
         });
113 113
         $this->assertCount(1, $this->crudPanel->filters());
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
     public function testElseAlias()
118 118
     {
119
-        $filter = CrudFilter::name('my_filter')->else(function () {
119
+        $filter = CrudFilter::name('my_filter')->else(function() {
120 120
             return true;
121 121
         });
122 122
         $this->assertCount(1, $this->crudPanel->filters());
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
     {
24 24
         parent::getEnvironmentSetUp($app);
25 25
 
26
-        $app->singleton('crud', function ($app) {
26
+        $app->singleton('crud', function($app) {
27 27
             return new CrudPanel($app);
28 28
         });
29 29
 
Please login to merge, or discard this patch.
src/routes/backpack/testing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     (array) config('backpack.base.middleware_key', 'admin'),
16 16
     'prefix'     => config('backpack.base.route_prefix', 'admin'),
17 17
 ],
18
-    function () {
18
+    function() {
19 19
         Route::crud('users', 'Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController');
20 20
     }
21 21
 );
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new \Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new \Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 
206 206
         $complete_route = $route.'.index';
207 207
 
208
-        if (! \Route::has($complete_route)) {
208
+        if (!\Route::has($complete_route)) {
209 209
             throw new \Exception('There are no routes for this route name.', 404);
210 210
         }
211 211
 
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function getFirstOfItsTypeInArray($type, $array)
305 305
     {
306
-        return Arr::first($array, function ($item) use ($type) {
306
+        return Arr::first($array, function($item) use ($type) {
307 307
             return $item['type'] == $type;
308 308
         });
309 309
     }
@@ -322,8 +322,8 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function sync($type, $fields, $attributes)
324 324
     {
325
-        if (! empty($this->{$type})) {
326
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
325
+        if (!empty($this->{$type})) {
326
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
327 327
                 if (in_array($field['name'], (array) $fields)) {
328 328
                     $field = array_merge($field, $attributes);
329 329
                 }
@@ -353,15 +353,15 @@  discard block
 block discarded – undo
353 353
     {
354 354
         $relationArray = explode('.', $relationString);
355 355
 
356
-        if (! isset($length)) {
356
+        if (!isset($length)) {
357 357
             $length = count($relationArray);
358 358
         }
359 359
 
360
-        if (! isset($model)) {
360
+        if (!isset($model)) {
361 361
             $model = $this->model;
362 362
         }
363 363
 
364
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
364
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
365 365
             try {
366 366
                 $result = $obj->$method();
367 367
 
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
             if (is_array($entries)) {
397 397
                 //if attribute does not exist in main array we have more than one entry OR the attribute
398 398
                 //is an acessor that is not in $appends property of model.
399
-                if (! isset($entries[$attribute])) {
399
+                if (!isset($entries[$attribute])) {
400 400
                     //we first check if we don't have the attribute because it's an acessor that is not in appends.
401 401
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
402 402
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -435,21 +435,21 @@  discard block
 block discarded – undo
435 435
      */
436 436
     public function parseTranslatableAttributes($model, $attribute, $value)
437 437
     {
438
-        if (! method_exists($model, 'isTranslatableAttribute')) {
438
+        if (!method_exists($model, 'isTranslatableAttribute')) {
439 439
             return $value;
440 440
         }
441 441
 
442
-        if (! $model->isTranslatableAttribute($attribute)) {
442
+        if (!$model->isTranslatableAttribute($attribute)) {
443 443
             return $value;
444 444
         }
445 445
 
446
-        if (! is_array($value)) {
446
+        if (!is_array($value)) {
447 447
             $decodedAttribute = json_decode($value, true);
448 448
         } else {
449 449
             $decodedAttribute = $value;
450 450
         }
451 451
 
452
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
452
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
453 453
             if (isset($decodedAttribute[app()->getLocale()])) {
454 454
                 return $decodedAttribute[app()->getLocale()];
455 455
             } else {
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         $relation = $model->{$firstRelationName};
476 476
 
477 477
         $results = [];
478
-        if (! is_null($relation)) {
478
+        if (!is_null($relation)) {
479 479
             if ($relation instanceof Collection) {
480 480
                 $currentResults = $relation->all();
481 481
             } elseif (is_array($relation)) {
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
488 488
 
489 489
             array_shift($relationArray);
490 490
 
491
-            if (! empty($relationArray)) {
491
+            if (!empty($relationArray)) {
492 492
                 foreach ($currentResults as $currentResult) {
493 493
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
494 494
                 }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
         //
33 33
         // It's done inside a middleware closure in order to have
34 34
         // the complete request inside the CrudPanel object.
35
-        $this->middleware(function ($request, $next) {
35
+        $this->middleware(function($request, $next) {
36 36
             $this->crud = app('crud');
37 37
 
38 38
             $this->crud->setRequest($request);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
         $this->singleSaveAction = [
26 26
             'name' => 'save_action_one',
27 27
             'button_text' => 'custom',
28
-            'redirect' => function ($crud, $request, $itemId) {
28
+            'redirect' => function($crud, $request, $itemId) {
29 29
                 return $crud->route;
30 30
             },
31
-            'visible' => function ($crud) {
31
+            'visible' => function($crud) {
32 32
                 return true;
33 33
             },
34 34
         ];
@@ -36,19 +36,19 @@  discard block
 block discarded – undo
36 36
         $this->multipleSaveActions = [
37 37
             [
38 38
                 'name' => 'save_action_one',
39
-                'redirect' => function ($crud, $request, $itemId) {
39
+                'redirect' => function($crud, $request, $itemId) {
40 40
                     return $crud->route;
41 41
                 },
42
-                'visible' => function ($crud) {
42
+                'visible' => function($crud) {
43 43
                     return true;
44 44
                 },
45 45
             ],
46 46
             [
47 47
                 'name' => 'save_action_two',
48
-                'redirect' => function ($crud, $request, $itemId) {
48
+                'redirect' => function($crud, $request, $itemId) {
49 49
                     return $crud->route;
50 50
                 },
51
-                'visible' => function ($crud) {
51
+                'visible' => function($crud) {
52 52
                     return true;
53 53
                 },
54 54
             ],
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
         }
41 41
 
42 42
         // check if position is a valid position
43
-        if ($position && ! ButtonPositionEnum::isValid($position)) {
43
+        if ($position && !ButtonPositionEnum::isValid($position)) {
44 44
             throw new \Exception('CRUD Button position "'.$position.'" is not a valid position. Please use one of the following: '.implode(', ', ButtonPositionEnum::getValues()), 500);
45 45
         }
46 46
 
47 47
         // check if stack is a valid stack
48
-        if ($stack && ! ButtonStackEnum::isValid($stack)) {
48
+        if ($stack && !ButtonStackEnum::isValid($stack)) {
49 49
                 throw new \Exception('CRUD Button stack "'.$stack.'" is not a valid stack. Please use one of the following: '.implode(', ', ButtonStackEnum::getValues()), 500);
50 50
         }
51 51
         
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
     private function getViewPathsWithFallbacks()
293 293
     {
294 294
         $type = $this->name;
295
-        $paths = array_map(function ($item) use ($type) {
295
+        $paths = array_map(function($item) use ($type) {
296 296
             return $item.'.'.$type;
297 297
         }, ViewNamespaces::getFor('buttons'));
298 298
 
@@ -452,14 +452,14 @@  discard block
 block discarded – undo
452 452
      */
453 453
     private function save()
454 454
     {
455
-        if($this->collection()->isEmpty()) {
455
+        if ($this->collection()->isEmpty()) {
456 456
             $this->crud()->addCrudButton($this);
457 457
             return $this;
458 458
         }
459 459
 
460 460
         $itemExists = $this->collection()->contains('name', $this->name);
461 461
        
462
-        if (! $itemExists) { 
462
+        if (!$itemExists) { 
463 463
             $this->crud()->addCrudButton($this);
464 464
             if ($this->position == 'beginning') {
465 465
                 $this->before($this->collection()->first()->name);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $otherButtons = collect([]);
25 25
 
26 26
         // we get the buttons that belong to the specified stack
27
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
27
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
28 28
             if ($item->stack != $stack) {
29 29
                 // if the button does not belong to this stack we just add it for merging later
30 30
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
         });
37 37
 
38 38
         // we parse the ordered buttons
39
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
40
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
39
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
40
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
41 41
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
42 42
             }
43 43
             $newButtons->push($button);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // we add the remaining buttons to the end of the ordered ones
48 48
         if (count($newButtons) < count($stackButtons)) {
49 49
             foreach ($stackButtons as $button) {
50
-                if (! $newButtons->where('name', $button->name)->first()) {
50
+                if (!$newButtons->where('name', $button->name)->first()) {
51 51
                     $newButtons->push($button);
52 52
                 }
53 53
             }
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
          */
117 117
         $button = $this->buttons()->firstWhere('name', $name);
118 118
 
119
-        if (! $button) {
119
+        if (!$button) {
120 120
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
121 121
         }
122 122
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     public function removeButton($name, $stack = null)
139 139
     {
140
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
140
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
141 141
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
142 142
         }));
143 143
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function removeButtons($names, $stack = null)
150 150
     {
151
-        if (! empty($names)) {
151
+        if (!empty($names)) {
152 152
             foreach ($names as $name) {
153 153
                 $this->removeButton($name, $stack);
154 154
             }
@@ -162,14 +162,14 @@  discard block
 block discarded – undo
162 162
 
163 163
     public function removeAllButtonsFromStack($stack)
164 164
     {
165
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
165
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
166 166
             return $button->stack == $stack;
167 167
         }));
168 168
     }
169 169
 
170 170
     public function removeButtonFromStack($name, $stack)
171 171
     {
172
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
172
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
173 173
             return $button->name == $name && $button->stack == $stack;
174 174
         }));
175 175
     }
@@ -190,15 +190,15 @@  discard block
 block discarded – undo
190 190
         $destinationKey = $this->getButtonKey($destination);
191 191
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
192 192
 
193
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
193
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
194 194
             return $value->name != $target;
195 195
         });
196 196
 
197
-        if (! $targetButton) {
197
+        if (!$targetButton) {
198 198
             return;
199 199
         }
200 200
 
201
-        if (! $destinationButton) {
201
+        if (!$destinationButton) {
202 202
             return;
203 203
         }
204 204
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $newButtons = $firstSlice->push($targetButton);
209 209
    
210
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
210
+        $lastSlice->each(function($item, $key) use ($newButtons) {
211 211
             $newButtons->push($item);
212 212
         });
213 213
 
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
      * @param  string|array  $attributes  Button name or array that contains name, stack, type and content.
273 273
      * @return \Backpack\CRUD\app\Library\CrudPanel\CrudButton
274 274
      */
275
-    public function button(string|array $name)
275
+    public function button(string | array $name)
276 276
     {
277 277
         return new CrudButton('name');
278 278
     }
Please login to merge, or discard this patch.