Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#124)
by Owen
04:17
created
src/resources/views-elfinder/elfinder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     <!-- elFinder JS (REQUIRED) -->
18 18
     <script src="<?= asset($dir.'/js/elfinder.min.js') ?>"></script>
19 19
 
20
-    <?php if($locale){ ?>
20
+    <?php if ($locale) { ?>
21 21
         <!-- elFinder translation (OPTIONAL) -->
22 22
         <script src="<?= asset($dir."/js/i18n/elfinder.$locale.js") ?>"></script>
23 23
     <?php } ?>
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
         $().ready(function() {
41 41
             var elf = $('#elfinder').elfinder({
42 42
                 // set your elFinder options here
43
-                <?php if($locale){ ?>
43
+                <?php if ($locale) { ?>
44 44
                     lang: '<?= $locale ?>', // locale
45 45
                 <?php } ?>
46 46
                 customData: {
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 3 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -15,15 +15,15 @@  discard block
 block discarded – undo
15 15
       $dependencyArray = [];
16 16
 
17 17
       //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
-      foreach($dependencies as $primary){
18
+      foreach ($dependencies as $primary) {
19 19
           $dependencyArray[$primary->id] = [];
20
-        foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
20
+        foreach ($primary->{$primary_dependency['entity_secondary']} as $secondary) {
21 21
             $dependencyArray[$primary->id][] = $secondary->id;
22 22
         }
23 23
       }
24 24
 
25 25
       //for update form, get initial state of the entity
26
-      if( isset($id) && $id ){
26
+      if (isset($id) && $id) {
27 27
         
28 28
         //get entity with relations for primary dependency
29 29
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
@@ -39,15 +39,15 @@  discard block
 block discarded – undo
39 39
         $secondary_ids = [];
40 40
         
41 41
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
42
-        if( old($primary_dependency['name']) ) {
43
-          foreach( old($primary_dependency['name']) as $primary_item ){
44
-            foreach($dependencyArray[$primary_item] as $second_item ){
42
+        if (old($primary_dependency['name'])) {
43
+          foreach (old($primary_dependency['name']) as $primary_item) {
44
+            foreach ($dependencyArray[$primary_item] as $second_item) {
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47 47
           }
48
-        }else{ //create dependecies from relation if not from validate error
49
-          foreach( $primary_array as $primary_item ){
50
-            foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
48
+        } else { //create dependecies from relation if not from validate error
49
+          foreach ($primary_array as $primary_item) {
50
+            foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
52 52
             }
53 53
           }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47 47
           }
48
-        }else{ //create dependecies from relation if not from validate error
48
+        } else{ //create dependecies from relation if not from validate error
49 49
           foreach( $primary_array as $primary_item ){
50 50
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
Please login to merge, or discard this patch.
Indentation   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -2,34 +2,34 @@  discard block
 block discarded – undo
2 2
 <div class="form-group col-md-12 checklist_dependency"  data-entity ="{{ $field['field_unique_name'] }}" @include('crud::inc.field_wrapper_attributes')>
3 3
     <label>{!! $field['label'] !!}</label>
4 4
     <?php
5
-      $entity_model = $crud->getModel();
5
+        $entity_model = $crud->getModel();
6 6
 
7
-      //short name for dependency fields
8
-      $primary_dependency = $field['subfields']['primary'];
9
-      $secondary_dependency = $field['subfields']['secondary'];
7
+        //short name for dependency fields
8
+        $primary_dependency = $field['subfields']['primary'];
9
+        $secondary_dependency = $field['subfields']['secondary'];
10 10
 
11 11
 
12
-      //all items with relation
13
-      $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
12
+        //all items with relation
13
+        $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
14 14
 
15
-      $dependencyArray = [];
15
+        $dependencyArray = [];
16 16
 
17
-      //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
-      foreach($dependencies as $primary){
19
-          $dependencyArray[$primary->id] = [];
17
+        //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
+        foreach($dependencies as $primary){
19
+            $dependencyArray[$primary->id] = [];
20 20
         foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
21 21
             $dependencyArray[$primary->id][] = $secondary->id;
22 22
         }
23
-      }
23
+        }
24 24
 
25
-      //for update form, get initial state of the entity
26
-      if( isset($id) && $id ){
25
+        //for update form, get initial state of the entity
26
+        if( isset($id) && $id ){
27 27
 
28 28
         //get entity with relations for primary dependency
29 29
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
30
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
-          ->where('id', $id)
32
-          ->first();
30
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
+            ->where('id', $id)
32
+            ->first();
33 33
 
34 34
         $secondaries_from_primary = [];
35 35
 
@@ -40,22 +40,22 @@  discard block
 block discarded – undo
40 40
 
41 41
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
42 42
         if( old($primary_dependency['name']) ) {
43
-          foreach( old($primary_dependency['name']) as $primary_item ){
43
+            foreach( old($primary_dependency['name']) as $primary_item ){
44 44
             foreach($dependencyArray[$primary_item] as $second_item ){
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47
-          }
47
+            }
48 48
         }else{ //create dependecies from relation if not from validate error
49
-          foreach( $primary_array as $primary_item ){
49
+            foreach( $primary_array as $primary_item ){
50 50
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
52 52
             }
53
-          }
53
+            }
54
+        }
54 55
         }
55
-      }
56 56
 
57
-      //json encode of dependency matrix
58
-      $dependencyJson = json_encode($dependencyArray);
57
+        //json encode of dependency matrix
58
+        $dependencyJson = json_encode($dependencyArray);
59 59
     ?>
60 60
     <script>
61 61
         var  {{ $field['field_unique_name'] }} = {!! $dependencyJson !!};
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 
67 67
     private function registerCRUD()
68 68
     {
69
-        $this->app->bind('CRUD', function ($app) {
69
+        $this->app->bind('CRUD', function($app) {
70 70
             return new CRUD($app);
71 71
         });
72 72
     }
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -89,33 +89,33 @@
 block discarded – undo
89 89
         Route::post($name.'/search', [
90 90
             'as' => 'crud.'.$name.'.search',
91 91
             'uses' => $controller.'@search',
92
-          ]);
92
+            ]);
93 93
         Route::get($name.'/reorder', [
94 94
             'as' => 'crud.'.$name.'.reorder',
95 95
             'uses' => $controller.'@reorder',
96
-          ]);
96
+            ]);
97 97
         Route::post($name.'/reorder', [
98 98
             'as' => 'crud.'.$name.'.save.reorder',
99 99
             'uses' => $controller.'@saveReorder',
100
-          ]);
100
+            ]);
101 101
         Route::get($name.'/{id}/details', [
102 102
             'as' => 'crud.'.$name.'.showDetailsRow',
103 103
             'uses' => $controller.'@showDetailsRow',
104
-          ]);
104
+            ]);
105 105
         Route::get($name.'/{id}/translate/{lang}', [
106 106
             'as' => 'crud.'.$name.'.translateItem',
107 107
             'uses' => $controller.'@translateItem',
108
-          ]);
108
+            ]);
109 109
 
110 110
         Route::get($name.'/{id}/revisions', [
111 111
             'as' => 'crud.'.$name.'.listRevisions',
112 112
             'uses' => $controller.'@listRevisions',
113
-          ]);
113
+            ]);
114 114
 
115 115
         Route::post($name.'/{id}/revisions/{revisionId}/restore', [
116 116
             'as' => 'crud.'.$name.'.restoreRevision',
117 117
             'uses' => $controller.'@restoreRevision',
118
-          ]);
118
+            ]);
119 119
 
120 120
         $options_with_default_route_names = array_merge([
121 121
             'names' => [
Please login to merge, or discard this patch.
src/CrudTrait.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      *
70 70
      * @param array $columns - the database columns that contain the JSONs
71 71
      *
72
-     * @return Model
72
+     * @return CrudTrait
73 73
      */
74 74
     public function withFakes($columns = [])
75 75
     {
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         // register the enum column type, because Doctrine doesn't support it
36 36
         DB::connection()->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
37 37
 
38
-        return ! DB::connection()->getDoctrineColumn($instance->getTable(), $column_name)->getNotnull();
38
+        return !DB::connection()->getDoctrineColumn($instance->getTable(), $column_name)->getNotnull();
39 39
     }
40 40
 
41 41
     /*
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         foreach ($columns as $key => $column) {
55 55
             $column_contents = $this->{$column};
56 56
 
57
-            if (! is_object($this->{$column})) {
57
+            if (!is_object($this->{$column})) {
58 58
                 $column_contents = json_decode($this->{$column});
59 59
             }
60 60
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     {
78 78
         $model = '\\'.get_class($this);
79 79
 
80
-        if (! count($columns)) {
80
+        if (!count($columns)) {
81 81
             $columns = (property_exists($model, 'fakeColumns')) ? $this->fakeColumns : ['extras'];
82 82
         }
83 83
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             $attribute_value = (array) $this->{$attribute_name};
168 168
             foreach ($files_to_clear as $key => $filename) {
169 169
                 \Storage::disk($disk)->delete($filename);
170
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
170
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
171 171
                     return $value != $filename;
172 172
                 });
173 173
             }
@@ -211,17 +211,17 @@  discard block
 block discarded – undo
211 211
      */
212 212
     public function uploadImageToDisk($value, $attribute_name, $disk, $destination_path, $variations = null)
213 213
     {
214
-        if (! $variations || ! is_array($variations)) {
214
+        if (!$variations || !is_array($variations)) {
215 215
             $variations = ['original' => null, 'thumb' => [150, 150]];
216 216
         }
217 217
 
218 218
         //Needed for the original image
219
-        if (! array_key_exists('original', $variations)) {
219
+        if (!array_key_exists('original', $variations)) {
220 220
             $variations['original'] = null;
221 221
         }
222 222
 
223 223
         //Needed for admin thumbnails
224
-        if (! array_key_exists('thumb', $variations)) {
224
+        if (!array_key_exists('thumb', $variations)) {
225 225
             $variations['thumb'] = [150, 150];
226 226
         }
227 227
 
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
                         $height = $dimensions[1];
283 283
 
284 284
                         if ($img->width() > $width || $img->height() > $height) {
285
-                            $img->resize($width, $height, function ($constraint) {
285
+                            $img->resize($width, $height, function($constraint) {
286 286
                                 $constraint->aspectRatio();
287 287
                             })
288 288
                             ->save($disk_root.'/'.$variant_file);
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
             $img = \Intervention\Image\ImageManagerStatic::make($value);
307 307
             $new_file_name = md5($value.time());
308 308
 
309
-            if (! \Illuminate\Support\Facades\File::exists($disk_root.'/'.trim($destination_path, '/'))) {
309
+            if (!\Illuminate\Support\Facades\File::exists($disk_root.'/'.trim($destination_path, '/'))) {
310 310
                 \Illuminate\Support\Facades\File::makeDirectory($disk_root.'/'.trim($destination_path, '/'), 0775, true);
311 311
             }
312 312
 
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
                     $height = $dimensions[1];
341 341
 
342 342
                     if ($img->width() > $width || $img->height() > $height) {
343
-                        $img->resize($width, $height, function ($constraint) {
343
+                        $img->resize($width, $height, function($constraint) {
344 344
                             $constraint->aspectRatio();
345 345
                         })
346 346
                         ->save($disk_root.'/'.$variant_file);
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
     {
371 371
         $image = $this->attributes['image'];
372 372
         $url = null;
373
-        if (! empty($image)) {
373
+        if (!empty($image)) {
374 374
             $image_variant = str_replace('-original', '-'.$variant, $image);
375 375
 
376 376
             if ($disk) {
Please login to merge, or discard this patch.
src/resources/views-elfinder/filepicker.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     <!-- Include jQuery, jQuery UI, elFinder (REQUIRED) -->
27 27
 
28 28
     <?php
29
-    $mimeTypes = implode(',', array_map(function ($t) {
29
+    $mimeTypes = implode(',', array_map(function($t) {
30 30
         return "'".$t."'";
31 31
     }, explode(',', $type)));
32 32
     ?>
Please login to merge, or discard this patch.
src/PanelTraits/Update.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 
44 44
         foreach ($fields as $k => $field) {
45 45
             // set the value
46
-            if (! isset($fields[$k]['value'])) {
46
+            if (!isset($fields[$k]['value'])) {
47 47
                 if (isset($field['subfields'])) {
48 48
                     $fields[$k]['value'] = [];
49 49
                     foreach ($field['subfields'] as $key => $subfield) {
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
         }
28 28
 
29 29
         // if the label is missing, we should set it
30
-        if (! isset($complete_field_array['label'])) {
30
+        if (!isset($complete_field_array['label'])) {
31 31
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
32 32
         }
33 33
 
34 34
         // if the field type is missing, we should set it
35
-        if (! isset($complete_field_array['type'])) {
35
+        if (!isset($complete_field_array['type'])) {
36 36
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
37 37
         }
38 38
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function removeFields($array_of_names, $form = 'both')
96 96
     {
97
-        if (! empty($array_of_names)) {
97
+        if (!empty($array_of_names)) {
98 98
             foreach ($array_of_names as $name) {
99 99
                 $this->removeField($name, $form);
100 100
             }
Please login to merge, or discard this patch.
src/PanelTraits/Columns.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     public function addColumn($column)
56 56
     {
57 57
         // if a string was passed, not an array, change it to an array
58
-        if (! is_array($column)) {
58
+        if (!is_array($column)) {
59 59
             $column = ['name' => $column];
60 60
         }
61 61
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      */
107 107
     public function addDefaultLabel($array)
108 108
     {
109
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
109
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
110 110
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
111 111
 
112 112
             return $array;
@@ -137,8 +137,8 @@  discard block
 block discarded – undo
137 137
 
138 138
     public function remove($entity, $fields)
139 139
     {
140
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
141
-            return ! in_array($field['name'], (array) $fields);
140
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
141
+            return !in_array($field['name'], (array) $fields);
142 142
         }));
143 143
     }
144 144
 
Please login to merge, or discard this patch.
src/PanelTraits/Access.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public function hasAccess($permission)
33 33
     {
34
-        if (! in_array($permission, $this->access)) {
34
+        if (!in_array($permission, $this->access)) {
35 35
             return false;
36 36
         }
37 37
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     public function hasAccessToAll($permission_array)
67 67
     {
68 68
         foreach ($permission_array as $key => $permission) {
69
-            if (! in_array($permission, $this->access)) {
69
+            if (!in_array($permission, $this->access)) {
70 70
                 return false;
71 71
             }
72 72
         }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public function hasAccessOrFail($permission)
85 85
     {
86
-        if (! in_array($permission, $this->access)) {
86
+        if (!in_array($permission, $this->access)) {
87 87
             abort(403, trans('backpack::crud.unauthorized_access'));
88 88
         }
89 89
     }
Please login to merge, or discard this patch.