Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — CrudButton-fixees ( 8e21aa...0a7a26 )
by Pedro
36:42 queued 21:25
created
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
     private function getValidationRulesFromFieldsAndSubfields($fields)
47 47
     {
48 48
         $rules = collect($fields)
49
-            ->filter(function ($value, $key) {
49
+            ->filter(function($value, $key) {
50 50
                 // only keep fields where 'validationRules' OR there are subfields
51 51
                 return array_key_exists('validationRules', $value) || array_key_exists('subfields', $value);
52
-            })->map(function ($item, $key) {
52
+            })->map(function($item, $key) {
53 53
                 $validationRules = [];
54 54
                 // only keep the rules, not the entire field definition
55 55
                 if (isset($item['validationRules'])) {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
                 }
58 58
                 // add validation rules for subfields
59 59
                 if (array_key_exists('subfields', $item)) {
60
-                    $subfieldsWithValidation = array_filter($item['subfields'], function ($subfield) {
60
+                    $subfieldsWithValidation = array_filter($item['subfields'], function($subfield) {
61 61
                         return array_key_exists('validationRules', $subfield);
62 62
                     });
63 63
 
@@ -82,10 +82,10 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $messages = [];
84 84
         collect($fields)
85
-            ->filter(function ($value, $key) {
85
+            ->filter(function($value, $key) {
86 86
                 // only keep fields where 'validationMessages' OR there are subfields
87 87
                 return array_key_exists('validationMessages', $value) || array_key_exists('subfields', $value);
88
-            })->each(function ($item, $key) use (&$messages) {
88
+            })->each(function($item, $key) use (&$messages) {
89 89
                 if (isset($item['validationMessages'])) {
90 90
                     foreach ($item['validationMessages'] as $rule => $message) {
91 91
                         $messages[$key.'.'.$rule] = $message;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
                 }
94 94
                 // add messages from subfields
95 95
                 if (array_key_exists('subfields', $item)) {
96
-                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function ($subfield) {
96
+                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function($subfield) {
97 97
                         return array_key_exists('validationRules', $subfield);
98 98
                     });
99 99
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      */
130 130
     public function setValidation($classOrRulesArray = false, $messages = [])
131 131
     {
132
-        if (! $classOrRulesArray) {
132
+        if (!$classOrRulesArray) {
133 133
             $this->setValidationFromFields();
134 134
         } elseif (is_array($classOrRulesArray)) {
135 135
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
             return $this->checkRequestValidity($extendedRules, $extendedMessages, $formRequest);
211 211
         }
212 212
 
213
-        return ! empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
213
+        return !empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
214 214
     }
215 215
 
216 216
     /**
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
     {
226 226
         $extendedRules = [];
227 227
         $requestRules = $this->getRequestRulesAsArray($request);
228
-        $rules = array_map(function ($ruleDefinition) {
228
+        $rules = array_map(function($ruleDefinition) {
229 229
             return is_array($ruleDefinition) ? $ruleDefinition : explode('|', $ruleDefinition);
230 230
         }, $rules);
231 231
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function isRequired($inputKey)
324 324
     {
325
-        if (! $this->hasOperationSetting('requiredFields')) {
325
+        if (!$this->hasOperationSetting('requiredFields')) {
326 326
             return false;
327 327
         }
328 328
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
     {
344 344
         [$rules, $messages] = $this->getValidationRulesAndMessagesFromField($field, $parent);
345 345
 
346
-        if (! empty($rules)) {
346
+        if (!empty($rules)) {
347 347
             $this->setValidation($rules, $messages);
348 348
         }
349 349
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             'password' => 'test',
37 37
         ]);
38 38
 
39
-        $request->setRouteResolver(function () use ($request) {
39
+        $request->setRouteResolver(function() use ($request) {
40 40
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
41 41
         });
42 42
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             'email'    => '',
77 77
         ]);
78 78
 
79
-        $request->setRouteResolver(function () use ($request) {
79
+        $request->setRouteResolver(function() use ($request) {
80 80
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
81 81
         });
82 82
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             'password' => 'test',
117 117
         ]);
118 118
 
119
-        $request->setRouteResolver(function () use ($request) {
119
+        $request->setRouteResolver(function() use ($request) {
120 120
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
121 121
         });
122 122
 
Please login to merge, or discard this patch.
tests/BaseTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
             (array) config('backpack.base.middleware_key', 'admin'),
23 23
             'prefix'     => config('backpack.base.route_prefix', 'admin'),
24 24
         ],
25
-            function () {
25
+            function() {
26 26
                 Route::crud('users', 'Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController');
27 27
             }
28 28
         );
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         //
33 33
         // It's done inside a middleware closure in order to have
34 34
         // the complete request inside the CrudPanel object.
35
-        $this->middleware(function ($request, $next) {
35
+        $this->middleware(function($request, $next) {
36 36
             $this->crud = app('crud');
37 37
 
38 38
             $this->crud->setRequest($request);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     protected function setupConfigurationForCurrentOperation()
97 97
     {
98 98
         $operationName = $this->crud->getCurrentOperation();
99
-        if (! $operationName) {
99
+        if (!$operationName) {
100 100
             return;
101 101
         }
102 102
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Query.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function customOrderBy($column, $columnDirection = 'asc')
101 101
     {
102
-        if (! isset($column['orderLogic'])) {
102
+        if (!isset($column['orderLogic'])) {
103 103
             return $this->query;
104 104
         }
105 105
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function getTotalQueryCount()
191 191
     {
192
-        if (! $this->getOperationSetting('showEntryCount')) {
192
+        if (!$this->getOperationSetting('showEntryCount')) {
193 193
             return 0;
194 194
         }
195 195
 
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      */
229 229
     private function getCountFromQuery(Builder $query)
230 230
     {
231
-        if (! $this->driverIsSql()) {
231
+        if (!$this->driverIsSql()) {
232 232
             return $query->count();
233 233
         }
234 234
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         $expressionColumns = [];
248 248
 
249 249
         foreach ($crudQuery->columns ?? [] as $column) {
250
-            if (! is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
250
+            if (!is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
251 251
                 $expressionColumns[] = $column;
252 252
             }
253 253
         }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasEnumFields.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
 
24 24
         try {
25 25
             $select = app()->version() < 10 ?
26
-                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"') :
27
-                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"')->getValue($connection->getQueryGrammar());
26
+                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"') : DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"')->getValue($connection->getQueryGrammar());
28 27
 
29 28
             $type = $connection->select($select)[0]->Type;
30 29
         } catch (\Exception $e) {
Please login to merge, or discard this patch.
src/resources/views/crud/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
     <?php
29 29
     function tree_element($entry, $key, $all_entries, $crud)
30 30
     {
31
-        if (! isset($entry->tree_element_shown)) {
31
+        if (!isset($entry->tree_element_shown)) {
32 32
             // mark the element as shown
33 33
             $all_entries[$key]->tree_element_shown = true;
34 34
             $entry->tree_element_shown = true;
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
                 <ol class="sortable mt-0">
72 72
                     <?php
73 73
                     $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
74
-    $root_entries = $all_entries->filter(function ($item) {
74
+    $root_entries = $all_entries->filter(function($item) {
75 75
         return $item->parent_id == 0;
76 76
     });
77 77
     foreach ($root_entries as $key => $entry) {
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
         // we get the first column from database
64 64
         // that is NOT indexed (usually primary, foreign keys)
65 65
         foreach ($columns as $columnName => $columnProperties) {
66
-            if (! in_array($columnName, $indexedColumns)) {
66
+            if (!in_array($columnName, $indexedColumns)) {
67 67
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
68 68
                 if (strpos($columnName, '_id') !== false) {
69 69
                     continue;
Please login to merge, or discard this patch.
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         'middleware' => config('backpack.base.web_middleware', 'web'),
19 19
         'prefix'     => config('backpack.base.route_prefix'),
20 20
     ],
21
-    function () {
21
+    function() {
22 22
         // if not otherwise configured, setup the auth routes
23 23
         if (config('backpack.base.setup_auth_routes')) {
24 24
             // Authentication Routes...
Please login to merge, or discard this patch.