We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -326,8 +326,6 @@ discard block |
||
326 | 326 | * Check if the create/update form has upload fields. |
327 | 327 | * Upload fields are the ones that have "upload" => true defined on them. |
328 | 328 | * |
329 | - * @param string $form create/update/both - defaults to 'both' |
|
330 | - * @param bool|int $id id of the entity - defaults to false |
|
331 | 329 | * |
332 | 330 | * @return bool |
333 | 331 | */ |
@@ -358,7 +356,7 @@ discard block |
||
358 | 356 | /** |
359 | 357 | * Set an array of field type names as already loaded for the current operation. |
360 | 358 | * |
361 | - * @param array $fieldTypes |
|
359 | + * @param string[] $fieldTypes |
|
362 | 360 | */ |
363 | 361 | public function setLoadedFieldTypes($fieldTypes) |
364 | 362 | { |
@@ -369,7 +367,7 @@ discard block |
||
369 | 367 | * Get a namespaced version of the field type name. |
370 | 368 | * Appends the 'view_namespace' attribute of the field to the `type', using dot notation. |
371 | 369 | * |
372 | - * @param mixed $field |
|
370 | + * @param string $field |
|
373 | 371 | * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text' |
374 | 372 | */ |
375 | 373 | public function getFieldTypeWithNamespace($field) |
@@ -55,7 +55,7 @@ discard block |
||
55 | 55 | */ |
56 | 56 | public function afterField($targetFieldName) |
57 | 57 | { |
58 | - $this->transformFields(function ($fields) use ($targetFieldName) { |
|
58 | + $this->transformFields(function($fields) use ($targetFieldName) { |
|
59 | 59 | return $this->moveField($fields, $targetFieldName, false); |
60 | 60 | }); |
61 | 61 | } |
@@ -67,7 +67,7 @@ discard block |
||
67 | 67 | */ |
68 | 68 | public function beforeField($targetFieldName) |
69 | 69 | { |
70 | - $this->transformFields(function ($fields) use ($targetFieldName) { |
|
70 | + $this->transformFields(function($fields) use ($targetFieldName) { |
|
71 | 71 | return $this->moveField($fields, $targetFieldName, true); |
72 | 72 | }); |
73 | 73 | } |
@@ -79,7 +79,7 @@ discard block |
||
79 | 79 | */ |
80 | 80 | public function removeField($name) |
81 | 81 | { |
82 | - $this->transformFields(function ($fields) use ($name) { |
|
82 | + $this->transformFields(function($fields) use ($name) { |
|
83 | 83 | array_forget($fields, $name); |
84 | 84 | |
85 | 85 | return $fields; |
@@ -93,7 +93,7 @@ discard block |
||
93 | 93 | */ |
94 | 94 | public function removeFields($array_of_names) |
95 | 95 | { |
96 | - if (! empty($array_of_names)) { |
|
96 | + if (!empty($array_of_names)) { |
|
97 | 97 | foreach ($array_of_names as $name) { |
98 | 98 | $this->removeField($name); |
99 | 99 | } |
@@ -106,7 +106,7 @@ discard block |
||
106 | 106 | public function removeAllFields() |
107 | 107 | { |
108 | 108 | $current_fields = $this->getCurrentFields(); |
109 | - if (! empty($current_fields)) { |
|
109 | + if (!empty($current_fields)) { |
|
110 | 110 | foreach ($current_fields as $field) { |
111 | 111 | $this->removeField($field['name']); |
112 | 112 | } |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | $jsonCastables = ['array', 'object', 'json']; |
181 | 181 | $fieldCasting = $casted_attributes[$field['name']]; |
182 | 182 | |
183 | - if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) { |
|
183 | + if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) { |
|
184 | 184 | try { |
185 | 185 | $data[$field['name']] = json_decode($data[$field['name']]); |
186 | 186 | } catch (\Exception $e) { |
@@ -209,7 +209,7 @@ discard block |
||
209 | 209 | */ |
210 | 210 | public function orderFields($order) |
211 | 211 | { |
212 | - $this->transformFields(function ($fields) use ($order) { |
|
212 | + $this->transformFields(function($fields) use ($order) { |
|
213 | 213 | return $this->applyOrderToFields($fields, $order); |
214 | 214 | }); |
215 | 215 | } |
@@ -236,7 +236,7 @@ discard block |
||
236 | 236 | public function hasUploadFields() |
237 | 237 | { |
238 | 238 | $fields = $this->getFields(); |
239 | - $upload_fields = array_where($fields, function ($value, $key) { |
|
239 | + $upload_fields = array_where($fields, function($value, $key) { |
|
240 | 240 | return isset($value['upload']) && $value['upload'] == true; |
241 | 241 | }); |
242 | 242 | |
@@ -299,7 +299,7 @@ discard block |
||
299 | 299 | $alreadyLoaded = $this->getLoadedFieldTypes(); |
300 | 300 | $type = $this->getFieldTypeWithNamespace($field); |
301 | 301 | |
302 | - if (! in_array($type, $this->getLoadedFieldTypes(), true)) { |
|
302 | + if (!in_array($type, $this->getLoadedFieldTypes(), true)) { |
|
303 | 303 | $alreadyLoaded[] = $type; |
304 | 304 | $this->setLoadedFieldTypes($alreadyLoaded); |
305 | 305 | |
@@ -340,7 +340,7 @@ discard block |
||
340 | 340 | */ |
341 | 341 | public function fieldTypeNotLoaded($field) |
342 | 342 | { |
343 | - return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes()); |
|
343 | + return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes()); |
|
344 | 344 | } |
345 | 345 | |
346 | 346 | /** |
@@ -57,7 +57,7 @@ discard block |
||
57 | 57 | */ |
58 | 58 | public function getInlineCreateModal() |
59 | 59 | { |
60 | - if (! request()->has('entity')) { |
|
60 | + if (!request()->has('entity')) { |
|
61 | 61 | abort(400, 'No "entity" inside the request.'); |
62 | 62 | } |
63 | 63 | |
@@ -80,17 +80,17 @@ discard block |
||
80 | 80 | */ |
81 | 81 | public function inlineRefreshOptions() |
82 | 82 | { |
83 | - if (! request()->has('field')) { |
|
83 | + if (!request()->has('field')) { |
|
84 | 84 | abort(400, 'No "field" inside the request.'); |
85 | 85 | } |
86 | 86 | |
87 | 87 | $field = $this->crud->fields()[request()->get('field')]; |
88 | 88 | $options = []; |
89 | 89 | |
90 | - if (! empty($field)) { |
|
90 | + if (!empty($field)) { |
|
91 | 91 | $relatedModelInstance = new $field['model'](); |
92 | 92 | |
93 | - if (! isset($field['options'])) { |
|
93 | + if (!isset($field['options'])) { |
|
94 | 94 | $options = $field['model']::all()->pluck($field['attribute'], $relatedModelInstance->getKeyName()); |
95 | 95 | } else { |
96 | 96 | $options = call_user_func($field['options'], $field['model']::query()->pluck($field['attribute'], $relatedModelInstance->getKeyName())); |
@@ -89,7 +89,7 @@ |
||
89 | 89 | /** |
90 | 90 | * Infer a field type, judging from the database column type. |
91 | 91 | * |
92 | - * @param string $field Field name. |
|
92 | + * @param string $fieldName Field name. |
|
93 | 93 | * |
94 | 94 | * @return string Field type. |
95 | 95 | */ |
@@ -12,12 +12,12 @@ discard block |
||
12 | 12 | */ |
13 | 13 | public function setFromDb() |
14 | 14 | { |
15 | - if (! $this->driverIsMongoDb()) { |
|
15 | + if (!$this->driverIsMongoDb()) { |
|
16 | 16 | $this->setDoctrineTypesMapping(); |
17 | 17 | $this->getDbColumnTypes(); |
18 | 18 | } |
19 | 19 | |
20 | - array_map(function ($field) { |
|
20 | + array_map(function($field) { |
|
21 | 21 | $new_field = [ |
22 | 22 | 'name' => $field, |
23 | 23 | 'label' => $this->makeLabel($field), |
@@ -29,11 +29,11 @@ discard block |
||
29 | 29 | 'autoset' => true, |
30 | 30 | ]; |
31 | 31 | |
32 | - if (! isset($this->fields()[$field])) { |
|
32 | + if (!isset($this->fields()[$field])) { |
|
33 | 33 | $this->addField($new_field); |
34 | 34 | } |
35 | 35 | |
36 | - if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) { |
|
36 | + if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) { |
|
37 | 37 | $this->addColumn([ |
38 | 38 | 'name' => $field, |
39 | 39 | 'label' => $this->makeLabel($field), |
@@ -105,7 +105,7 @@ discard block |
||
105 | 105 | |
106 | 106 | $dbColumnTypes = $this->getDbColumnTypes(); |
107 | 107 | |
108 | - if (! isset($dbColumnTypes[$fieldName])) { |
|
108 | + if (!isset($dbColumnTypes[$fieldName])) { |
|
109 | 109 | return 'text'; |
110 | 110 | } |
111 | 111 | |
@@ -163,7 +163,7 @@ discard block |
||
163 | 163 | $types = ['enum' => 'string']; |
164 | 164 | $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform(); |
165 | 165 | foreach ($types as $type_key => $type_value) { |
166 | - if (! $platform->hasDoctrineTypeMappingFor($type_key)) { |
|
166 | + if (!$platform->hasDoctrineTypeMappingFor($type_key)) { |
|
167 | 167 | $platform->registerDoctrineTypeMapping($type_key, $type_value); |
168 | 168 | } |
169 | 169 | } |
@@ -222,7 +222,7 @@ discard block |
||
222 | 222 | // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model |
223 | 223 | $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable()); |
224 | 224 | |
225 | - if (! empty($fillable)) { |
|
225 | + if (!empty($fillable)) { |
|
226 | 226 | $columns = array_intersect($columns, $fillable); |
227 | 227 | } |
228 | 228 | } |
@@ -67,7 +67,7 @@ |
||
67 | 67 | /** |
68 | 68 | * Gets the relation data from the method in the model. |
69 | 69 | * |
70 | - * @param ReflectionMethod $method |
|
70 | + * @param \ReflectionMethod $method |
|
71 | 71 | * @return array |
72 | 72 | */ |
73 | 73 | public function inferFieldAttributesFromRelationship($method) |
@@ -23,7 +23,7 @@ discard block |
||
23 | 23 | } |
24 | 24 | |
25 | 25 | if (in_array($fieldName, array_column($relations, 'name'))) { |
26 | - return array_filter($relations, function ($arr) use ($fieldName) { |
|
26 | + return array_filter($relations, function($arr) use ($fieldName) { |
|
27 | 27 | if (isset($arr['name'])) { |
28 | 28 | return $arr['name'] == $fieldName; |
29 | 29 | } |
@@ -72,7 +72,7 @@ discard block |
||
72 | 72 | */ |
73 | 73 | public function inferFieldAttributesFromRelationship($method) |
74 | 74 | { |
75 | - if (! method_exists($this->model, $method)) { |
|
75 | + if (!method_exists($this->model, $method)) { |
|
76 | 76 | return false; |
77 | 77 | } |
78 | 78 |
@@ -39,7 +39,7 @@ discard block |
||
39 | 39 | return ['name' => $field]; |
40 | 40 | } |
41 | 41 | |
42 | - if (is_array($field) && ! isset($field['name'])) { |
|
42 | + if (is_array($field) && !isset($field['name'])) { |
|
43 | 43 | abort(500, 'All fields must have their name defined'); |
44 | 44 | } |
45 | 45 | |
@@ -92,7 +92,7 @@ discard block |
||
92 | 92 | protected function makeSureFieldHasRelationshipData($field) |
93 | 93 | { |
94 | 94 | // only do this if "entity" is defined on the field |
95 | - if (! isset($field['entity'])) { |
|
95 | + if (!isset($field['entity'])) { |
|
96 | 96 | return $field; |
97 | 97 | } |
98 | 98 | |
@@ -111,7 +111,7 @@ discard block |
||
111 | 111 | { |
112 | 112 | // if this is a relation type field and no corresponding model was specified, |
113 | 113 | // get it from the relation method defined in the main model |
114 | - if (isset($field['entity']) && ! isset($field['model'])) { |
|
114 | + if (isset($field['entity']) && !isset($field['model'])) { |
|
115 | 115 | $field['model'] = $this->getRelationModel($field['entity']); |
116 | 116 | } |
117 | 117 | |
@@ -127,7 +127,7 @@ discard block |
||
127 | 127 | */ |
128 | 128 | protected function makeSureFieldHasLabel($field) |
129 | 129 | { |
130 | - if (! isset($field['label'])) { |
|
130 | + if (!isset($field['label'])) { |
|
131 | 131 | $name = is_array($field['name']) ? $field['name'][0] : $field['name']; |
132 | 132 | $name = str_replace('_id', '', $name); |
133 | 133 | $field['label'] = mb_ucfirst(str_replace('_', ' ', $name)); |
@@ -145,7 +145,7 @@ discard block |
||
145 | 145 | */ |
146 | 146 | protected function makeSureFieldHasType($field) |
147 | 147 | { |
148 | - if (! isset($field['type'])) { |
|
148 | + if (!isset($field['type'])) { |
|
149 | 149 | $field['type'] = $this->inferFieldTypeFromDbColumnType($field['name']); |
150 | 150 | } |
151 | 151 | |
@@ -162,7 +162,7 @@ discard block |
||
162 | 162 | { |
163 | 163 | // if a tab was mentioned, we should enable it |
164 | 164 | if (isset($field['tab'])) { |
165 | - if (! $this->tabsEnabled()) { |
|
165 | + if (!$this->tabsEnabled()) { |
|
166 | 166 | $this->enableTabs(); |
167 | 167 | } |
168 | 168 | } |