View GitHub Repository CRUD

Schedule Inspection
Subscribe

Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#3451)
by
unknown
10:32
created
Status
Category
Toggle Patches
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
     {
42 42 
         $this->crud->allowAccess('list');
43 43
44 
-        $this->crud->operation('list', function () {
44 
+        $this->crud->operation('list', function() {
45 45 
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46 
         });
47 47 
     }
 
@@ -116,12 +116,12 @@  discard block
 
 block discarded – undo
116 116 
         $table = $this->crud->model->getTable();
117 117 
         $key = $this->crud->model->getKeyName();
118 118
119 
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
119 
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
120 120 
             return (isset($item['column']) && $item['column'] === $key)
121 121 
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
122 122 
         });
123 123
124 
-        if (! $hasOrderByPrimaryKey) {
124 
+        if (!$hasOrderByPrimaryKey) {
125 125 
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
126 126 
         }
127 127
Please login to merge, or discard this patch.