Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2356)
by Cristian
07:46
created
src/app/Library/CrudPanel/Traits/SaveActions.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,6 @@
 block discarded – undo
170 170
     /**
171 171
      * Allow the developer to unset all save actions.
172 172
      *
173
-     * @param string $saveAction
174 173
      * @return void
175 174
      */
176 175
     public function forgetAllSaveActions()
Please login to merge, or discard this patch.
Spacing   +13 added lines, -14 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->availableSaveActions, function ($arr) use ($order) {
50
+        return array_filter($this->availableSaveActions, function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
         if (is_array($saveAction)) {
94 94
             //check for some mandatory fields
95 95
             $saveAction['name'] ?? abort(500, 'Please define save action name.');
96
-            $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
96
+            $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
97 97
                 return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
98 98
             };
99 99
             $saveAction['permissions'] = $saveAction['permissions'] ?? true;
@@ -112,11 +112,11 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function reorderSaveActions($wantedOrder)
114 114
     {
115
-        if (! empty($this->availableSaveActions)) {
115
+        if (!empty($this->availableSaveActions)) {
116 116
             $lastOrder = max(array_column($this->availableSaveActions, 'order'));
117 117
             foreach ($this->availableSaveActions as &$sv) {
118 118
                 if ($wantedOrder == $sv['order']) {
119
-                    if (empty(array_filter($this->availableSaveActions, function ($arr) {
119
+                    if (empty(array_filter($this->availableSaveActions, function($arr) {
120 120
                         $arr['order'] == 1;
121 121
                     }))) {
122 122
                         $sv['order'] = 1;
@@ -241,12 +241,12 @@  discard block
 block discarded – undo
241 241
         }
242 242
 
243 243
         //get only passed permissions
244
-        $saveOptions = array_filter($this->availableSaveActions, function ($saveOption) {
244
+        $saveOptions = array_filter($this->availableSaveActions, function($saveOption) {
245 245
             return $saveOption['permissions'] == true;
246 246
         }, ARRAY_FILTER_USE_BOTH);
247 247
 
248 248
         //sort by order
249
-        uasort($saveOptions, function ($a, $b) {
249
+        uasort($saveOptions, function($a, $b) {
250 250
             return $a['order'] <=> $b['order'];
251 251
         });
252 252
 
@@ -285,8 +285,7 @@  discard block
 block discarded – undo
285 285
      */
286 286
     public function setSaveAction($forceSaveAction = null)
287 287
     {
288
-        $saveAction = $forceSaveAction ?:
289
-            \Request::input('save_action', $this->getFallBackSaveAction());
288
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
290 289
 
291 290
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
292 291
 
@@ -341,10 +340,10 @@  discard block
 block discarded – undo
341 340
         $defaultSaveActions = [
342 341
             [
343 342
                 'name' => 'save_and_back',
344
-                'permissions' => function ($crud) {
343
+                'permissions' => function($crud) {
345 344
                     return $crud->hasAccess('list');
346 345
                 },
347
-                'redirect' => function ($crud, $request, $itemId = null) {
346
+                'redirect' => function($crud, $request, $itemId = null) {
348 347
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
349 348
                 },
350 349
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
@@ -352,10 +351,10 @@  discard block
 block discarded – undo
352 351
             ],
353 352
             [
354 353
                 'name' => 'save_and_edit',
355
-                'permissions' => function ($crud) {
354
+                'permissions' => function($crud) {
356 355
                     return $crud->hasAccess('update');
357 356
                 },
358
-                'redirect' => function ($crud, $request, $itemId = null) {
357
+                'redirect' => function($crud, $request, $itemId = null) {
359 358
                     $itemId = $itemId ?: $request->input('id');
360 359
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
361 360
                     if ($request->has('locale')) {
@@ -372,10 +371,10 @@  discard block
 block discarded – undo
372 371
             ],
373 372
             [
374 373
                 'name' => 'save_and_new',
375
-                'permissions' => function ($crud) {
374
+                'permissions' => function($crud) {
376 375
                     return $crud->hasAccess('create');
377 376
                 },
378
-                'redirect' => function ($crud, $request, $itemId = null) {
377
+                'redirect' => function($crud, $request, $itemId = null) {
379 378
                     return $this->route.'/create';
380 379
                 },
381 380
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.