Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by
unknown
13:58
created
database/migrations/2017_09_08_000001_create_account_details_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('account_details', function (Blueprint $table) {
16
+        Schema::create('account_details', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('user_id')->unsigned();
19 19
             $table->string('nickname');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         foreach ($fields as &$field) {
62 62
             // set the value
63
-            if (! isset($field['value'])) {
63
+            if (!isset($field['value'])) {
64 64
                 if (isset($field['subfields'])) {
65 65
                     $field['value'] = [];
66 66
                     foreach ($field['subfields'] as $subfield) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         // always have a hidden input for the entry id
76
-        if (! array_key_exists('id', $fields)) {
76
+        if (!array_key_exists('id', $fields)) {
77 77
             $fields['id'] = [
78 78
                 'name'  => $entry->getKeyName(),
79 79
                 'value' => $entry->getKey(),
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
             $relation_array = explode('.', $relational_entity);
101 101
 
102
-            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
102
+            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
103 103
                 return $obj->{$method} ? $obj->{$method} : $obj;
104 104
             }, $model);
105 105
 
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
      */
163 163
     private function getManyRelationAttributeValue($model, $relation_method, $field, $relation_type)
164 164
     {
165
-        if (! isset($field['pivotFields']) || ! is_array($field['pivotFields'])) {
165
+        if (!isset($field['pivotFields']) || !is_array($field['pivotFields'])) {
166 166
             return false;
167 167
         }
168 168
 
169
-        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
169
+        $pivot_fields = Arr::where($field['pivotFields'], function($item) use ($field) {
170 170
             return $field['name'] != $item['name'];
171 171
         });
172 172
         $related_models = $model->{$relation_method};
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         return collect($this->fields())
62 62
             ->where('model')
63 63
             ->whereIn('relation_type', $relation_types)
64
-            ->filter(function ($item) {
64
+            ->filter(function($item) {
65 65
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
66 66
 
67 67
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
207 207
         $related_method = Str::afterLast($relation_field['entity'], '.');
208 208
 
209
-        if (! method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
209
+        if (!method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
210 210
             return Str::beforeLast($relation_field['entity'], '.');
211 211
         }
212 212
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     {
89 89
         $all_relation_fields = $this->getRelationFields();
90 90
 
91
-        return Arr::where($all_relation_fields, function ($value, $key) {
91
+        return Arr::where($all_relation_fields, function($value, $key) {
92 92
             return isset($value['pivot']) && $value['pivot'];
93 93
         });
94 94
     }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
                             $field_data = json_decode($data[$field['name']], true);
153 153
 
154 154
                             // we grab from the parsed data the specific values for this pivot
155
-                            $pivot_data = Arr::first($field_data, function ($item) use ($pivot_id, $field) {
155
+                            $pivot_data = Arr::first($field_data, function($item) use ($pivot_id, $field) {
156 156
                                 return $item[$field['name']] === $pivot_id;
157 157
                             });
158 158
 
@@ -185,12 +185,12 @@  discard block
 block discarded – undo
185 185
      */
186 186
     private function createRelationsForItem($item, $formattedData)
187 187
     {
188
-        if (! isset($formattedData['relations'])) {
188
+        if (!isset($formattedData['relations'])) {
189 189
             return false;
190 190
         }
191 191
         
192 192
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
193
-            if (! isset($relationData['model'])) {
193
+            if (!isset($relationData['model'])) {
194 194
                 continue;
195 195
             }
196 196
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
                     // we first check if there are relations of the relation
205 205
                     if (isset($relationData['relations'])) {
206 206
                         // if there are nested relations, we first add the BelongsTo like in main entry
207
-                        $belongsToRelations = Arr::where($relationData['relations'], function ($relation_data) {
207
+                        $belongsToRelations = Arr::where($relationData['relations'], function($relation_data) {
208 208
                             return $relation_data['relation_type'] == 'BelongsTo';
209 209
                         });
210 210
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
                         $valuesWithRelations = $this->associateHasOneBelongsTo($belongsToRelations, $relationData['values'], $relation->getModel());
214 214
 
215 215
                         // remove previously added BelongsTo relations from relation data.
216
-                        $relationData['relations'] = Arr::where($relationData['relations'], function ($item) {
216
+                        $relationData['relations'] = Arr::where($relationData['relations'], function($item) {
217 217
                             return $item['relation_type'] != 'BelongsTo';
218 218
                         });
219 219
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
     private function getRelationDataFromFormData($data)
287 287
     {
288 288
         // exclude the already attached belongs to relations but include nested belongs to.
289
-        $relation_fields = Arr::where($this->getRelationFields(), function ($field, $key) {
289
+        $relation_fields = Arr::where($this->getRelationFields(), function($field, $key) {
290 290
             return $field['relation_type'] !== 'BelongsTo' || $this->isNestedRelation($field);
291 291
         });
292 292
 
@@ -295,13 +295,13 @@  discard block
 block discarded – undo
295 295
         foreach ($relation_fields as $relation_field) {
296 296
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
297 297
 
298
-            if ((! is_null(Arr::get($data, $attributeKey)) || $this->isNestedRelation($relation_field)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
298
+            if ((!is_null(Arr::get($data, $attributeKey)) || $this->isNestedRelation($relation_field)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
299 299
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
300 300
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
301
-                if (! array_key_exists('model', $fieldData)) {
301
+                if (!array_key_exists('model', $fieldData)) {
302 302
                     $fieldData['model'] = $relation_field['model'];
303 303
                 }
304
-                if (! array_key_exists('parent', $fieldData)) {
304
+                if (!array_key_exists('parent', $fieldData)) {
305 305
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
306 306
                 }
307 307
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
                 // this allow developers to override that behavior and force deletion from database
316 316
                 $fieldData['force_delete'] = $relation_field['force_delete'] ?? false;
317 317
 
318
-                if (! array_key_exists('relation_type', $fieldData)) {
318
+                if (!array_key_exists('relation_type', $fieldData)) {
319 319
                     $fieldData['relation_type'] = $relation_field['relation_type'];
320 320
                 }
321 321
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
                     ->where($relation_foreign_key, $item->{$relation_local_key})
359 359
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
360 360
             } else {
361
-                if (! $relation_column_is_nullable || $force_delete) {
361
+                if (!$relation_column_is_nullable || $force_delete) {
362 362
                     $model_instance->whereNotIn($model_instance->getKeyName(), $relation_values)
363 363
                         ->where($relation_foreign_key, $item->{$relation_local_key})
364 364
                         ->delete();
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
                 $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
376 376
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
377 377
             } else {
378
-                if (! $relation_column_is_nullable || $force_delete) {
378
+                if (!$relation_column_is_nullable || $force_delete) {
379 379
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})->delete();
380 380
                 } else {
381 381
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
             $created_ids = [];
406 406
 
407 407
             foreach ($items as $item) {
408
-                if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
408
+                if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
409 409
                     $entry->{$relationMethod}()->updateOrCreate([$relation_local_key => $item[$relation_local_key]], $item);
410 410
                 } else {
411 411
                     $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
             // get from $items the sent ids, and merge the ones created.
416 416
             $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
417 417
 
418
-            if (! empty($relatedItemsSent)) {
418
+            if (!empty($relatedItemsSent)) {
419 419
                 // we perform the cleanup of removed database items
420 420
                 $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
421 421
             }
Please login to merge, or discard this patch.