MultipleFiles::uploadRepeatableFile() - Code Metrics - Inspection of "refactoring" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — crud-uploads ( f5e93a...469ece )

by Pedro

created 2023-03-31 17:46 UTC

MultipleFiles::uploadRepeatableFile() B

↳ Parent: MultipleFiles

Complexity

Conditions	8
Paths	16

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	14
nc	16
nop	2
dl	0
loc	26
rs	8.4444
c	0
b	0
f	0

<?php

namespace Backpack\CRUD\app\Library\Uploaders;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Facades\Storage;

class MultipleFiles extends Uploader
{
    public static function for(array $field, $configuration)
    {
        return (new self($field, $configuration))->multiple();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    public function uploadFile(Model $entry, $value = null)
    {
        $filesToDelete = CRUD::getRequest()->get('clear_'.$this->getName());
        $filesToDelete = CRUD::/** @scrutinizer ignore-call */ getRequest()->get('clear_'.$this->getName());
        $value = $value ?? CRUD::getRequest()->file($this->getName());
        $previousFiles = $entry->getOriginal($this->getName()) ?? [];

        if (! is_array($previousFiles) && is_string($previousFiles)) {
            $previousFiles = json_decode($previousFiles, true);
        }

        if ($filesToDelete) {
            foreach ($previousFiles as $previousFile) {
                if (in_array($previousFile, $filesToDelete)) {
                    Storage::disk($this->getDisk())->delete($previousFile);

                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {
                    $previousFiles = Arr::where($previousFiles, function ($value, /** @scrutinizer ignore-unused */ $key) use ($previousFile) {
                        return $value != $previousFile;
                    });
                }
            }
        }

        foreach ($value ?? [] as $file) {
            if ($file && is_file($file)) {
                $fileName = $this->getFileName($file);

                $file->storeAs($this->getPath(), $fileName, $this->getDisk());

                $previousFiles[] = $this->getPath().$fileName;
            }
        }

        return isset($entry->getCasts()[$this->getName()]) ? $previousFiles : json_encode($previousFiles);

    }

    public function uploadRepeatableFile(Model $entry, $files = null)
    {
        $previousFiles = $this->getPreviousRepeatableValues($entry);
        $fileOrder = $this->getFileOrderFromRequest();

        foreach ($files as $row => $files) {
            foreach ($files ?? [] as $file) {
                if ($file && is_file($file)) {
                    $fileName = $this->getFileName($file);

                    $file->storeAs($this->getPath(), $fileName, $this->getDisk());
                    $fileOrder[$row][] = $this->getPath().$fileName;
                }
            }
        }

        foreach ($previousFiles as $previousRow => $files) {
            foreach ($files ?? [] as $key => $file) {
                $key = array_search($file, $fileOrder, true);
                if ($key === false) {
                    Storage::disk($this->getDisk())->delete($file);
                }
            }
        }

        return $fileOrder;
    }
}


Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — crud-uploads ( f5e93a...469ece )

MultipleFiles::uploadRepeatableFile() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like