Backpack\CRUD\app\Library\Uploaders\MultipleFiles

Complexity

Total Complexity

19

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	uploadFile()	0	33	10
B	uploadRepeatableFile()	0	26	8
A	for()	0	3	1

<?php

namespace Backpack\CRUD\app\Library\Uploaders;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Facades\Storage;

class MultipleFiles extends Uploader
{
    public static function for(array $field, $configuration)
    {
        return (new self($field, $configuration))->multiple();

The expression return new self($field, $configuration)->multiple() returns the type Backpack\CRUD\app\Library\Uploaders\MultipleFiles which is incompatible with the return type mandated by Backpack\CRUD\app\Library\Uploaders\Support\Interfaces\UploaderInterface::for() of void.

    }

    public function uploadFile(Model $entry, $value = null)
    {
        $filesToDelete = CRUD::getRequest()->get('clear_'.$this->getName());

The method getRequest() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        $value = $value ?? CRUD::getRequest()->file($this->getName());
        $previousFiles = $entry->getOriginal($this->getName()) ?? [];

        if (! is_array($previousFiles) && is_string($previousFiles)) {
            $previousFiles = json_decode($previousFiles, true);
        }

        if ($filesToDelete) {
            foreach ($previousFiles as $previousFile) {
                if (in_array($previousFile, $filesToDelete)) {
                    Storage::disk($this->getDisk())->delete($previousFile);

                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {

The parameter $key is not used and could be removed.

                        return $value != $previousFile;
                    });
                }
            }
        }

        foreach ($value ?? [] as $file) {
            if ($file && is_file($file)) {
                $fileName = $this->getFileName($file);

                $file->storeAs($this->getPath(), $fileName, $this->getDisk());

                $previousFiles[] = $this->getPath().$fileName;
            }
        }

        return isset($entry->getCasts()[$this->getName()]) ? $previousFiles : json_encode($previousFiles);

The expression return IssetNode ? $previousFiles : json_encode($previousFiles) also could return the type array|string which is incompatible with the return type mandated by Backpack\CRUD\app\Library\Uploaders\Support\Interfaces\UploaderInterface::uploadFile() of void.

    }

    public function uploadRepeatableFile(Model $entry, $files = null)
    {
        $previousFiles = $this->getPreviousRepeatableValues($entry);
        $fileOrder = $this->getFileOrderFromRequest();

        foreach ($files as $row => $files) {
            foreach ($files ?? [] as $file) {
                if ($file && is_file($file)) {
                    $fileName = $this->getFileName($file);

                    $file->storeAs($this->getPath(), $fileName, $this->getDisk());
                    $fileOrder[$row][] = $this->getPath().$fileName;
                }
            }
        }

        foreach ($previousFiles as $previousRow => $files) {
            foreach ($files ?? [] as $key => $file) {
                $key = array_search($file, $fileOrder, true);
                if ($key === false) {
                    Storage::disk($this->getDisk())->delete($file);
                }
            }
        }

        return $fileOrder;
    }
}