Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Push — fix-upload-validators-in-repea... ( 2c7240...9b0ef7 )
by Pedro
15:03
created
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $entry = CrudPanelFacade::getCurrentEntry() ?: null;
24 24
         
25
-        if (! $value = self::ensureValidValue($value)) {
25
+        if (!$value = self::ensureValidValue($value)) {
26 26
             $fail('Unable to determine the value type.');
27 27
 
28 28
             return;
@@ -77,13 +77,13 @@  discard block
 block discarded – undo
77 77
         $row = (int) Str::before(Str::after($attribute, '.'), '.');
78 78
         $dataFiles = explode(',', $this->data['_order_'.$mainField][$row][$subfield] ?? '');
79 79
         $values[$mainField] = Uploader::mergeFilesAndValuesRecursive($this->data[$mainField], $this->data['_order_'.$mainField]);
80
-        if (! array_key_exists($subfield, $values[$mainField][$row]) && $entry) {
80
+        if (!array_key_exists($subfield, $values[$mainField][$row]) && $entry) {
81 81
             return;
82 82
         }
83 83
 
84 84
         $this->createValidator($subfield, $this->getFieldRules(), $values[$mainField][$row][$subfield] ?? null, $fail);
85 85
 
86
-        if (! empty($value) && ! empty($this->getFileRules())) {
86
+        if (!empty($value) && !empty($this->getFileRules())) {
87 87
             $this->createValidator($subfield.'.*', $this->getFileRules(), $values[$mainField][$row][$subfield] ?? null, $fail);
88 88
         }
89 89
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => Str::replace(' ', '', $field)];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         }
190 190
         // if there's a model defined, but no attribute
191 191
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
192
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
192
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
193 193
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
194 194
         }
195 195
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      */
206 206
     protected function makeSureFieldHasLabel($field)
207 207
     {
208
-        if (! isset($field['label'])) {
208
+        if (!isset($field['label'])) {
209 209
             $name = str_replace(',', ' ', $field['name']);
210 210
             $name = str_replace('_id', '', $name);
211 211
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      */
224 224
     protected function makeSureFieldHasType($field)
225 225
     {
226
-        if (! isset($field['type'])) {
226
+        if (!isset($field['type'])) {
227 227
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
228 228
         }
229 229
 
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
      */
257 257
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
258 258
     {
259
-        if (! isset($field['subfields']) || ! is_array($field['subfields'])) {
259
+        if (!isset($field['subfields']) || !is_array($field['subfields'])) {
260 260
             return $field;
261 261
         }
262 262
 
263
-        if (! is_multidimensional_array($field['subfields'], true)) {
263
+        if (!is_multidimensional_array($field['subfields'], true)) {
264 264
             abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.');
265 265
         }
266 266
 
267 267
         foreach ($field['subfields'] as $key => $subfield) {
268
-            if (empty($subfield) || ! isset($subfield['name'])) {
268
+            if (empty($subfield) || !isset($subfield['name'])) {
269 269
                 abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.');
270 270
             }
271 271
 
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
             $subfield['baseFieldName'] = is_array($subfield['name']) ? implode(',', $subfield['name']) : $subfield['name'];
281 281
             $subfield['baseFieldName'] = Str::afterLast($subfield['baseFieldName'], '.');
282 282
 
283
-            if (! isset($field['model'])) {
283
+            if (!isset($field['model'])) {
284 284
                 // we're inside a simple 'repeatable' with no model/relationship, so
285 285
                 // we assume all subfields are supposed to be text fields
286 286
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -305,11 +305,11 @@  discard block
 block discarded – undo
305 305
                 case 'BelongsToMany':
306 306
                     $pivotSelectorField = static::getPivotFieldStructure($field);
307 307
 
308
-                    $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) {
308
+                    $pivot = Arr::where($field['subfields'], function($item) use ($pivotSelectorField) {
309 309
                         return $item['name'] === $pivotSelectorField['name'];
310 310
                     });
311 311
 
312
-                    if (! empty($pivot)) {
312
+                    if (!empty($pivot)) {
313 313
                         break;
314 314
                     }
315 315
 
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
                     $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity'];
323 323
                     $relationInstance = $this->getRelationInstance(['entity' => $entity]);
324 324
 
325
-                    $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) {
325
+                    $localKeyField = Arr::where($field['subfields'], function($item) use ($relationInstance) {
326 326
                         return $item['name'] === $relationInstance->getRelated()->getKeyName();
327 327
                     });
328 328
 
329
-                    if (! empty($localKeyField)) {
329
+                    if (!empty($localKeyField)) {
330 330
                         break;
331 331
                     }
332 332
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
     {
352 352
         // if a tab was mentioned, we should enable it
353 353
         if (isset($field['tab'])) {
354
-            if (! $this->tabsEnabled()) {
354
+            if (!$this->tabsEnabled()) {
355 355
                 $this->enableTabs();
356 356
             }
357 357
         }
Please login to merge, or discard this patch.