Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#3981)
by Cristian
12:34
created
src/resources/views/crud/fields/date_range.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (! function_exists('formatDate')) {
6
+    if (!function_exists('formatDate')) {
7 7
         function formatDate($entry, $dateFieldName)
8 8
         {
9 9
             $formattedDate = null;
10
-            if (isset($entry) && ! empty($entry->{$dateFieldName})) {
10
+            if (isset($entry) && !empty($entry->{$dateFieldName})) {
11 11
                 $dateField = $entry->{$dateFieldName};
12 12
                 if ($dateField instanceof \Carbon\CarbonInterface) {
13 13
                     $formattedDate = $dateField->format('Y-m-d H:i:s');
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
         }
21 21
     }
22 22
     if (isset($field['value'])) {
23
-        if (isset($entry) && ! is_array($field['value'])) {
23
+        if (isset($entry) && !is_array($field['value'])) {
24 24
             $start_value = formatDate($entry, $field['name'][0]);
25 25
             $end_value = formatDate($entry, $field['name'][1]);
26 26
         } elseif (is_array($field['value'])) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -303,8 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function setSaveAction($forceSaveAction = null)
305 305
     {
306
-        $saveAction = $forceSaveAction ?:
307
-            \Request::input('_save_action', $this->getFallBackSaveAction());
306
+        $saveAction = $forceSaveAction ?: \Request::input('_save_action', $this->getFallBackSaveAction());
308 307
 
309 308
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
310 309
 
@@ -371,20 +370,20 @@  discard block
 block discarded – undo
371 370
         $defaultSaveActions = [
372 371
             [
373 372
                 'name' => 'save_and_back',
374
-                'visible' => function ($crud) {
373
+                'visible' => function($crud) {
375 374
                     return $crud->hasAccess('list');
376 375
                 },
377
-                'redirect' => function ($crud, $request, $itemId = null) {
376
+                'redirect' => function($crud, $request, $itemId = null) {
378 377
                     return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
379 378
                 },
380 379
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
381 380
             ],
382 381
             [
383 382
                 'name' => 'save_and_edit',
384
-                'visible' => function ($crud) {
383
+                'visible' => function($crud) {
385 384
                     return $crud->hasAccess('update');
386 385
                 },
387
-                'redirect' => function ($crud, $request, $itemId = null) {
386
+                'redirect' => function($crud, $request, $itemId = null) {
388 387
                     $itemId = $itemId ?: $request->input('id');
389 388
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
390 389
                     if ($request->has('_locale')) {
@@ -396,17 +395,17 @@  discard block
 block discarded – undo
396 395
 
397 396
                     return $redirectUrl;
398 397
                 },
399
-                'referrer_url' => function ($crud, $request, $itemId) {
398
+                'referrer_url' => function($crud, $request, $itemId) {
400 399
                     return url($crud->route.'/'.$itemId.'/edit');
401 400
                 },
402 401
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
403 402
             ],
404 403
             [
405 404
                 'name' => 'save_and_new',
406
-                'visible' => function ($crud) {
405
+                'visible' => function($crud) {
407 406
                     return $crud->hasAccess('create');
408 407
                 },
409
-                'redirect' => function ($crud, $request, $itemId = null) {
408
+                'redirect' => function($crud, $request, $itemId = null) {
410 409
                     return $this->route.'/create';
411 410
                 },
412 411
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,21 +30,21 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
         });
36 36
 
37
-        $this->crud->operation('list', function () {
37
+        $this->crud->operation('list', function() {
38 38
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
39 39
         });
40 40
 
41
-        $this->crud->operation(['create', 'update'], function () {
41
+        $this->crud->operation(['create', 'update'], function() {
42 42
             $this->crud->addSaveAction([
43 43
                 'name' => 'save_and_preview',
44
-                'visible' => function ($crud) {
44
+                'visible' => function($crud) {
45 45
                     return $crud->hasAccess('show');
46 46
                 },
47
-                'redirect' => function ($crud, $request, $itemId = null) {
47
+                'redirect' => function($crud, $request, $itemId = null) {
48 48
                     $itemId = $itemId ?: $request->input('id');
49 49
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
50 50
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $all_relation_fields = $this->getRelationFields();
85 85
 
86
-        return Arr::where($all_relation_fields, function ($value, $key) {
86
+        return Arr::where($all_relation_fields, function($value, $key) {
87 87
             return isset($value['pivot']) && $value['pivot'];
88 88
         });
89 89
     }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
168
-            if (! isset($relationData['model'])) {
168
+            if (!isset($relationData['model'])) {
169 169
                 continue;
170 170
             }
171 171
             $model = $relationData['model'];
@@ -217,13 +217,13 @@  discard block
 block discarded – undo
217 217
         $relationData = [];
218 218
         foreach ($relation_fields as $relation_field) {
219 219
             $attributeKey = $relation_field['name'];
220
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
220
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
221 221
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
222 222
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
223
-                if (! array_key_exists('model', $fieldData)) {
223
+                if (!array_key_exists('model', $fieldData)) {
224 224
                     $fieldData['model'] = $relation_field['model'];
225 225
                 }
226
-                if (! array_key_exists('parent', $fieldData)) {
226
+                if (!array_key_exists('parent', $fieldData)) {
227 227
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
228 228
                 }
229 229
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     public function overwriteFieldNameFromDotNotationToArray($field)
70 70
     {
71
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false && isset($field['relation_type']) && in_array($field['relation_type'], ['HasOne', 'MorphOne'])) {
71
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false && isset($field['relation_type']) && in_array($field['relation_type'], ['HasOne', 'MorphOne'])) {
72 72
             $entity_array = explode('.', $field['name']);
73 73
             $name_string = '';
74 74
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
             return ['name' => $field];
96 96
         }
97 97
 
98
-        if (is_array($field) && ! isset($field['name'])) {
98
+        if (is_array($field) && !isset($field['name'])) {
99 99
             abort(500, 'All fields must have their name defined');
100 100
         }
101 101
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     {
155 155
         // if there's a model defined, but no attribute
156 156
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
157
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
157
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
158 158
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
159 159
         }
160 160
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureFieldHasLabel($field)
172 172
     {
173
-        if (! isset($field['label'])) {
173
+        if (!isset($field['label'])) {
174 174
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
175 175
             $name = str_replace('_id', '', $name);
176 176
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
      */
189 189
     protected function makeSureFieldHasType($field)
190 190
     {
191
-        if (! isset($field['type'])) {
191
+        if (!isset($field['type'])) {
192 192
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
193 193
         }
194 194
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
     {
206 206
         // if a tab was mentioned, we should enable it
207 207
         if (isset($field['tab'])) {
208
-            if (! $this->tabsEnabled()) {
208
+            if (!$this->tabsEnabled()) {
209 209
                 $this->enableTabs();
210 210
             }
211 211
         }
Please login to merge, or discard this patch.