Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — fix-uploaders ( e0f236...3522fc )
by Pedro
11:26
created
src/app/Library/Validation/Rules/ValidUpload.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     {
19 19
         $entry = CrudPanelFacade::getCurrentEntry();
20 20
 
21
-        if (! Arr::has($this->data, $attribute)) {
21
+        if (!Arr::has($this->data, $attribute)) {
22 22
             $requestAttribute = Arr::get($this->data, '_order_'.$attribute);
23 23
 
24 24
             if ($entry && Arr::get($entry->{Str::before($attribute, '.')}, Str::after($attribute, '.')) === $requestAttribute) {
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
 
31 31
         $fieldErrors = $this->validateFieldRules($attribute, $value);
32 32
 
33
-        if (! empty($value) && ! empty($this->getFileRules())) {
33
+        if (!empty($value) && !empty($this->getFileRules())) {
34 34
             $fileErrors = $this->validateFileRules($attribute, $value);
35 35
         }
36 36
 
37 37
         return array_merge($fieldErrors, $fileErrors ?? []);
38 38
     }
39 39
 
40
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
40
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
41 41
     {
42 42
         return parent::field($rules);
43 43
     }
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
         }
24 24
 
25 25
         $previousValues = str_contains($attribute, '.') ?
26
-                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) :
27
-                            ($entry?->{$attribute} ?? []);
26
+                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) : ($entry?->{$attribute} ?? []);
28 27
 
29 28
         if (is_string($previousValues)) {
30 29
             $previousValues = json_decode($previousValues, true) ?? [];
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/BackpackCustomRule.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -28,13 +28,13 @@  discard block
 block discarded – undo
28 28
 
29 29
     public bool $implicit = true;
30 30
 
31
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
31
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
32 32
     {
33 33
         $instance = new static();
34 34
         $instance->fieldRules = self::getRulesAsArray($rules);
35 35
 
36 36
         if ($instance->validatesArrays()) {
37
-            if (! in_array('array', $instance->getFieldRules())) {
37
+            if (!in_array('array', $instance->getFieldRules())) {
38 38
                 $instance->fieldRules[] = 'array';
39 39
             }
40 40
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
     public function getFieldRules(): array
96 96
     {
97
-        return tap($this->fieldRules, function ($rule) {
97
+        return tap($this->fieldRules, function($rule) {
98 98
             if (is_a($rule, BackpackCustomRule::class, true)) {
99 99
                 $rule = $rule->getFieldRules();
100 100
             }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
             $rules = explode('|', $rules);
110 110
         }
111 111
 
112
-        if (! is_array($rules)) {
112
+        if (!is_array($rules)) {
113 113
             $rules = [$rules];
114 114
         }
115 115
 
@@ -118,10 +118,10 @@  discard block
 block discarded – undo
118 118
 
119 119
     protected function ensureValueIsValid($value)
120 120
     {
121
-        if ($this->validatesArrays() && ! is_array($value)) {
121
+        if ($this->validatesArrays() && !is_array($value)) {
122 122
             try {
123 123
                 $value = json_decode($value, true) ?? [];
124
-            } catch(\Exception $e) {
124
+            } catch (\Exception $e) {
125 125
                 return false;
126 126
             }
127 127
         }
@@ -140,14 +140,13 @@  discard block
 block discarded – undo
140 140
             $attribute => $rules,
141 141
         ], $this->validator->customMessages, $this->validator->customAttributes);
142 142
 
143
-        return $validator->errors()->messages()[$attribute] ?? (! empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
143
+        return $validator->errors()->messages()[$attribute] ?? (!empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
144 144
     }
145 145
 
146 146
     protected function getValidationAttributeString(string $attribute)
147 147
     {
148 148
         return Str::substrCount($attribute, '.') > 1 ?
149
-                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') :
150
-                $attribute;
149
+                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') : $attribute;
151 150
     }
152 151
 
153 152
     protected function validateOnSubmit(string $attribute, mixed $value): array
@@ -155,7 +154,7 @@  discard block
 block discarded – undo
155 154
         return $this->validateRules($attribute, $value);
156 155
     }
157 156
 
158
-    protected function validateFieldAndFile(string $attribute, null|array $data = null, array|null $customRules = null): array
157
+    protected function validateFieldAndFile(string $attribute, null | array $data = null, array | null $customRules = null): array
159 158
     {
160 159
         $fieldErrors = $this->validateFieldRules($attribute, $data, $customRules);
161 160
 
@@ -167,7 +166,7 @@  discard block
 block discarded – undo
167 166
     /**
168 167
      * Implementation.
169 168
      */
170
-    public function validateFieldRules(string $attribute, null|array|string|UploadedFile $data = null, array|null $customRules = null): array
169
+    public function validateFieldRules(string $attribute, null | array | string | UploadedFile $data = null, array | null $customRules = null): array
171 170
     {
172 171
         $data = $data ?? $this->data;
173 172
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
@@ -176,16 +175,16 @@  discard block
 block discarded – undo
176 175
         return $this->validateAndGetErrors($validationRuleAttribute, $data, $customRules ?? $this->getFieldRules());
177 176
     }
178 177
 
179
-    protected function prepareValidatorData(array|string|UploadedFile $data, string $attribute): array
178
+    protected function prepareValidatorData(array | string | UploadedFile $data, string $attribute): array
180 179
     {
181
-        if ($this->validatesArrays() && is_array($data) && ! Str::contains($attribute, '.')) {
180
+        if ($this->validatesArrays() && is_array($data) && !Str::contains($attribute, '.')) {
182 181
             return Arr::has($data, $attribute) ? $data : [$attribute => Arr::get($data, $attribute)];
183 182
         }
184 183
 
185 184
         if (Str::contains($attribute, '.')) {
186 185
             $validData = [];
187 186
 
188
-            Arr::set($validData, $attribute, ! is_array($data) ? $data : Arr::get($data, $attribute));
187
+            Arr::set($validData, $attribute, !is_array($data) ? $data : Arr::get($data, $attribute));
189 188
 
190 189
             return $validData;
191 190
         }
@@ -199,7 +198,7 @@  discard block
 block discarded – undo
199 198
         $items = is_array($items) ? $items : [$items];
200 199
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
201 200
         $filesToValidate = $this->validatesArrays() ? Arr::get($items, $attribute) : [Arr::get($items, $attribute)];
202
-        $filesToValidate = array_filter($filesToValidate ?? [], function ($item) {
201
+        $filesToValidate = array_filter($filesToValidate ?? [], function($item) {
203 202
             return $item instanceof UploadedFile;
204 203
         });
205 204
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudField.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      */
227 227
     public function subfields($subfields)
228 228
     {
229
-        $callAttributeMacro = ! isset($this->attributes['subfields']);
229
+        $callAttributeMacro = !isset($this->attributes['subfields']);
230 230
         $this->attributes['subfields'] = $subfields;
231 231
         $this->attributes = $this->crud()->makeSureFieldHasNecessaryAttributes($this->attributes);
232 232
         if ($callAttributeMacro) {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
         // append the field name to the rule name of validationMessages array.
277 277
         // eg: ['required => 'This field is required']
278 278
         // will be transformed into: ['field_name.required' => 'This field is required]
279
-        $this->crud()->setValidationFromArray([], array_merge(...array_map(function ($rule, $message) {
279
+        $this->crud()->setValidationFromArray([], array_merge(...array_map(function($rule, $message) {
280 280
             return [$this->attributes['name'].'.'.$rule => $message];
281 281
         }, array_keys($messages), $messages)));
282 282
 
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
     public function __call($method, $parameters)
463 463
     {
464 464
         if (static::hasMacro($method)) {
465
-            if(in_array($method, ['withFiles', 'withMedia'])) {
465
+            if (in_array($method, ['withFiles', 'withMedia'])) {
466 466
                 $this->setAttributeValue($method, $parameters[0] ?? true);
467 467
                 $this->save();
468 468
             }     
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudColumn.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
      */
91 91
     public function key(string $key)
92 92
     {
93
-        if (! isset($this->attributes['name'])) {
93
+        if (!isset($this->attributes['name'])) {
94 94
             abort(500, 'Column name must be defined before changing the key.');
95 95
         }
96 96
 
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
     public function __call($method, $parameters)
296 296
     {
297 297
         if (static::hasMacro($method)) {
298
-            if(in_array($method, ['withFiles', 'withMedia'])) {
298
+            if (in_array($method, ['withFiles', 'withMedia'])) {
299 299
                 $this->setAttributeValue($method, $parameters[0] ?? true);
300 300
                 $this->save();
301 301
             }       
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/UploadersRepository.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function markAsHandled(string $objectName): void
36 36
     {
37
-        if (! in_array($objectName, $this->handledUploaders)) {
37
+        if (!in_array($objectName, $this->handledUploaders)) {
38 38
             $this->handledUploaders[] = $objectName;
39 39
         }
40 40
     }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function registerRepeatableUploader(string $uploadName, UploaderInterface $uploader): void
86 86
     {
87
-        if (! array_key_exists($uploadName, $this->repeatableUploaders) || ! in_array($uploader, $this->repeatableUploaders[$uploadName])) {
87
+        if (!array_key_exists($uploadName, $this->repeatableUploaders) || !in_array($uploader, $this->repeatableUploaders[$uploadName])) {
88 88
             $this->repeatableUploaders[$uploadName][] = $uploader;
89 89
         }
90 90
     }
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     public function getRegisteredUploadNames(string $uploadName): array
120 120
     {
121
-        return array_map(function ($uploader) {
121
+        return array_map(function($uploader) {
122 122
             return $uploader->getName();
123 123
         }, $this->getRepeatableUploadersFor($uploadName));
124 124
     }
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
 
150 150
             $uploaders = $this->getRepeatableUploadersFor($repeatableContainerName);
151 151
 
152
-            $uploader = Arr::first($uploaders, function ($uploader) use ($requestInputName) {
152
+            $uploader = Arr::first($uploaders, function($uploader) use ($requestInputName) {
153 153
                 return $uploader->getName() === $requestInputName;
154 154
             });
155 155
             
156
-            if (! $uploader) {
156
+            if (!$uploader) {
157 157
                 abort(500, 'Could not find the field in the repeatable uploaders.');
158 158
             }
159 159
 
@@ -164,16 +164,16 @@  discard block
 block discarded – undo
164 164
             abort(500, 'Could not find the field in the CRUD fields.');
165 165
         }
166 166
 
167
-        if (! $uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
167
+        if (!$uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
168 168
             abort(500, 'There is no uploader defined for the given field type.');
169 169
         }
170 170
 
171
-        if (! $this->isValidUploadField($crudObject, $uploaderMacro)) {
171
+        if (!$this->isValidUploadField($crudObject, $uploaderMacro)) {
172 172
             abort(500, 'Invalid field for upload.');
173 173
         }
174 174
 
175 175
         $uploaderConfiguration = $crudObject[$uploaderMacro] ?? [];
176
-        $uploaderConfiguration = ! is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
176
+        $uploaderConfiguration = !is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
177 177
         $uploaderClass = $this->getUploadFor($crudObject['type'], $uploaderMacro);
178 178
 
179 179
         return new $uploaderClass(['name' => $requestInputName], $uploaderConfiguration);
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * Get the upload field macro type for the given object.
184 184
      */
185
-    private function getUploadCrudObjectMacroType(array $crudObject): string|null
185
+    private function getUploadCrudObjectMacroType(array $crudObject): string | null
186 186
     {
187 187
         return isset($crudObject['withFiles']) ? 'withFiles' : (isset($crudObject['withMedia']) ? 'withMedia' : null);
188 188
     }
@@ -191,11 +191,11 @@  discard block
 block discarded – undo
191 191
     {
192 192
         if (Str::contains($crudObject['name'], '#')) {
193 193
             $container = Str::before($crudObject['name'], '#');
194
-            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function ($item) use ($crudObject, $uploaderMacro) {
194
+            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function($item) use ($crudObject, $uploaderMacro) {
195 195
                 return $item['name'] === $crudObject['name'] && in_array($item['type'], $this->getAjaxUploadTypes($uploaderMacro));
196 196
             });
197 197
 
198
-            return ! empty($field);
198
+            return !empty($field);
199 199
         }
200 200
 
201 201
         return in_array($crudObject['type'], $this->getAjaxUploadTypes($uploaderMacro));
Please login to merge, or discard this patch.