Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — dont-call-mutators-as-methods ( ad2f89 )
by Pedro
16:07
created
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
     public function testCreateWithOneToOneDynamicRelationship()
171 171
     {
172
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
172
+        User::resolveRelationUsing('dynamicRelation', function($user) {
173 173
             return $user->hasOne(\Backpack\CRUD\Tests\config\Models\AccountDetails::class);
174 174
         });
175 175
         $this->crudPanel->setModel(User::class);
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 
281 281
     public function testCreateWithOneToManyDynamicRelationship()
282 282
     {
283
-        Article::resolveRelationUsing('dynamicRelation', function ($article) {
283
+        Article::resolveRelationUsing('dynamicRelation', function($article) {
284 284
             return $article->belongsTo(\Backpack\CRUD\Tests\config\Models\User::class, 'user_id');
285 285
         });
286 286
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
     public function testCreateWithManyToManyDynamicRelationship()
345 345
     {
346
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
346
+        User::resolveRelationUsing('dynamicRelation', function($user) {
347 347
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Role::class, 'user_role');
348 348
         });
349 349
 
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 
686 686
     public function testBelongsToManyWithPivotDataDynamicRelationship()
687 687
     {
688
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
688
+        User::resolveRelationUsing('dynamicRelation', function($user) {
689 689
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date']);
690 690
         });
691 691
 
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 
795 795
     public function testBelongsToManyWithMultipleSameRelationIdAndPivotDataDynamicRelationship()
796 796
     {
797
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
797
+        User::resolveRelationUsing('dynamicRelation', function($user) {
798 798
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date', 'id'])->using('Backpack\CRUD\Tests\config\Models\SuperArticlePivot');
799 799
         });
800 800
 
@@ -1046,7 +1046,7 @@  discard block
 block discarded – undo
1046 1046
 
1047 1047
     public function testCreateBelongsToFake()
1048 1048
     {
1049
-        $belongsToField = [   // select_grouped
1049
+        $belongsToField = [// select_grouped
1050 1050
             'label' => 'Select_grouped',
1051 1051
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
1052 1052
             'name' => 'bang_relation_field',
@@ -1182,7 +1182,7 @@  discard block
 block discarded – undo
1182 1182
                 'nickname' => 'i_have_has_one',
1183 1183
                 'profile_picture' => 'ohh my picture 1.jpg',
1184 1184
                 'article' => 1,
1185
-                'addresses' => [ // HasOne is tested in other test function
1185
+                'addresses' => [// HasOne is tested in other test function
1186 1186
                     [
1187 1187
                         'city' => 2,
1188 1188
                         'street' => 'test',
@@ -1974,23 +1974,23 @@  discard block
 block discarded – undo
1974 1974
         $this->crudPanel->addField([
1975 1975
             'name' => 'name',
1976 1976
             'events' => [
1977
-                'created' => function ($entry) {
1977
+                'created' => function($entry) {
1978 1978
                 },
1979
-                'creating' => function ($entry) {
1979
+                'creating' => function($entry) {
1980 1980
                     $entry->email = '[email protected]';
1981 1981
                     $entry->password = Hash::make('password');
1982 1982
                 },
1983
-                'saving' => function ($entry) {
1983
+                'saving' => function($entry) {
1984 1984
                 },
1985
-                'saved' => function ($entry) {
1985
+                'saved' => function($entry) {
1986 1986
                 },
1987
-                'updating' => function ($entry) {
1987
+                'updating' => function($entry) {
1988 1988
                 },
1989
-                'updated' => function ($entry) {
1989
+                'updated' => function($entry) {
1990 1990
                 },
1991
-                'deleting' => function ($entry) {
1991
+                'deleting' => function($entry) {
1992 1992
                 },
1993
-                'deleted' => function ($entry) {
1993
+                'deleted' => function($entry) {
1994 1994
                 },
1995 1995
             ],
1996 1996
         ]);
@@ -2013,7 +2013,7 @@  discard block
 block discarded – undo
2013 2013
 
2014 2014
     public function testItCanCreateDynamicRelationships()
2015 2015
     {
2016
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
2016
+        User::resolveRelationUsing('dynamicRelation', function($user) {
2017 2017
             return $user->belongsTo(\Backpack\CRUD\Tests\config\Models\Bang::class, 'bang_relation_field');
2018 2018
         });
2019 2019
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                     // - a single dimensional array: [1,2,3]
125 125
                     // - an array of arrays: [[1][2][3]]
126 126
                     // if is as single dimensional array we can only attach.
127
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
127
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
128 128
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
129 129
                     } else {
130 130
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
                             $toDelete = array_diff($dbValues, $sentIds);
148 148
 
149
-                            if (! empty($toDelete)) {
149
+                            if (!empty($toDelete)) {
150 150
                                 foreach ($toDelete as $id) {
151 151
                                     $relation->newPivot()->where($keyName, $id)->delete();
152 152
                                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
     }
190 190
 
191
-    private function preparePivotAttributesForSave(array $attributes, BelongsToMany|MorphToMany $relation, string|int $relatedItemKey, $pivotKeyName, $relationMethod): array
191
+    private function preparePivotAttributesForSave(array $attributes, BelongsToMany | MorphToMany $relation, string | int $relatedItemKey, $pivotKeyName, $relationMethod): array
192 192
     {
193 193
         $attributes[$relation->getForeignPivotKeyName()] = $relatedItemKey;
194 194
         $attributes[$relation->getRelatedPivotKeyName()] = $attributes[$relationMethod];
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
         }
335 335
         // if column is not nullable in database, and there is no column default (null),
336 336
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
337
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
337
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
338 338
             return $removedEntries->lazy()->each->delete();
339 339
         }
340 340
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
         }
380 380
 
381 381
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
382
-        if (! empty($relatedItemsSent)) {
382
+        if (!empty($relatedItemsSent)) {
383 383
             // we perform the cleanup of removed database items
384 384
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
385 385
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Access.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Set an operation as having access using the Settings API.
12 12
      */
13
-    public function allowAccess(array|string $operation): bool
13
+    public function allowAccess(array | string $operation): bool
14 14
     {
15 15
         foreach ((array) $operation as $op) {
16 16
             $this->set($op.'.access', true);
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     /**
23 23
      * Disable the access to a certain operation, or the current one.
24 24
      */
25
-    public function denyAccess(array|string $operation): bool
25
+    public function denyAccess(array | string $operation): bool
26 26
     {
27 27
         foreach ((array) $operation as $op) {
28 28
             $this->set($op.'.access', false);
29 29
         }
30 30
 
31
-        return ! $this->hasAccessToAny($operation);
31
+        return !$this->hasAccessToAny($operation);
32 32
     }
33 33
 
34 34
     /**
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if any operations are allowed for a Crud Panel. Return false if not.
54 54
      */
55
-    public function hasAccessToAny(array|string $operation_array, ?Model $entry = null): bool
55
+    public function hasAccessToAny(array | string $operation_array, ?Model $entry = null): bool
56 56
     {
57 57
         foreach ((array) $operation_array as $key => $operation) {
58 58
             if ($this->hasAccess($operation, $entry) == true) {
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
     /**
67 67
      * Check if all operations are allowed for a Crud Panel. Return false if not.
68 68
      */
69
-    public function hasAccessToAll(array|string $operation_array, ?Model $entry = null): bool
69
+    public function hasAccessToAll(array | string $operation_array, ?Model $entry = null): bool
70 70
     {
71 71
         foreach ((array) $operation_array as $key => $operation) {
72
-            if (! $this->hasAccess($operation, $entry)) {
72
+            if (!$this->hasAccess($operation, $entry)) {
73 73
                 return false;
74 74
             }
75 75
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function hasAccessOrFail(string $operation, ?Model $entry = null): bool
86 86
     {
87
-        if (! $this->hasAccess($operation, $entry)) {
87
+        if (!$this->hasAccess($operation, $entry)) {
88 88
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]), 403);
89 89
         }
90 90
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      * Get an operation's access condition, if set. A condition
96 96
      * can be anything, but usually a boolean or a callable.
97 97
      */
98
-    public function getAccessCondition(string $operation): bool|callable|null
98
+    public function getAccessCondition(string $operation): bool | callable | null
99 99
     {
100 100
         return $this->get($operation.'.access');
101 101
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Set the condition under which an operation is allowed for a Crud Panel.
105 105
      */
106
-    public function setAccessCondition(array|string $operation, bool|callable|null $condition): void
106
+    public function setAccessCondition(array | string $operation, bool | callable | null $condition): void
107 107
     {
108 108
         foreach ((array) $operation as $op) {
109 109
             $this->set($op.'.access', $condition);
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      * Allow access only to operations in the array.
132 132
      * By denying access to all other operations.
133 133
      */
134
-    public function allowAccessOnlyTo(array|string $operation): void
134
+    public function allowAccessOnlyTo(array | string $operation): void
135 135
     {
136 136
         $this->denyAllAccess();
137 137
         $this->allowAccess($operation);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -384,7 +384,7 @@
 block discarded – undo
384 384
                 $model = $model->$part();
385 385
                 
386 386
                 if(! is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
387
-                   return false;
387
+                    return false;
388 388
                 }
389 389
 
390 390
                 $model = $model->getRelated();
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
             // here we are going to iterate through all relation parts to check
25 25
             foreach ($parts as $i => $part) {
26 26
                 $relation = $model->$part();
27
-                if(! is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
27
+                if (!is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
28 28
                     return $model;
29 29
                 }
30 30
                 $model = $relation->getRelated();
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         $model = $this->getRelationModel($entity, -1);
69 69
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
70 70
 
71
-        if (! method_exists($model, $lastSegmentAfterDot)) {
71
+        if (!method_exists($model, $lastSegmentAfterDot)) {
72 72
             return (string) Str::of($field['entity'])->beforeLast('.');
73 73
         }
74 74
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
         return collect($this->getCleanStateFields())
91 91
             ->whereIn('relation_type', $relation_types)
92
-            ->filter(function ($item) use ($nested) {
92
+            ->filter(function($item) use ($nested) {
93 93
                 if ($nested) {
94 94
                     return true;
95 95
                 }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
135 135
     {
136
-        if (! is_array($relations)) {
136
+        if (!is_array($relations)) {
137 137
             $relations = [$relations];
138 138
         }
139 139
 
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
         }
143 143
 
144 144
         foreach ($relations as $relation) {
145
-            $fields = array_filter($fields, function ($field) use ($relation) {
146
-                if (! isset($field['relation_type'])) {
145
+            $fields = array_filter($fields, function($field) use ($relation) {
146
+                if (!isset($field['relation_type'])) {
147 147
                     return false;
148 148
                 }
149 149
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                     $fields = array_merge($field['subfields'], $fields);
178 178
                 }
179 179
             }
180
-            $fields = array_filter($fields, function ($field) {
180
+            $fields = array_filter($fields, function($field) {
181 181
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
182 182
             });
183 183
         }
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     {
245 245
         $all_relation_fields = $this->getRelationFields();
246 246
 
247
-        return Arr::where($all_relation_fields, function ($value, $key) {
248
-            return isset($value['pivot']) && ! $value['pivot'];
247
+        return Arr::where($all_relation_fields, function($value, $key) {
248
+            return isset($value['pivot']) && !$value['pivot'];
249 249
         });
250 250
     }
251 251
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     {
259 259
         $all_relation_fields = $this->getRelationFields();
260 260
 
261
-        return Arr::where($all_relation_fields, function ($value, $key) {
261
+        return Arr::where($all_relation_fields, function($value, $key) {
262 262
             return isset($value['pivot']) && $value['pivot'];
263 263
         });
264 264
     }
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      */
329 329
     private function modelMethodIsRelationship($model, $method)
330 330
     {
331
-        if (! method_exists($model, $method) && $model->isRelation($method)) {
331
+        if (!method_exists($model, $method) && $model->isRelation($method)) {
332 332
             return $method;
333 333
         }
334 334
 
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
         }
341 341
 
342 342
         // relationships are always public methods.
343
-        if (! $methodReflection->isPublic()) {
343
+        if (!$methodReflection->isPublic()) {
344 344
             return false;
345 345
         }
346 346
 
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
      */
368 368
     public function isAttributeInRelationString(array $field): bool
369 369
     {
370
-        if (! str_contains($field['entity'], '.')) {
370
+        if (!str_contains($field['entity'], '.')) {
371 371
             return false;
372 372
         }
373 373
 
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
             try {
384 384
                 $model = $model->$part();
385 385
                 
386
-                if(! is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
386
+                if (!is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
387 387
                    return false;
388 388
                 }
389 389
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $complete_route = $route.'.index';
208 208
 
209
-        if (! \Route::has($complete_route)) {
209
+        if (!\Route::has($complete_route)) {
210 210
             throw new Exception('There are no routes for this route name.', 404);
211 211
         }
212 212
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function getFirstOfItsTypeInArray($type, $array)
306 306
     {
307
-        return Arr::first($array, function ($item) use ($type) {
307
+        return Arr::first($array, function($item) use ($type) {
308 308
             return $item['type'] == $type;
309 309
         });
310 310
     }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function sync($type, $fields, $attributes)
326 326
     {
327
-        if (! empty($this->{$type})) {
328
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
327
+        if (!empty($this->{$type})) {
328
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
329 329
                 if (in_array($field['name'], (array) $fields)) {
330 330
                     $field = array_merge($field, $attributes);
331 331
                 }
@@ -355,18 +355,18 @@  discard block
 block discarded – undo
355 355
     {
356 356
         $relationArray = explode('.', $relationString);
357 357
 
358
-        if (! isset($length)) {
358
+        if (!isset($length)) {
359 359
             $length = count($relationArray);
360 360
         }
361 361
 
362
-        if (! isset($model)) {
362
+        if (!isset($model)) {
363 363
             $model = $this->model;
364 364
         }
365 365
 
366
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
366
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
367 367
             try {
368 368
                 $result = $obj->$method();
369
-                if (! $result instanceof Relation) {
369
+                if (!$result instanceof Relation) {
370 370
                     throw new Exception('Not a relation');
371 371
                 }
372 372
                 return $result->getRelated();
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
             if (is_array($entries)) {
402 402
                 //if attribute does not exist in main array we have more than one entry OR the attribute
403 403
                 //is an accessor that is not in $appends property of model.
404
-                if (! isset($entries[$attribute])) {
404
+                if (!isset($entries[$attribute])) {
405 405
                     //we first check if we don't have the attribute because it's an accessor that is not in appends.
406 406
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
407 407
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -440,21 +440,21 @@  discard block
 block discarded – undo
440 440
      */
441 441
     public function parseTranslatableAttributes($model, $attribute, $value)
442 442
     {
443
-        if (! method_exists($model, 'isTranslatableAttribute')) {
443
+        if (!method_exists($model, 'isTranslatableAttribute')) {
444 444
             return $value;
445 445
         }
446 446
 
447
-        if (! $model->isTranslatableAttribute($attribute)) {
447
+        if (!$model->isTranslatableAttribute($attribute)) {
448 448
             return $value;
449 449
         }
450 450
 
451
-        if (! is_array($value)) {
451
+        if (!is_array($value)) {
452 452
             $decodedAttribute = json_decode($value, true) ?? ($value !== null ? [$value] : []);
453 453
         } else {
454 454
             $decodedAttribute = $value;
455 455
         }
456 456
 
457
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
457
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
458 458
             if (isset($decodedAttribute[app()->getLocale()])) {
459 459
                 return $decodedAttribute[app()->getLocale()];
460 460
             } else {
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
         if (method_exists($model, 'translationEnabled') && $model->translationEnabled()) {
473 473
             $locale = $this->getRequest()->input('_locale', app()->getLocale());
474 474
             if (in_array($locale, array_keys($model->getAvailableLocales()))) {
475
-                $model->setLocale(! is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
475
+                $model->setLocale(!is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
476 476
                 $model->useFallbackLocale = (bool) $useFallbackLocale;
477 477
             }
478 478
         }
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
         $relation = $model->{$firstRelationName};
496 496
 
497 497
         $results = [];
498
-        if (! is_null($relation)) {
498
+        if (!is_null($relation)) {
499 499
             if ($relation instanceof Collection) {
500 500
                 $currentResults = $relation->all();
501 501
             } elseif (is_array($relation)) {
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
             array_shift($relationArray);
510 510
 
511
-            if (! empty($relationArray)) {
511
+            if (!empty($relationArray)) {
512 512
                 foreach ($currentResults as $currentResult) {
513 513
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
514 514
                 }
Please login to merge, or discard this patch.