Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — dont-call-mutators-as-methods ( ad2f89 )
by Pedro
16:07
created
src/app/Library/CrudPanel/Traits/Relationships.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -384,7 +384,7 @@
 block discarded – undo
384 384
                 $model = $model->$part();
385 385
                 
386 386
                 if(! is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
387
-                   return false;
387
+                    return false;
388 388
                 }
389 389
 
390 390
                 $model = $model->getRelated();
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
             // here we are going to iterate through all relation parts to check
25 25
             foreach ($parts as $i => $part) {
26 26
                 $relation = $model->$part();
27
-                if(! is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
27
+                if (!is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
28 28
                     return $model;
29 29
                 }
30 30
                 $model = $relation->getRelated();
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         $model = $this->getRelationModel($entity, -1);
69 69
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
70 70
 
71
-        if (! method_exists($model, $lastSegmentAfterDot)) {
71
+        if (!method_exists($model, $lastSegmentAfterDot)) {
72 72
             return (string) Str::of($field['entity'])->beforeLast('.');
73 73
         }
74 74
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
         return collect($this->getCleanStateFields())
91 91
             ->whereIn('relation_type', $relation_types)
92
-            ->filter(function ($item) use ($nested) {
92
+            ->filter(function($item) use ($nested) {
93 93
                 if ($nested) {
94 94
                     return true;
95 95
                 }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
135 135
     {
136
-        if (! is_array($relations)) {
136
+        if (!is_array($relations)) {
137 137
             $relations = [$relations];
138 138
         }
139 139
 
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
         }
143 143
 
144 144
         foreach ($relations as $relation) {
145
-            $fields = array_filter($fields, function ($field) use ($relation) {
146
-                if (! isset($field['relation_type'])) {
145
+            $fields = array_filter($fields, function($field) use ($relation) {
146
+                if (!isset($field['relation_type'])) {
147 147
                     return false;
148 148
                 }
149 149
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                     $fields = array_merge($field['subfields'], $fields);
178 178
                 }
179 179
             }
180
-            $fields = array_filter($fields, function ($field) {
180
+            $fields = array_filter($fields, function($field) {
181 181
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
182 182
             });
183 183
         }
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     {
245 245
         $all_relation_fields = $this->getRelationFields();
246 246
 
247
-        return Arr::where($all_relation_fields, function ($value, $key) {
248
-            return isset($value['pivot']) && ! $value['pivot'];
247
+        return Arr::where($all_relation_fields, function($value, $key) {
248
+            return isset($value['pivot']) && !$value['pivot'];
249 249
         });
250 250
     }
251 251
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     {
259 259
         $all_relation_fields = $this->getRelationFields();
260 260
 
261
-        return Arr::where($all_relation_fields, function ($value, $key) {
261
+        return Arr::where($all_relation_fields, function($value, $key) {
262 262
             return isset($value['pivot']) && $value['pivot'];
263 263
         });
264 264
     }
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      */
329 329
     private function modelMethodIsRelationship($model, $method)
330 330
     {
331
-        if (! method_exists($model, $method) && $model->isRelation($method)) {
331
+        if (!method_exists($model, $method) && $model->isRelation($method)) {
332 332
             return $method;
333 333
         }
334 334
 
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
         }
341 341
 
342 342
         // relationships are always public methods.
343
-        if (! $methodReflection->isPublic()) {
343
+        if (!$methodReflection->isPublic()) {
344 344
             return false;
345 345
         }
346 346
 
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
      */
368 368
     public function isAttributeInRelationString(array $field): bool
369 369
     {
370
-        if (! str_contains($field['entity'], '.')) {
370
+        if (!str_contains($field['entity'], '.')) {
371 371
             return false;
372 372
         }
373 373
 
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
             try {
384 384
                 $model = $model->$part();
385 385
                 
386
-                if(! is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
386
+                if (!is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
387 387
                    return false;
388 388
                 }
389 389
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $complete_route = $route.'.index';
208 208
 
209
-        if (! \Route::has($complete_route)) {
209
+        if (!\Route::has($complete_route)) {
210 210
             throw new Exception('There are no routes for this route name.', 404);
211 211
         }
212 212
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function getFirstOfItsTypeInArray($type, $array)
306 306
     {
307
-        return Arr::first($array, function ($item) use ($type) {
307
+        return Arr::first($array, function($item) use ($type) {
308 308
             return $item['type'] == $type;
309 309
         });
310 310
     }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function sync($type, $fields, $attributes)
326 326
     {
327
-        if (! empty($this->{$type})) {
328
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
327
+        if (!empty($this->{$type})) {
328
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
329 329
                 if (in_array($field['name'], (array) $fields)) {
330 330
                     $field = array_merge($field, $attributes);
331 331
                 }
@@ -355,18 +355,18 @@  discard block
 block discarded – undo
355 355
     {
356 356
         $relationArray = explode('.', $relationString);
357 357
 
358
-        if (! isset($length)) {
358
+        if (!isset($length)) {
359 359
             $length = count($relationArray);
360 360
         }
361 361
 
362
-        if (! isset($model)) {
362
+        if (!isset($model)) {
363 363
             $model = $this->model;
364 364
         }
365 365
 
366
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
366
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
367 367
             try {
368 368
                 $result = $obj->$method();
369
-                if (! $result instanceof Relation) {
369
+                if (!$result instanceof Relation) {
370 370
                     throw new Exception('Not a relation');
371 371
                 }
372 372
                 return $result->getRelated();
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
             if (is_array($entries)) {
402 402
                 //if attribute does not exist in main array we have more than one entry OR the attribute
403 403
                 //is an accessor that is not in $appends property of model.
404
-                if (! isset($entries[$attribute])) {
404
+                if (!isset($entries[$attribute])) {
405 405
                     //we first check if we don't have the attribute because it's an accessor that is not in appends.
406 406
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
407 407
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -440,21 +440,21 @@  discard block
 block discarded – undo
440 440
      */
441 441
     public function parseTranslatableAttributes($model, $attribute, $value)
442 442
     {
443
-        if (! method_exists($model, 'isTranslatableAttribute')) {
443
+        if (!method_exists($model, 'isTranslatableAttribute')) {
444 444
             return $value;
445 445
         }
446 446
 
447
-        if (! $model->isTranslatableAttribute($attribute)) {
447
+        if (!$model->isTranslatableAttribute($attribute)) {
448 448
             return $value;
449 449
         }
450 450
 
451
-        if (! is_array($value)) {
451
+        if (!is_array($value)) {
452 452
             $decodedAttribute = json_decode($value, true) ?? ($value !== null ? [$value] : []);
453 453
         } else {
454 454
             $decodedAttribute = $value;
455 455
         }
456 456
 
457
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
457
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
458 458
             if (isset($decodedAttribute[app()->getLocale()])) {
459 459
                 return $decodedAttribute[app()->getLocale()];
460 460
             } else {
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
         if (method_exists($model, 'translationEnabled') && $model->translationEnabled()) {
473 473
             $locale = $this->getRequest()->input('_locale', app()->getLocale());
474 474
             if (in_array($locale, array_keys($model->getAvailableLocales()))) {
475
-                $model->setLocale(! is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
475
+                $model->setLocale(!is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
476 476
                 $model->useFallbackLocale = (bool) $useFallbackLocale;
477 477
             }
478 478
         }
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
         $relation = $model->{$firstRelationName};
496 496
 
497 497
         $results = [];
498
-        if (! is_null($relation)) {
498
+        if (!is_null($relation)) {
499 499
             if ($relation instanceof Collection) {
500 500
                 $currentResults = $relation->all();
501 501
             } elseif (is_array($relation)) {
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
             array_shift($relationArray);
510 510
 
511
-            if (! empty($relationArray)) {
511
+            if (!empty($relationArray)) {
512 512
                 foreach ($currentResults as $currentResult) {
513 513
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
514 514
                 }
Please login to merge, or discard this patch.