Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#4819)
by Cristian
30:07 queued 15:23
created
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $otherButtons = collect([]);
25 25
 
26 26
         // we get the buttons that belong to the specified stack
27
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
27
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
28 28
             if ($item->stack != $stack) {
29 29
                 // if the button does not belong to this stack we just add it for merging later
30 30
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
         });
37 37
 
38 38
         // we parse the ordered buttons
39
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
40
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
39
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
40
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
41 41
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
42 42
             }
43 43
             $newButtons->push($button);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // we add the remaining buttons to the end of the ordered ones
48 48
         if (count($newButtons) < count($stackButtons)) {
49 49
             foreach ($stackButtons as $button) {
50
-                if (! $newButtons->where('name', $button->name)->first()) {
50
+                if (!$newButtons->where('name', $button->name)->first()) {
51 51
                     $newButtons->push($button);
52 52
                 }
53 53
             }
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
          */
117 117
         $button = $this->buttons()->firstWhere('name', $name);
118 118
 
119
-        if (! $button) {
119
+        if (!$button) {
120 120
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
121 121
         }
122 122
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     public function removeButton($name, $stack = null)
139 139
     {
140
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
140
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
141 141
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
142 142
         }));
143 143
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function removeButtons($names, $stack = null)
150 150
     {
151
-        if (! empty($names)) {
151
+        if (!empty($names)) {
152 152
             foreach ($names as $name) {
153 153
                 $this->removeButton($name, $stack);
154 154
             }
@@ -162,14 +162,14 @@  discard block
 block discarded – undo
162 162
 
163 163
     public function removeAllButtonsFromStack($stack)
164 164
     {
165
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
165
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
166 166
             return $button->stack == $stack;
167 167
         }));
168 168
     }
169 169
 
170 170
     public function removeButtonFromStack($name, $stack)
171 171
     {
172
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
172
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
173 173
             return $button->name == $name && $button->stack == $stack;
174 174
         }));
175 175
     }
@@ -190,15 +190,15 @@  discard block
 block discarded – undo
190 190
         $destinationKey = $this->getButtonKey($destination);
191 191
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
192 192
 
193
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
193
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
194 194
             return $value->name != $target;
195 195
         });
196 196
 
197
-        if (! $targetButton) {
197
+        if (!$targetButton) {
198 198
             return;
199 199
         }
200 200
 
201
-        if (! $destinationButton) {
201
+        if (!$destinationButton) {
202 202
             return;
203 203
         }
204 204
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $newButtons = $firstSlice->push($targetButton);
209 209
    
210
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
210
+        $lastSlice->each(function($item, $key) use ($newButtons) {
211 211
             $newButtons->push($item);
212 212
         });
213 213
 
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
      * @param  string|array  $attributes  Button name or array that contains name, stack, type and content.
273 273
      * @return \Backpack\CRUD\app\Library\CrudPanel\CrudButton
274 274
      */
275
-    public function button(string|array $name)
275
+    public function button(string | array $name)
276 276
     {
277 277
         return new CrudButton('name');
278 278
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
     public function testAddButtonFluently()
286 286
     {
287 287
         $button1 = CrudButton::name('lineTest')->to('line')->view('crud::buttons.test')->type('view');
288
-        $button2 = CrudButton::add('modelFunction')->model_function(function () {
288
+        $button2 = CrudButton::add('modelFunction')->model_function(function() {
289 289
             return 'test';
290 290
         })->section('top')->makeFirst();
291 291
         $this->assertEquals($button1->toArray(), $this->crudPanel->buttons()->last()->toArray());
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
     private function getButtonByName($name)
297 297
     {
298
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
298
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
299 299
             return $value->name == $name;
300 300
         });
301 301
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
         }
41 41
 
42 42
         // check if position is a valid position
43
-        if ($position && ! ButtonPositionEnum::isValid($position)) {
43
+        if ($position && !ButtonPositionEnum::isValid($position)) {
44 44
             throw new \Exception('CRUD Button position "'.$position.'" is not a valid position. Please use one of the following: '.implode(', ', ButtonPositionEnum::getValues()), 500);
45 45
         }
46 46
 
47 47
         // check if stack is a valid stack
48
-        if ($stack && ! ButtonStackEnum::isValid($stack)) {
48
+        if ($stack && !ButtonStackEnum::isValid($stack)) {
49 49
             throw new \Exception('CRUD Button stack "'.$stack.'" is not a valid stack. Please use one of the following: '.implode(', ', ButtonStackEnum::getValues()), 500);
50 50
         }
51 51
 
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
     private function getViewPathsWithFallbacks()
293 293
     {
294 294
         $type = $this->name;
295
-        $paths = array_map(function ($item) use ($type) {
295
+        $paths = array_map(function($item) use ($type) {
296 296
             return $item.'.'.$type;
297 297
         }, ViewNamespaces::getFor('buttons'));
298 298
 
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 
461 461
         $itemExists = $this->collection()->contains('name', $this->name);
462 462
 
463
-        if (! $itemExists) {
463
+        if (!$itemExists) {
464 464
             $this->crud()->addCrudButton($this);
465 465
             if ($this->position == 'beginning') {
466 466
                 $this->before($this->collection()->first()->name);
Please login to merge, or discard this patch.