Laravel-Backpack / CRUD

src/resources/views-elfinder/elfinder.blade.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
     <!-- elFinder JS (REQUIRED) -->
     <script src="<?= asset($dir.'/js/elfinder.min.js') ?>"></script>
 
-    <?php if($locale){ ?>
+    <?php if ($locale) { ?>
         <!-- elFinder translation (OPTIONAL) -->
         <script src="<?= asset($dir."/js/i18n/elfinder.$locale.js") ?>"></script>
     <?php } ?>
@@ -40,7 +40,7 @@ 
         $().ready(function() {
             var elf = $('#elfinder').elfinder({
                 // set your elFinder options here
-                <?php if($locale){ ?>
+                <?php if ($locale) { ?>
                     lang: '<?= $locale ?>', // locale
                 <?php } ?>
                 customData: {

src/resources/views/list.blade.php

Braces +1 added lines, -2 removed lines

@@ -71,8 +71,7 @@
                             if ($results && $results->count()) {
                                 $results_array = $results->lists($column['attribute'], 'id');
                                 echo implode(', ', $results_array->toArray());
-                                }
-                                else
+                                } else
                                 {
                                 echo '-';
                                 }

src/resources/views/reorder.blade.php

Indentation +26 added lines, -26 removed lines

@@ -20,42 +20,42 @@ 
 
 @section('content')
 <?php
-  function tree_element($entry, $key, $all_entries, $crud)
-  {
+    function tree_element($entry, $key, $all_entries, $crud)
+    {
     if (!isset($entry->tree_element_shown)) {
-      // mark the element as shown
-      $all_entries[$key]->tree_element_shown = true;
-      $entry->tree_element_shown = true;
+        // mark the element as shown
+        $all_entries[$key]->tree_element_shown = true;
+        $entry->tree_element_shown = true;
 
-      // show the tree element
-      echo '<li id="list_'.$entry->id.'">';
-      echo '<div><span class="disclose"><span></span></span>'.$entry->{$crud->reorder_label}.'</div>';
+        // show the tree element
+        echo '<li id="list_'.$entry->id.'">';
+        echo '<div><span class="disclose"><span></span></span>'.$entry->{$crud->reorder_label}.'</div>';
 
-      // see if this element has any children
-      $children = [];
-      foreach ($all_entries as $key => $subentry) {
+        // see if this element has any children
+        $children = [];
+        foreach ($all_entries as $key => $subentry) {
         if ($subentry->parent_id == $entry->id) {
-          $children[] = $subentry;
+            $children[] = $subentry;
+        }
         }
-      }
 
-      $children = collect($children)->sortBy('lft');
+        $children = collect($children)->sortBy('lft');
 
-      // if it does have children, show them
-      if (count($children)) {
+        // if it does have children, show them
+        if (count($children)) {
         echo '<ol>';
         foreach ($children as $key => $child) {
-          $children[$key] = tree_element($child, $child->id, $all_entries, $crud);
+            $children[$key] = tree_element($child, $child->id, $all_entries, $crud);
         }
         echo '</ol>';
-      }
-      echo '</li>';
+        }
+        echo '</li>';
     }
 
     return $entry;
-  }
+    }
 
- ?>
+    ?>
 <div class="row">
   <div class="col-md-8 col-md-offset-2">
     @if ($crud->hasAccess('list'))
@@ -87,15 +87,15 @@ 
 
           <ol class="sortable">
             <?php
-              $all_entries = collect($entries->all())->sortBy('lft')->keyBy('id');
-              $root_entries = $all_entries->filter(function($item) {
+                $all_entries = collect($entries->all())->sortBy('lft')->keyBy('id');
+                $root_entries = $all_entries->filter(function($item) {
                 return $item->parent_id == 0;
-              });
-             ?>
+                });
+                ?>
             @foreach ($root_entries as $key => $entry)
               <?php
                 $root_entries[$key] = tree_element($entry, $key, $all_entries, $crud);
-              ?>
+                ?>
             @endforeach
           </ol>
 

src/resources/views/fields/checklist_dependency.blade.php

Spacing +9 added lines, -9 removed lines

@@ -15,15 +15,15 @@ 
       $dependencyArray = [];
 
       //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
-      foreach($dependencies as $primary){
+      foreach ($dependencies as $primary) {
           $dependencyArray[$primary->id] = [];
-        foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
+        foreach ($primary->{$primary_dependency['entity_secondary']} as $secondary) {
             $dependencyArray[$primary->id][] = $secondary->id;
         }
       }
 
       //for update form, get initial state of the entity
-      if( isset($id) && $id ){
+      if (isset($id) && $id) {
         
         //get entity with relations for primary dependency
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
@@ -39,15 +39,15 @@ 
         $secondary_ids = [];
         
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
-        if( old($primary_dependency['name']) ) {
-          foreach( old($primary_dependency['name']) as $primary_item ){
-            foreach($dependencyArray[$primary_item] as $second_item ){
+        if (old($primary_dependency['name'])) {
+          foreach (old($primary_dependency['name']) as $primary_item) {
+            foreach ($dependencyArray[$primary_item] as $second_item) {
                 $secondary_ids[$second_item] = $second_item;
             }
           }
-        }else{ //create dependecies from relation if not from validate error
-          foreach( $primary_array as $primary_item ){
-            foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
+        } else { //create dependecies from relation if not from validate error
+          foreach ($primary_array as $primary_item) {
+            foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
                 $secondary_ids[$second_item['id']] = $second_item['id'];
             }
           }

Braces +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
                 $secondary_ids[$second_item] = $second_item;
             }
           }
-        }else{ //create dependecies from relation if not from validate error
+        } else{ //create dependecies from relation if not from validate error
           foreach( $primary_array as $primary_item ){
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
                 $secondary_ids[$second_item['id']] = $second_item['id'];

Indentation +23 added lines, -23 removed lines

@@ -2,34 +2,34 @@ 
   <div class="form-group checklist_dependency"  data-entity ="{{ $field['field_unique_name'] }}">
     <label>{{ $field['label'] }}</label>
     <?php
-      $entity_model = $crud->getModel();
+        $entity_model = $crud->getModel();
 
-      //short name for dependency fields
-      $primary_dependency = $field['subfields']['primary'];
-      $secondary_dependency = $field['subfields']['secondary'];
+        //short name for dependency fields
+        $primary_dependency = $field['subfields']['primary'];
+        $secondary_dependency = $field['subfields']['secondary'];
 
 
-      //all items with relation
-      $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
+        //all items with relation
+        $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
 
-      $dependencyArray = [];
+        $dependencyArray = [];
 
-      //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
-      foreach($dependencies as $primary){
-          $dependencyArray[$primary->id] = [];
+        //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
+        foreach($dependencies as $primary){
+            $dependencyArray[$primary->id] = [];
         foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
             $dependencyArray[$primary->id][] = $secondary->id;
         }
-      }
+        }
 
-      //for update form, get initial state of the entity
-      if( isset($id) && $id ){
+        //for update form, get initial state of the entity
+        if( isset($id) && $id ){
 
         //get entity with relations for primary dependency
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
-          ->where('id', $id)
-          ->first();
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
+            ->where('id', $id)
+            ->first();
 
         $secondaries_from_primary = [];
 
@@ -40,23 +40,23 @@ 
 
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
         if( old($primary_dependency['name']) ) {
-          foreach( old($primary_dependency['name']) as $primary_item ){
+            foreach( old($primary_dependency['name']) as $primary_item ){
             foreach($dependencyArray[$primary_item] as $second_item ){
                 $secondary_ids[$second_item] = $second_item;
             }
-          }
+            }
         }else{ //create dependecies from relation if not from validate error
-          foreach( $primary_array as $primary_item ){
+            foreach( $primary_array as $primary_item ){
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
                 $secondary_ids[$second_item['id']] = $second_item['id'];
             }
-          }
+            }
         }
 
-      }
+        }
 
-      //json encode of dependency matrix
-      $dependencyJson = json_encode($dependencyArray);
+        //json encode of dependency matrix
+        $dependencyJson = json_encode($dependencyArray);
     ?>
     <script>
      var  {{ $field['field_unique_name'] }} = {!! $dependencyJson !!};

src/resources/views/fields/checklist.blade.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <!-- select2 -->
   <div class="form-group">
     <label>{{ $field['label'] }}</label>
-    <?php $entity_model = $crud->getModel();?>
+    <?php $entity_model = $crud->getModel(); ?>
    
     <div class="row">
         @foreach ($field['model']::all() as $connected_entity_entry)

src/CrudServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 
     private function registerCRUD()
     {
-        $this->app->bind('CRUD', function ($app) {
+        $this->app->bind('CRUD', function($app) {
             return new CRUD($app);
         });
     }

src/Crud.php

Indentation +4 added lines, -4 removed lines

@@ -165,7 +165,7 @@ 
         // TODO
     }
 
-   /*
+    /*
     |--------------------------------------------------------------------------
     |                                   READ
     |--------------------------------------------------------------------------
@@ -246,7 +246,7 @@ 
         $this->details_row = false;
     }
 
-   /*
+    /*
     |--------------------------------------------------------------------------
     |                                   UPDATE
     |--------------------------------------------------------------------------
@@ -306,7 +306,7 @@ 
         return $fields;
     }
 
-   /*
+    /*
     |--------------------------------------------------------------------------
     |                                   DELETE
     |--------------------------------------------------------------------------
@@ -391,7 +391,7 @@ 
         return $this->reorder;
     }
 
-   /*
+    /*
     |--------------------------------------------------------------------------
     |                                   CRUD ACCESS
     |--------------------------------------------------------------------------

Doc Comments +15 added lines, -3 removed lines

@@ -316,6 +316,7 @@ 
      * Delete a row from the database.
      *
      * @param  [int] The id of the item to be deleted.
+     * @param integer $id
      *
      * @return [bool] Deletion confirmation.
      *
@@ -429,8 +430,9 @@ 
      * Check if a permission is enabled for a Crud Panel. Fail if not.
      *
      * @param  [string] Permission.
+     * @param string $permission
      *
-     * @return bool
+     * @return boolean|null
      */
     public function hasAccessOrFail($permission)
     {
@@ -662,6 +664,9 @@ 
         return $this->removeColumns([$column]);
     }
 
+    /**
+     * @param string $entity
+     */
     public function remove($entity, $fields)
     {
         return array_values(array_filter($this->{$entity}, function ($field) use ($fields) { return ! in_array($field['name'], (array) $fields); }));
@@ -713,8 +718,6 @@ 
     /**
      * Add a field to the create/update form or both.
      *
-     * @param [string] $name    Field name (the column name in the db in most cases)
-     * @param [array]  $options Field-type-specific information.
      * @param string   $form    The form to add the field to (create/update/both)
      */
     public function addField($field, $form = 'both')
@@ -1265,6 +1268,9 @@ 
         $this->setSort('fields', (array) $order);
     }
 
+    /**
+     * @param string $type
+     */
     public function sync($type, $fields, $attributes)
     {
         if (! empty($this->{$type})) {
@@ -1278,11 +1284,17 @@ 
         }
     }
 
+    /**
+     * @param string $items
+     */
     public function setSort($items, $order)
     {
         $this->sort[$items] = $order;
     }
 
+    /**
+     * @param string $items
+     */
     public function sort($items)
     {
         if (array_key_exists($items, $this->sort)) {

Spacing +28 added lines, -28 removed lines

@@ -284,7 +284,7 @@ 
 
         foreach ($fields as $k => $field) {
             // set the value
-            if (! isset($fields[$k]['value'])) {
+            if (!isset($fields[$k]['value'])) {
                 if (isset($field['subfields'])) {
                     $fields[$k]['value'] = [];
                     foreach ($field['subfields'] as $key => $subfield) {
@@ -418,7 +418,7 @@ 
      */
     public function hasAccess($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             return false;
         }
 
@@ -453,7 +453,7 @@ 
     public function hasAccessToAll($permission_array)
     {
         foreach ($permission_array as $key => $permission) {
-            if (! in_array($permission, $this->access)) {
+            if (!in_array($permission, $this->access)) {
                 return false;
             }
         }
@@ -470,7 +470,7 @@ 
      */
     public function hasAccessOrFail($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             abort(403, trans('backpack::crud.unauthorized_access'));
         }
     }
@@ -493,7 +493,7 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('This model does not exist.', 404);
         }
 
@@ -537,7 +537,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -623,7 +623,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -674,7 +674,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -705,8 +705,8 @@ 
 
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -771,12 +771,12 @@ 
         }
 
         // if the label is missing, we should set it
-        if (! isset($complete_field_array['label'])) {
+        if (!isset($complete_field_array['label'])) {
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
         }
 
         // if the field type is missing, we should set it
-        if (! isset($complete_field_array['type'])) {
+        if (!isset($complete_field_array['type'])) {
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
         }
 
@@ -838,7 +838,7 @@ 
      */
     public function removeFields($array_of_names, $form = 'both')
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name, $form);
             }
@@ -969,7 +969,7 @@ 
     {
         $this->getDbColumnTypes();
 
-        array_map(function ($field) {
+        array_map(function($field) {
             // $this->labels[$field] = $this->makeLabel($field);
 
             $new_field = [
@@ -983,7 +983,7 @@ 
             $this->create_fields[] = $new_field;
             $this->update_fields[] = $new_field;
 
-            if (! in_array($field, $this->model->getHidden())) {
+            if (!in_array($field, $this->model->getHidden())) {
                 $this->columns[] = [
                                     'name'  => $field,
                                     'label' => ucfirst($field),
@@ -1016,7 +1016,7 @@ 
      */
     public function getFieldTypeFromDbColumnType($field)
     {
-        if (! array_key_exists($field, $this->field_types)) {
+        if (!array_key_exists($field, $this->field_types)) {
             return 'text';
         }
 
@@ -1097,7 +1097,7 @@ 
         $columns = \Schema::getColumnListing($this->model->getTable());
         $fillable = $this->model->getFillable();
 
-        if (! empty($fillable)) {
+        if (!empty($fillable)) {
             $columns = array_intersect($columns, $fillable);
         }
 
@@ -1145,7 +1145,7 @@ 
                     // remove the fake field
                     array_pull($request, $fields[$k]['name']);
 
-                    if (! in_array($fields[$k]['store_in'], $fake_field_columns_to_encode, true)) {
+                    if (!in_array($fields[$k]['store_in'], $fake_field_columns_to_encode, true)) {
                         array_push($fake_field_columns_to_encode, $fields[$k]['store_in']);
                     }
                 } else {
@@ -1156,7 +1156,7 @@ 
                     // remove the fake field
                     array_pull($request, $fields[$k]['name']);
 
-                    if (! in_array('extras', $fake_field_columns_to_encode, true)) {
+                    if (!in_array('extras', $fake_field_columns_to_encode, true)) {
                         array_push($fake_field_columns_to_encode, 'extras');
                     }
                 }
@@ -1199,20 +1199,20 @@ 
             if (isset($fields[$k]['fake']) && $fields[$k]['fake'] == true) {
                 // add it to the request in its appropriate variable - the one defined, if defined
                 if (isset($fields[$k]['store_in'])) {
-                    if (! in_array($fields[$k]['store_in'], $fake_field_columns_to_encode, true)) {
+                    if (!in_array($fields[$k]['store_in'], $fake_field_columns_to_encode, true)) {
                         array_push($fake_field_columns_to_encode, $fields[$k]['store_in']);
                     }
                 } else {
                     //otherwise in the one defined in the $crud variable
 
-                    if (! in_array('extras', $fake_field_columns_to_encode, true)) {
+                    if (!in_array('extras', $fake_field_columns_to_encode, true)) {
                         array_push($fake_field_columns_to_encode, 'extras');
                     }
                 }
             }
         }
 
-        if (! count($fake_field_columns_to_encode)) {
+        if (!count($fake_field_columns_to_encode)) {
             return ['extras'];
         }
 
@@ -1233,7 +1233,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($key, $item) use ($type) {
+        return array_first($array, function($key, $item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -1270,7 +1270,7 @@ 
 
     public function showButtons()
     {
-        return ! empty($this->buttons) && ! (count($this->buttons) == 1 && array_key_exists('add', $this->buttons));
+        return !empty($this->buttons) && !(count($this->buttons) == 1 && array_key_exists('add', $this->buttons));
     }
 
     public function initButtons()
@@ -1309,8 +1309,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -1336,8 +1336,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 

src/CrudTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      *
      * @param array $columns - the database columns that contain the JSONs
      *
-     * @return Model
+     * @return CrudTrait
      */
     public function withFakes($columns = [])
     {

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
         foreach ($columns as $key => $column) {
             $column_contents = $this->{$column};
 
-            if (! is_object($this->{$column})) {
+            if (!is_object($this->{$column})) {
                 $column_contents = json_decode($this->{$column});
             }
 
@@ -75,7 +75,7 @@ 
     {
         $model = '\\'.get_class($this);
 
-        if (! count($columns)) {
+        if (!count($columns)) {
             if (property_exists($model, 'fakeColumns')) {
                 $columns = $this->fakeColumns;
             } else {

src/app/Http/Controllers/CrudController.php

Unused Use Statements +1 added lines, -3 removed lines

@@ -2,14 +2,12 @@
 
 namespace Backpack\CRUD\app\Http\Controllers;
 
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 use Backpack\CRUD\Crud;
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
 // VALIDATION: change the requests to match your own file names if you need form validation
 use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Support\Facades\Form as Form;
 
 class CrudController extends BaseController
 {

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
     {
         $this->crud->hasAccessOrFail('reorder');
 
-        if (! $this->crud->isReorderEnabled()) {
+        if (!$this->crud->isReorderEnabled()) {
             abort(403, 'Reorder is disabled.');
         }