Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-uploaders-tests ( 22787e...b7f78d )
by Pedro
13:08
created
tests/Feature/UploadersValidationTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         $this->assertDatabaseHas('uploaders', [
56 56
             'upload'          => 'avatar.pdf',
57
-            'upload_multiple' => json_encode(['avatar1.pdf',  'avatar2.pdf']),
57
+            'upload_multiple' => json_encode(['avatar1.pdf', 'avatar2.pdf']),
58 58
         ]);
59 59
 
60 60
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar.pdf'));
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $response = $this->put($this->testBaseUrl.'/1', [
91 91
             'upload'                => UploadedFile::fake()->create('avatar4.pdf'),
92 92
             'upload_multiple'       => [UploadedFile::fake()->create('avatar5.pdf'), UploadedFile::fake()->create('avatar6.pdf')],
93
-            'clear_upload_multiple' => ['avatar2.pdf',  'avatar3.pdf'],
93
+            'clear_upload_multiple' => ['avatar2.pdf', 'avatar3.pdf'],
94 94
             'id'                    => 1,
95 95
         ]);
96 96
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 
103 103
         $this->assertDatabaseHas('uploaders', [
104 104
             'upload'          => 'avatar4.pdf',
105
-            'upload_multiple' => json_encode(['avatar5.pdf',  'avatar6.pdf']),
105
+            'upload_multiple' => json_encode(['avatar5.pdf', 'avatar6.pdf']),
106 106
         ]);
107 107
 
108 108
         $files = Storage::disk('uploaders')->allFiles();
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         self::initUploaderWithFiles();
135 135
 
136 136
         $response = $this->put($this->testBaseUrl.'/1', [
137
-            'upload_multiple' => ['avatar2.pdf',  'avatar3.pdf'],
137
+            'upload_multiple' => ['avatar2.pdf', 'avatar3.pdf'],
138 138
             'id'              => 1,
139 139
         ]);
140 140
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
         $this->assertDatabaseHas('uploaders', [
148 148
             'upload'          => 'avatar1.pdf',
149
-            'upload_multiple' => json_encode(['avatar2.pdf',  'avatar3.pdf']),
149
+            'upload_multiple' => json_encode(['avatar2.pdf', 'avatar3.pdf']),
150 150
         ]);
151 151
 
152 152
         $files = Storage::disk('uploaders')->allFiles();
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 
177 177
         $this->assertDatabaseHas('uploaders', [
178 178
             'upload'          => 'avatar1.pdf',
179
-            'upload_multiple' => json_encode(['avatar3.pdf', 'avatar4.pdf',  'avatar5.pdf']),
179
+            'upload_multiple' => json_encode(['avatar3.pdf', 'avatar4.pdf', 'avatar5.pdf']),
180 180
         ]);
181 181
 
182 182
         $files = Storage::disk('uploaders')->allFiles();
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
         $response = $this->put($this->testBaseUrl.'/1', [
335 335
             'upload'          => null,
336 336
             'upload_multiple' => null,
337
-            'clear_upload_multiple' => ['avatar2.pdf',  'avatar3.pdf'],
337
+            'clear_upload_multiple' => ['avatar2.pdf', 'avatar3.pdf'],
338 338
             'id'              => 1,
339 339
         ]);
340 340
 
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
 
358 358
         $response = $this->put($this->testBaseUrl.'/1', [
359 359
             'upload_multiple' => [UploadedFile::fake()->create('avatar1.pdf')],
360
-            'clear_upload_multiple' => ['avatar2.pdf',  'avatar3.pdf'],
360
+            'clear_upload_multiple' => ['avatar2.pdf', 'avatar3.pdf'],
361 361
             'id'              => 1,
362 362
         ]);
363 363
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 
380 380
         Uploader::create([
381 381
             'upload'          => 'avatar1.jpg',
382
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
382
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
383 383
         ]);
384 384
     }
385 385
 
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 
392 392
         Uploader::create([
393 393
             'upload'          => 'avatar1.pdf',
394
-            'upload_multiple' => json_encode(['avatar2.pdf',  'avatar3.pdf']),
394
+            'upload_multiple' => json_encode(['avatar2.pdf', 'avatar3.pdf']),
395 395
         ]);
396 396
     }
397 397
 
Please login to merge, or discard this patch.
tests/Feature/UploadersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         $this->assertDatabaseHas('uploaders', [
62 62
             'upload'          => 'avatar.jpg',
63
-            'upload_multiple' => json_encode(['avatar1.jpg',  'avatar2.jpg']),
63
+            'upload_multiple' => json_encode(['avatar1.jpg', 'avatar2.jpg']),
64 64
         ]);
65 65
 
66 66
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar.jpg'));
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         $response = $this->put($this->testBaseUrl.'/1', [
96 96
             'upload'                => UploadedFile::fake()->image('avatar4.jpg'),
97 97
             'upload_multiple'       => [UploadedFile::fake()->image('avatar5.jpg'), UploadedFile::fake()->image('avatar6.jpg')],
98
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
98
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
99 99
             'id'                    => 1,
100 100
         ]);
101 101
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
         $this->assertDatabaseHas('uploaders', [
109 109
             'upload'          => 'avatar4.jpg',
110
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
110
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
111 111
         ]);
112 112
 
113 113
         $files = Storage::disk('uploaders')->allFiles();
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 
137 137
         $this->assertDatabaseHas('uploaders', [
138 138
             'upload'          => null,
139
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
139
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
140 140
         ]);
141 141
 
142 142
         $files = Storage::disk('uploaders')->allFiles();
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         self::initUploaderWithFiles();
167 167
 
168 168
         $response = $this->put($this->testBaseUrl.'/1', [
169
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
169
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
170 170
             'id'              => 1,
171 171
         ]);
172 172
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
         $this->assertDatabaseHas('uploaders', [
180 180
             'upload'          => 'avatar1.jpg',
181
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
181
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
182 182
         ]);
183 183
 
184 184
         $files = Storage::disk('uploaders')->allFiles();
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 
209 209
         $this->assertDatabaseHas('uploaders', [
210 210
             'upload'          => 'avatar1.jpg',
211
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
211
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
212 212
         ]);
213 213
 
214 214
         $files = Storage::disk('uploaders')->allFiles();
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
 
230 230
         Uploader::create([
231 231
             'upload'          => 'avatar1.jpg',
232
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
232
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
233 233
         ]);
234 234
     }
235 235
 
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@  discard block
 block discarded – undo
21 21
         }
22 22
 
23 23
         $previousValues = str_contains($attribute, '.') ?
24
-                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) :
25
-                            ($entry?->{$attribute} ?? []);
24
+                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) : ($entry?->{$attribute} ?? []);
26 25
 
27 26
         if (is_string($previousValues)) {
28 27
             $previousValues = json_decode($previousValues, true) ?? [];
@@ -39,7 +38,7 @@  discard block
 block discarded – undo
39 38
        
40 39
         // if there is no entry, the values we are going to validate need to be files
41 40
         // the request was tampered so we will set the attribute to null
42
-        if (! $entry && ! empty(Arr::get($data, $attribute)) && ! $this->allFiles(Arr::get($data, $attribute))) {
41
+        if (!$entry && !empty(Arr::get($data, $attribute)) && !$this->allFiles(Arr::get($data, $attribute))) {
43 42
             Arr::set($data, $attribute, null);
44 43
         }
45 44
 
@@ -50,7 +49,7 @@  discard block
 block discarded – undo
50 49
     private function allFiles(array $values): bool
51 50
     {
52 51
         foreach ($values as $value) {
53
-            if (! $value instanceof \Illuminate\Http\UploadedFile) {
52
+            if (!$value instanceof \Illuminate\Http\UploadedFile) {
54 53
                 return false;
55 54
             }
56 55
         }
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUpload.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
         // if the attribute is not set in the request, and an entry exists,
22 22
         // we will check if there is a previous value, as this field might not have changed.
23
-        if (! Arr::has($this->data, $attribute) && $entry) {
23
+        if (!Arr::has($this->data, $attribute) && $entry) {
24 24
             if (str_contains($attribute, '.') && get_class($entry) === get_class(CrudPanelFacade::getModel())) {
25 25
                 $previousValue = Arr::get($this->data, '_order_'.Str::before($attribute, '.'));
26 26
                 $previousValue = Arr::get($previousValue, Str::after($attribute, '.'));
@@ -37,25 +37,25 @@  discard block
 block discarded – undo
37 37
 
38 38
         // if the value is an uploaded file, or the attribute is not
39 39
         // set in the request, we force fill the data with the value
40
-        if ($value instanceof UploadedFile || ! Arr::has($this->data, $attribute)) {
40
+        if ($value instanceof UploadedFile || !Arr::has($this->data, $attribute)) {
41 41
             Arr::set($this->data, $attribute, $value);
42 42
         }
43 43
 
44 44
         // if there are no entry, and the new value it's not a file ... well we don't want it at all.
45
-        if (! $entry && ! $value instanceof UploadedFile) {
45
+        if (!$entry && !$value instanceof UploadedFile) {
46 46
             Arr::set($this->data, $attribute, null);
47 47
         }
48 48
         
49 49
         $fieldErrors = $this->validateFieldRules($attribute);
50 50
 
51
-        if (! empty($value) && ! empty($this->getFileRules())) {
51
+        if (!empty($value) && !empty($this->getFileRules())) {
52 52
             $fileErrors = $this->validateFileRules($attribute, $value);
53 53
         }
54 54
 
55 55
         return array_merge($fieldErrors, $fileErrors ?? []);
56 56
     }
57 57
 
58
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
58
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
59 59
     {
60 60
         return parent::field($rules);
61 61
     }
Please login to merge, or discard this patch.