We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -87,12 +87,12 @@ |
||
| 87 | 87 | |
| 88 | 88 | $section = $this->context()->composerRequirementSection('backpack/crud') ?? 'require'; |
| 89 | 89 | |
| 90 | - $updated = $this->context()->updateComposerJson(function (array &$composer) use ($section, $targetConstraint) { |
|
| 90 | + $updated = $this->context()->updateComposerJson(function(array &$composer) use ($section, $targetConstraint) { |
|
| 91 | 91 | $composer[$section] = $composer[$section] ?? []; |
| 92 | 92 | $composer[$section]['backpack/crud'] = $targetConstraint; |
| 93 | 93 | }); |
| 94 | 94 | |
| 95 | - if (! $updated) { |
|
| 95 | + if (!$updated) { |
|
| 96 | 96 | return StepResult::failure('Could not update composer.json automatically.'); |
| 97 | 97 | } |
| 98 | 98 | |
@@ -37,11 +37,11 @@ |
||
| 37 | 37 | |
| 38 | 38 | public function fix(StepResult $result): StepResult |
| 39 | 39 | { |
| 40 | - $updated = $this->context()->updateComposerJson(function (array &$composer) { |
|
| 40 | + $updated = $this->context()->updateComposerJson(function(array &$composer) { |
|
| 41 | 41 | $composer['minimum-stability'] = 'beta'; |
| 42 | 42 | }); |
| 43 | 43 | |
| 44 | - if (! $updated) { |
|
| 44 | + if (!$updated) { |
|
| 45 | 45 | return StepResult::failure('Could not update minimum-stability automatically.'); |
| 46 | 46 | } |
| 47 | 47 | |
@@ -46,7 +46,7 @@ discard block |
||
| 46 | 46 | continue; |
| 47 | 47 | } |
| 48 | 48 | |
| 49 | - if (! $this->matchesExpectedConstraint($constraint, $expectedConstraint)) { |
|
| 49 | + if (!$this->matchesExpectedConstraint($constraint, $expectedConstraint)) { |
|
| 50 | 50 | $this->mismatched[] = [ |
| 51 | 51 | 'package' => $package, |
| 52 | 52 | 'current' => $constraint, |
@@ -93,7 +93,7 @@ discard block |
||
| 93 | 93 | |
| 94 | 94 | public function canFix(StepResult $result): bool |
| 95 | 95 | { |
| 96 | - return $result->status === StepStatus::Warning && ! empty($this->mismatched); |
|
| 96 | + return $result->status === StepStatus::Warning && !empty($this->mismatched); |
|
| 97 | 97 | } |
| 98 | 98 | |
| 99 | 99 | public function fix(StepResult $result): StepResult |
@@ -104,7 +104,7 @@ discard block |
||
| 104 | 104 | |
| 105 | 105 | $mismatched = $this->mismatched; |
| 106 | 106 | |
| 107 | - $updated = $this->context()->updateComposerJson(function (array &$composer) use ($mismatched) { |
|
| 107 | + $updated = $this->context()->updateComposerJson(function(array &$composer) use ($mismatched) { |
|
| 108 | 108 | foreach ($mismatched as $item) { |
| 109 | 109 | $section = $item['section'] ?? 'require'; |
| 110 | 110 | $composer[$section] = $composer[$section] ?? []; |
@@ -112,7 +112,7 @@ discard block |
||
| 112 | 112 | } |
| 113 | 113 | }); |
| 114 | 114 | |
| 115 | - if (! $updated) { |
|
| 115 | + if (!$updated) { |
|
| 116 | 116 | return StepResult::failure('Could not update composer.json automatically.'); |
| 117 | 117 | } |
| 118 | 118 | |
@@ -29,7 +29,7 @@ discard block |
||
| 29 | 29 | foreach ($this->operationFiles as $filename) { |
| 30 | 30 | $relativePath = 'config/backpack/operations/'.$filename; |
| 31 | 31 | |
| 32 | - if (! $this->context()->fileExists($relativePath)) { |
|
| 32 | + if (!$this->context()->fileExists($relativePath)) { |
|
| 33 | 33 | continue; |
| 34 | 34 | } |
| 35 | 35 | |
@@ -47,7 +47,7 @@ discard block |
||
| 47 | 47 | $this->flattenKeys($publishedConfig) |
| 48 | 48 | ); |
| 49 | 49 | |
| 50 | - if (! empty($missingKeys)) { |
|
| 50 | + if (!empty($missingKeys)) { |
|
| 51 | 51 | sort($missingKeys); |
| 52 | 52 | |
| 53 | 53 | $issues[] = sprintf('Add the missing keys to %s:', $relativePath); |
@@ -64,7 +64,7 @@ discard block |
||
| 64 | 64 | } |
| 65 | 65 | } |
| 66 | 66 | |
| 67 | - if (! $checkedAny) { |
|
| 67 | + if (!$checkedAny) { |
|
| 68 | 68 | return StepResult::skipped('Operation config files are not published.'); |
| 69 | 69 | } |
| 70 | 70 | |
@@ -80,7 +80,7 @@ discard block |
||
| 80 | 80 | |
| 81 | 81 | private function loadConfigArray(string $path): ?array |
| 82 | 82 | { |
| 83 | - if (! is_file($path)) { |
|
| 83 | + if (!is_file($path)) { |
|
| 84 | 84 | return null; |
| 85 | 85 | } |
| 86 | 86 | |
@@ -22,7 +22,7 @@ |
||
| 22 | 22 | return StepResult::skipped('show.php is not published, core defaults already use the new datagrid component.'); |
| 23 | 23 | } |
| 24 | 24 | |
| 25 | - if (! str_contains($contents, "'component'")) { |
|
| 25 | + if (!str_contains($contents, "'component'")) { |
|
| 26 | 26 | return StepResult::warning( |
| 27 | 27 | "Add the 'component' option to config/backpack/operations/show.php to pick between bp-datagrid and bp-datalist.", |
| 28 | 28 | ['Example: "component" => "bp-datagrid"'] |
@@ -51,7 +51,7 @@ discard block |
||
| 51 | 51 | |
| 52 | 52 | public function canFix(StepResult $result): bool |
| 53 | 53 | { |
| 54 | - return $result->status === StepStatus::Warning && $this->currentContents !== null && ! empty($this->issues); |
|
| 54 | + return $result->status === StepStatus::Warning && $this->currentContents !== null && !empty($this->issues); |
|
| 55 | 55 | } |
| 56 | 56 | |
| 57 | 57 | public function fix(StepResult $result): StepResult |
@@ -87,11 +87,11 @@ discard block |
||
| 87 | 87 | |
| 88 | 88 | $updated = preg_replace('/^base_path/m', ' base_path', $updated); |
| 89 | 89 | |
| 90 | - if (! $changed) { |
|
| 90 | + if (!$changed) { |
|
| 91 | 91 | return StepResult::failure('Could not adjust Tabler config automatically.'); |
| 92 | 92 | } |
| 93 | 93 | |
| 94 | - if (! $this->context()->writeFile($this->relativePath, $updated)) { |
|
| 94 | + if (!$this->context()->writeFile($this->relativePath, $updated)) { |
|
| 95 | 95 | return StepResult::failure('Failed writing changes to config/backpack/theme-tabler.php.'); |
| 96 | 96 | } |
| 97 | 97 | |
@@ -64,7 +64,7 @@ discard block |
||
| 64 | 64 | |
| 65 | 65 | $fullPath = $this->basePath($relativePath); |
| 66 | 66 | |
| 67 | - if (! $this->files->exists($fullPath)) { |
|
| 67 | + if (!$this->files->exists($fullPath)) { |
|
| 68 | 68 | return null; |
| 69 | 69 | } |
| 70 | 70 | |
@@ -77,13 +77,13 @@ discard block |
||
| 77 | 77 | |
| 78 | 78 | public function composerJson(): array |
| 79 | 79 | { |
| 80 | - if (! empty($this->composerJson)) { |
|
| 80 | + if (!empty($this->composerJson)) { |
|
| 81 | 81 | return $this->composerJson; |
| 82 | 82 | } |
| 83 | 83 | |
| 84 | 84 | $content = $this->readFile('composer.json'); |
| 85 | 85 | |
| 86 | - if (! $content) { |
|
| 86 | + if (!$content) { |
|
| 87 | 87 | return $this->composerJson = []; |
| 88 | 88 | } |
| 89 | 89 | |
@@ -126,7 +126,7 @@ discard block |
||
| 126 | 126 | |
| 127 | 127 | public function installedPackageVersion(string $package): ?string |
| 128 | 128 | { |
| 129 | - if (! InstalledVersions::isInstalled($package)) { |
|
| 129 | + if (!InstalledVersions::isInstalled($package)) { |
|
| 130 | 130 | return null; |
| 131 | 131 | } |
| 132 | 132 | |
@@ -135,7 +135,7 @@ discard block |
||
| 135 | 135 | |
| 136 | 136 | public function installedPackagePrettyVersion(string $package): ?string |
| 137 | 137 | { |
| 138 | - if (! InstalledVersions::isInstalled($package)) { |
|
| 138 | + if (!InstalledVersions::isInstalled($package)) { |
|
| 139 | 139 | return null; |
| 140 | 140 | } |
| 141 | 141 | |
@@ -146,7 +146,7 @@ discard block |
||
| 146 | 146 | { |
| 147 | 147 | $pretty = $this->installedPackagePrettyVersion($package); |
| 148 | 148 | |
| 149 | - if (! $pretty) { |
|
| 149 | + if (!$pretty) { |
|
| 150 | 150 | return null; |
| 151 | 151 | } |
| 152 | 152 | |
@@ -174,7 +174,7 @@ discard block |
||
| 174 | 174 | foreach ($directories as $directory) { |
| 175 | 175 | $absoluteDirectory = $this->resolvePath($directory); |
| 176 | 176 | |
| 177 | - if (! $this->files->isDirectory($absoluteDirectory)) { |
|
| 177 | + if (!$this->files->isDirectory($absoluteDirectory)) { |
|
| 178 | 178 | continue; |
| 179 | 179 | } |
| 180 | 180 | |
@@ -279,7 +279,7 @@ discard block |
||
| 279 | 279 | { |
| 280 | 280 | $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION)); |
| 281 | 281 | |
| 282 | - if (! in_array($extension, $this->searchableExtensions, true)) { |
|
| 282 | + if (!in_array($extension, $this->searchableExtensions, true)) { |
|
| 283 | 283 | return true; |
| 284 | 284 | } |
| 285 | 285 | |
@@ -21,7 +21,7 @@ discard block |
||
| 21 | 21 | { |
| 22 | 22 | $format = $this->outputFormat(); |
| 23 | 23 | |
| 24 | - if (! in_array($format, ['cli', 'json'], true)) { |
|
| 24 | + if (!in_array($format, ['cli', 'json'], true)) { |
|
| 25 | 25 | $this->errorBlock(sprintf('Unknown output format "%s". Supported formats: cli, json.', $format)); |
| 26 | 26 | |
| 27 | 27 | return Command::INVALID; |
@@ -74,7 +74,7 @@ discard block |
||
| 74 | 74 | $this->closeProgressBlock(strtoupper($fixResult->status->label()), $fixResult->status->color()); |
| 75 | 75 | $this->printResultDetails($fixResult); |
| 76 | 76 | |
| 77 | - if (! $fixResult->status->isFailure()) { |
|
| 77 | + if (!$fixResult->status->isFailure()) { |
|
| 78 | 78 | $this->progressBlock('Re-running '.$step->title()); |
| 79 | 79 | |
| 80 | 80 | try { |
@@ -111,14 +111,14 @@ discard block |
||
| 111 | 111 | { |
| 112 | 112 | $format = $this->outputFormat(); |
| 113 | 113 | |
| 114 | - $hasFailure = collect($results)->contains(function ($entry) { |
|
| 114 | + $hasFailure = collect($results)->contains(function($entry) { |
|
| 115 | 115 | /** @var StepResult $result */ |
| 116 | 116 | $result = $entry['result']; |
| 117 | 117 | |
| 118 | 118 | return $result->status->isFailure(); |
| 119 | 119 | }); |
| 120 | 120 | |
| 121 | - $warnings = collect($results)->filter(function ($entry) { |
|
| 121 | + $warnings = collect($results)->filter(function($entry) { |
|
| 122 | 122 | /** @var StepResult $result */ |
| 123 | 123 | $result = $entry['result']; |
| 124 | 124 | |
@@ -128,7 +128,7 @@ discard block |
||
| 128 | 128 | if ($format === 'json') { |
| 129 | 129 | $payload = [ |
| 130 | 130 | 'version' => $majorVersion, |
| 131 | - 'results' => collect($results)->map(function ($entry) { |
|
| 131 | + 'results' => collect($results)->map(function($entry) { |
|
| 132 | 132 | /** @var StepResult $result */ |
| 133 | 133 | $result = $entry['result']; |
| 134 | 134 | |
@@ -160,7 +160,7 @@ discard block |
||
| 160 | 160 | $this->note(sprintf('%d step(s) reported warnings.', $warnings->count()), 'yellow', 'yellow'); |
| 161 | 161 | } |
| 162 | 162 | |
| 163 | - if (! $hasFailure && $warnings->isEmpty()) { |
|
| 163 | + if (!$hasFailure && $warnings->isEmpty()) { |
|
| 164 | 164 | $this->note('All checks passed, you are ready to continue with the manual steps from the upgrade guide.', 'green', 'green'); |
| 165 | 165 | } |
| 166 | 166 | |
@@ -195,11 +195,11 @@ discard block |
||
| 195 | 195 | return false; |
| 196 | 196 | } |
| 197 | 197 | |
| 198 | - if (! $this->input->isInteractive()) { |
|
| 198 | + if (!$this->input->isInteractive()) { |
|
| 199 | 199 | return false; |
| 200 | 200 | } |
| 201 | 201 | |
| 202 | - if (! in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) { |
|
| 202 | + if (!in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) { |
|
| 203 | 203 | return false; |
| 204 | 204 | } |
| 205 | 205 | |