We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -326,8 +326,6 @@ discard block |
||
326 | 326 | * Check if the create/update form has upload fields. |
327 | 327 | * Upload fields are the ones that have "upload" => true defined on them. |
328 | 328 | * |
329 | - * @param string $form create/update/both - defaults to 'both' |
|
330 | - * @param bool|int $id id of the entity - defaults to false |
|
331 | 329 | * |
332 | 330 | * @return bool |
333 | 331 | */ |
@@ -358,7 +356,7 @@ discard block |
||
358 | 356 | /** |
359 | 357 | * Set an array of field type names as already loaded for the current operation. |
360 | 358 | * |
361 | - * @param array $fieldTypes |
|
359 | + * @param string[] $fieldTypes |
|
362 | 360 | */ |
363 | 361 | public function setLoadedFieldTypes($fieldTypes) |
364 | 362 | { |
@@ -369,7 +367,7 @@ discard block |
||
369 | 367 | * Get a namespaced version of the field type name. |
370 | 368 | * Appends the 'view_namespace' attribute of the field to the `type', using dot notation. |
371 | 369 | * |
372 | - * @param mixed $field |
|
370 | + * @param string $field |
|
373 | 371 | * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text' |
374 | 372 | */ |
375 | 373 | public function getFieldTypeWithNamespace($field) |
@@ -55,7 +55,7 @@ discard block |
||
55 | 55 | */ |
56 | 56 | public function afterField($targetFieldName) |
57 | 57 | { |
58 | - $this->transformFields(function ($fields) use ($targetFieldName) { |
|
58 | + $this->transformFields(function($fields) use ($targetFieldName) { |
|
59 | 59 | return $this->moveField($fields, $targetFieldName, false); |
60 | 60 | }); |
61 | 61 | } |
@@ -67,7 +67,7 @@ discard block |
||
67 | 67 | */ |
68 | 68 | public function beforeField($targetFieldName) |
69 | 69 | { |
70 | - $this->transformFields(function ($fields) use ($targetFieldName) { |
|
70 | + $this->transformFields(function($fields) use ($targetFieldName) { |
|
71 | 71 | return $this->moveField($fields, $targetFieldName, true); |
72 | 72 | }); |
73 | 73 | } |
@@ -79,7 +79,7 @@ discard block |
||
79 | 79 | */ |
80 | 80 | public function removeField($name) |
81 | 81 | { |
82 | - $this->transformFields(function ($fields) use ($name) { |
|
82 | + $this->transformFields(function($fields) use ($name) { |
|
83 | 83 | array_forget($fields, $name); |
84 | 84 | |
85 | 85 | return $fields; |
@@ -93,7 +93,7 @@ discard block |
||
93 | 93 | */ |
94 | 94 | public function removeFields($array_of_names) |
95 | 95 | { |
96 | - if (! empty($array_of_names)) { |
|
96 | + if (!empty($array_of_names)) { |
|
97 | 97 | foreach ($array_of_names as $name) { |
98 | 98 | $this->removeField($name); |
99 | 99 | } |
@@ -106,7 +106,7 @@ discard block |
||
106 | 106 | public function removeAllFields() |
107 | 107 | { |
108 | 108 | $current_fields = $this->getCurrentFields(); |
109 | - if (! empty($current_fields)) { |
|
109 | + if (!empty($current_fields)) { |
|
110 | 110 | foreach ($current_fields as $field) { |
111 | 111 | $this->removeField($field['name']); |
112 | 112 | } |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | $jsonCastables = ['array', 'object', 'json']; |
181 | 181 | $fieldCasting = $casted_attributes[$field['name']]; |
182 | 182 | |
183 | - if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) { |
|
183 | + if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) { |
|
184 | 184 | try { |
185 | 185 | $data[$field['name']] = json_decode($data[$field['name']]); |
186 | 186 | } catch (\Exception $e) { |
@@ -209,7 +209,7 @@ discard block |
||
209 | 209 | */ |
210 | 210 | public function orderFields($order) |
211 | 211 | { |
212 | - $this->transformFields(function ($fields) use ($order) { |
|
212 | + $this->transformFields(function($fields) use ($order) { |
|
213 | 213 | return $this->applyOrderToFields($fields, $order); |
214 | 214 | }); |
215 | 215 | } |
@@ -236,7 +236,7 @@ discard block |
||
236 | 236 | public function hasUploadFields() |
237 | 237 | { |
238 | 238 | $fields = $this->getFields(); |
239 | - $upload_fields = array_where($fields, function ($value, $key) { |
|
239 | + $upload_fields = array_where($fields, function($value, $key) { |
|
240 | 240 | return isset($value['upload']) && $value['upload'] == true; |
241 | 241 | }); |
242 | 242 | |
@@ -299,7 +299,7 @@ discard block |
||
299 | 299 | $alreadyLoaded = $this->getLoadedFieldTypes(); |
300 | 300 | $type = $this->getFieldTypeWithNamespace($field); |
301 | 301 | |
302 | - if (! in_array($type, $this->getLoadedFieldTypes(), true)) { |
|
302 | + if (!in_array($type, $this->getLoadedFieldTypes(), true)) { |
|
303 | 303 | $alreadyLoaded[] = $type; |
304 | 304 | $this->setLoadedFieldTypes($alreadyLoaded); |
305 | 305 | |
@@ -340,7 +340,7 @@ discard block |
||
340 | 340 | */ |
341 | 341 | public function fieldTypeNotLoaded($field) |
342 | 342 | { |
343 | - return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes()); |
|
343 | + return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes()); |
|
344 | 344 | } |
345 | 345 | |
346 | 346 | /** |
@@ -52,9 +52,9 @@ |
||
52 | 52 | public function checkIfFieldNameBelongsToAnyRelation($fieldName) |
53 | 53 | { |
54 | 54 | $relations = $this->getAvailableRelationsInModel(); |
55 | - if (! empty($relations)) { |
|
55 | + if (!empty($relations)) { |
|
56 | 56 | if (in_array($fieldName, array_column($relations, 'name'))) { |
57 | - return array_filter($relations, function ($arr) use ($fieldName) { |
|
57 | + return array_filter($relations, function($arr) use ($fieldName) { |
|
58 | 58 | if (isset($arr['name'])) { |
59 | 59 | return $arr['name'] == $fieldName; |
60 | 60 | } |
@@ -155,7 +155,7 @@ |
||
155 | 155 | * Based on relation type returns if relation allows multiple entities. |
156 | 156 | * |
157 | 157 | * @param string $relationType |
158 | - * @return bool |
|
158 | + * @return boolean|null |
|
159 | 159 | */ |
160 | 160 | public function relationAllowsMultiple($relationType) |
161 | 161 | { |
@@ -57,7 +57,7 @@ discard block |
||
57 | 57 | */ |
58 | 58 | public function getInlineCreateModal() |
59 | 59 | { |
60 | - if (! request()->has('entity')) { |
|
60 | + if (!request()->has('entity')) { |
|
61 | 61 | abort(400, 'No "entity" inside the request.'); |
62 | 62 | } |
63 | 63 | |
@@ -80,17 +80,17 @@ discard block |
||
80 | 80 | */ |
81 | 81 | public function inlineRefreshOptions() |
82 | 82 | { |
83 | - if (! request()->has('field')) { |
|
83 | + if (!request()->has('field')) { |
|
84 | 84 | abort(400, 'No "field" inside the request.'); |
85 | 85 | } |
86 | 86 | |
87 | 87 | $field = $this->crud->fields()[request()->get('field')]; |
88 | 88 | $options = []; |
89 | 89 | |
90 | - if (! empty($field)) { |
|
90 | + if (!empty($field)) { |
|
91 | 91 | $relatedModelInstance = new $field['model'](); |
92 | 92 | |
93 | - if (! isset($field['options'])) { |
|
93 | + if (!isset($field['options'])) { |
|
94 | 94 | $options = $field['model']::all()->pluck($field['attribute'], $relatedModelInstance->getKeyName()); |
95 | 95 | } else { |
96 | 96 | $options = call_user_func($field['options'], $field['model']::query()->pluck($field['attribute'], $relatedModelInstance->getKeyName())); |
@@ -13,7 +13,6 @@ |
||
13 | 13 | use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeColumns; |
14 | 14 | use Backpack\CRUD\app\Library\CrudPanel\Traits\FakeFields; |
15 | 15 | use Backpack\CRUD\app\Library\CrudPanel\Traits\Fields; |
16 | -use Backpack\CRUD\app\Library\CrudPanel\Traits\FieldsPrivateMethods; |
|
17 | 16 | use Backpack\CRUD\app\Library\CrudPanel\Traits\FieldsProtectedMethods; |
18 | 17 | use Backpack\CRUD\app\Library\CrudPanel\Traits\Filters; |
19 | 18 | use Backpack\CRUD\app\Library\CrudPanel\Traits\HeadingsAndTitles; |
@@ -60,7 +60,7 @@ discard block |
||
60 | 60 | { |
61 | 61 | // if this is a relation type field and no corresponding model was specified, |
62 | 62 | // get it from the relation method defined in the main model |
63 | - if (isset($field['entity']) && ! isset($field['model'])) { |
|
63 | + if (isset($field['entity']) && !isset($field['model'])) { |
|
64 | 64 | $field['model'] = $this->getRelationModel($field['entity']); |
65 | 65 | } |
66 | 66 | |
@@ -70,7 +70,7 @@ discard block |
||
70 | 70 | protected function makeSureFieldHasLabel($field) |
71 | 71 | { |
72 | 72 | // if the label is missing, we should set it |
73 | - if (! isset($field['label'])) { |
|
73 | + if (!isset($field['label'])) { |
|
74 | 74 | $label = is_array($field['name']) ? $field['name'][0] : $field['name']; |
75 | 75 | $field['label'] = mb_ucfirst(str_replace('_', ' ', $label)); |
76 | 76 | } |
@@ -81,7 +81,7 @@ discard block |
||
81 | 81 | protected function makeSureFieldHasType($field) |
82 | 82 | { |
83 | 83 | // if the field type is missing, we should set it |
84 | - if (! isset($field['type'])) { |
|
84 | + if (!isset($field['type'])) { |
|
85 | 85 | $field['type'] = $this->getFieldTypeFromDbColumnType($field['name']); |
86 | 86 | } |
87 | 87 | |
@@ -92,7 +92,7 @@ discard block |
||
92 | 92 | { |
93 | 93 | // if a tab was mentioned, we should enable it |
94 | 94 | if (isset($field['tab'])) { |
95 | - if (! $this->tabsEnabled()) { |
|
95 | + if (!$this->tabsEnabled()) { |
|
96 | 96 | $this->enableTabs(); |
97 | 97 | } |
98 | 98 | } |