View GitHub Repository CRUD

Schedule Inspection
Subscribe

Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#898)
by Cristian
02:33
created
Status
Category
Toggle Patches
src/PanelTraits/Filters.php 2 patches
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -66,20 +66,20 @@
 
 block discarded – undo
66 66
67 67 
         // if a closure was passed as "filter_logic"
68 68 
         if ($this->doingListOperation()) {
69 
-	        if ( $this->request->has( $options['name'] ) ) {
70 
-		        if ( is_callable( $filter_logic ) ) {
71 
-			        // apply it
72 
-			        $filter_logic( $this->request->input( $options['name'] ) );
73 
-		        } else {
74 
-			        $this->addDefaultFilterLogic( $filter->name, $filter_logic );
75 
-		        }
76 
-	        } else {
77 
-		        //if the filter is not active, but fallback logic was supplied
78 
-		        if ( is_callable( $fallback_logic ) ) {
79 
-			        // apply the fallback logic
80 
-			        $fallback_logic();
81 
-		        }
82 
-	        }
69 
+            if ( $this->request->has( $options['name'] ) ) {
70 
+                if ( is_callable( $filter_logic ) ) {
71 
+                    // apply it
72 
+                    $filter_logic( $this->request->input( $options['name'] ) );
73 
+                } else {
74 
+                    $this->addDefaultFilterLogic( $filter->name, $filter_logic );
75 
+                }
76 
+            } else {
77 
+                //if the filter is not active, but fallback logic was supplied
78 
+                if ( is_callable( $fallback_logic ) ) {
79 
+                    // apply the fallback logic
80 
+                    $fallback_logic();
81 
+                }
82 
+            }
83 83 
         }
84 84 
     }
85 85
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8
9 9 
     public function filtersEnabled()
10 10 
     {
11 
-        return ! is_array($this->filters);
11 
+        return !is_array($this->filters);
12 12 
     }
13 13
14 14 
     public function filtersDisabled()
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
         $this->enableFilters();
54 54
55 55 
         // check if another filter with the same name exists
56 
-        if (! isset($options['name'])) {
56 
+        if (!isset($options['name'])) {
57 57 
             abort(500, 'All your filters need names.');
58 58 
         }
59 59 
         if ($this->filters->contains('name', $options['name'])) {
 
@@ -66,16 +66,16 @@  discard block
 
 block discarded – undo
66 66
67 67 
         // if a closure was passed as "filter_logic"
68 68 
         if ($this->doingListOperation()) {
69 
-	        if ( $this->request->has( $options['name'] ) ) {
70 
-		        if ( is_callable( $filter_logic ) ) {
69 
+	        if ($this->request->has($options['name'])) {
70 
+		        if (is_callable($filter_logic)) {
71 71 
 			        // apply it
72 
-			        $filter_logic( $this->request->input( $options['name'] ) );
72 
+			        $filter_logic($this->request->input($options['name']));
73 73 
 		        } else {
74 
-			        $this->addDefaultFilterLogic( $filter->name, $filter_logic );
74 
+			        $this->addDefaultFilterLogic($filter->name, $filter_logic);
75 75 
 		        }
76 76 
 	        } else {
77 77 
 		        //if the filter is not active, but fallback logic was supplied
78 
-		        if ( is_callable( $fallback_logic ) ) {
78 
+		        if (is_callable($fallback_logic)) {
79 79 
 			        // apply the fallback logic
80 80 
 			        $fallback_logic();
81 81 
 		        }
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138
139 139 
     public function removeFilter($name)
140 140 
     {
141 
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
141 
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
142 142 
             return $filter->name == $name;
143 143 
         });
144 144 
     }
 
@@ -208,7 +208,7 @@  discard block
 
 block discarded – undo
208 208 
         $this->type = $options['type'];
209 209 
         $this->label = $options['label'];
210 210
211 
-        if (! isset($options['placeholder'])) {
211 
+        if (!isset($options['placeholder'])) {
212 212 
             $this->placeholder = '';
213 213 
         } else {
214 214 
             $this->placeholder = $options['placeholder'];
 
@@ -225,16 +225,16 @@  discard block
 
 block discarded – undo
225 225
226 226 
     public function checkOptionsIntegrity($options)
227 227 
     {
228 
-        if (! isset($options['name'])) {
228 
+        if (!isset($options['name'])) {
229 229 
             abort(500, 'Please make sure all your filters have names.');
230 230 
         }
231 
-        if (! isset($options['type'])) {
231 
+        if (!isset($options['type'])) {
232 232 
             abort(500, 'Please make sure all your filters have types.');
233 233 
         }
234 
-        if (! \View::exists('crud::filters.'.$options['type'])) {
234 
+        if (!\View::exists('crud::filters.'.$options['type'])) {
235 235 
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
236 236 
         }
237 
-        if (! isset($options['label'])) {
237 
+        if (!isset($options['label'])) {
238 238 
             abort(500, 'Please make sure all your filters have labels.');
239 239 
         }
240 240 
     }
Please login to merge, or discard this patch.