CrudController::show() - Code Metrics - Inspection of "officially added call-based api" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c61b79...4016a1 )

by Cristian

created 2016-05-18 15:10 UTC

CrudController::show() A

↳ Parent: CrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	4

Duplication

Lines	12
Ratio	100 %

Importance

Changes	6
Bugs	1	Features	3

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	12
loc	12
rs	9.4285
c	6
b	1
f	3

<?php namespace Backpack\CRUD\app\Http\Controllers;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Support\Facades\Form as Form;
use Illuminate\Http\Request;
use Backpack\CRUD\Crud;
use Crypt;
use Alert;


// VALIDATION: change the requests to match your own file names if you need form validation
use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;

class CrudController extends BaseController {

	use DispatchesJobs, ValidatesRequests;

	public $data = [];
	public $crud;

	public function __construct()
	{
		$this->crud = new Crud();
	}

	/**
	 * Display all rows in the database for this entity.
	 *
	 * @return Response
	 */
	public function index()
	{
		$this->crud->hasAccessOrFail('list');

		$this->data['entries'] = $this->crud->getEntries();
		$this->data['crud'] = $this->crud;
		$this->data['title'] = ucfirst($this->crud->entity_name_plural);

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::list', $this->data);
	}


	/**
	 * Show the form for creating inserting a new row.
	 *
	 * @return Response
	 */
	public function create()

	{
		$this->crud->hasAccessOrFail('create');

		// prepare the fields you need to show
		$this->data['crud'] = $this->crud;
		$this->data['fields'] = $this->crud->getCreateFields();
		$this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::create', $this->data);
	}


	/**
	 * Store a newly created resource in the database.
	 *
	 * @param  StoreRequest  $request - type injection used for validation using Requests
	 * @return \Illuminate\Http\RedirectResponse
	 */
	public function storeCrud(StoreRequest $request = null)
	{
		$this->crud->hasAccessOrFail('create');

		
		// insert item in the db
		$item = $this->crud->create(\Request::except(['redirect_after_save', 'password']));


		// show a success message
		\Alert::success(trans('backpack::crud.insert_success'))->flash();

		// redirect the user where he chose to be redirected
		switch (\Request::input('redirect_after_save')) {
			case 'current_item_edit':
				return \Redirect::to($this->crud->route.'/'.$item->id.'/edit');

			default:
				return \Redirect::to(\Request::input('redirect_after_save'));

		}
	}


	/**
	 * Show the form for editing the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function edit($id)
	{
		$this->crud->hasAccessOrFail('update');

		// get the info for that entry
		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;
		$this->data['fields'] = $this->crud->getUpdateFields($id);
		$this->data['title'] = trans('backpack::crud.edit').' '.$this->crud->entity_name;

		$this->data['id'] = $id;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::edit', $this->data);
	}


	/**
	 * Update the specified resource in the database.
	 *
	 * @param  UpdateRequest  $request - type injection used for validation using Requests
	 * @return \Illuminate\Http\RedirectResponse
	 */
	public function updateCrud(UpdateRequest $request = null)
	{
		$this->crud->hasAccessOrFail('update');

		// update the row in the db

		$this->crud->update(\Request::get('id'), \Request::except('redirect_after_save'));

		// show a success message
		\Alert::success(trans('backpack::crud.update_success'))->flash();

		return \Redirect::to($this->crud->route);
	}


	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function show($id)

	{
		$this->crud->hasAccessOrFail('show');

		// get the info for that entry
		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;
		$this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::show', $this->data);
	}


	/**
	 * Remove the specified resource from storage.
	 *
	 * @param  int  $id
	 * @return string
	 */
	public function destroy($id)
	{
		$this->crud->hasAccessOrFail('delete');
		return $this->crud->delete($id);
	}


	/**
	 *  Reorder the items in the database using the Nested Set pattern.
	 *
	 *	Database columns needed: id, parent_id, lft, rgt, depth, name/title
	 *
	 *  @return Response
	 */
	public function reorder($lang = false)
	{
		$this->crud->hasAccessOrFail('reorder');

		if (!$this->crud->isReorderEnabled()) {
			abort(403, 'Reorder is disabled.');
		}

		if ($lang == false)

		{
			$lang = \Lang::locale();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		}

		// get all results for that entity
		$this->data['entries'] = $this->crud->getEntries();
		$this->data['crud'] = $this->crud;
		$this->data['title'] = trans('backpack::crud.reorder').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::reorder', $this->data);
	}


	/**
	 * Save the new order, using the Nested Set pattern.
	 *
	 * Database columns needed: id, parent_id, lft, rgt, depth, name/title
	 *
	 * @return
	 */
	public function saveReorder()
	{
		$this->crud->hasAccessOrFail('reorder');

		$all_entries = \Request::input('tree');

		if (count($all_entries)) {
			$count = $this->crud->updateTreeOrder($all_entries);
		} else
		{
			return false;
		}

		return 'success for '.$count." items";
	}


	/**
	 * Used with AJAX in the list view (datatables) to show extra information about that row that didn't fit in the table.
	 * It defaults to showing some dummy text.
	 *
	 * It's enabled by:
	 * - setting: $crud->details_row = true;
	 * - adding the details route for the entity; ex: Route::get('page/{id}/details', 'PageCrudController@showDetailsRow');
	 * - adding a view with the following name to change what the row actually contains: app/resources/views/vendor/backpack/crud/details_row.blade.php
	 */
	public function showDetailsRow($id)
	{
		$this->crud->hasAccessOrFail('details_row');

		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::details_row', $this->data);
	}



}


1		<?php namespace Backpack\CRUD\app\Http\Controllers;
2
3		use Illuminate\Foundation\Bus\DispatchesJobs;
4		use Illuminate\Routing\Controller as BaseController;
5		use Illuminate\Foundation\Validation\ValidatesRequests;
6		use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
7		use Illuminate\Support\Facades\Form as Form;
8		use Illuminate\Http\Request;
9		use Backpack\CRUD\Crud;
10		use Crypt;
11		use Alert;
12
13
14		// VALIDATION: change the requests to match your own file names if you need form validation
15		use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
16		use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
17
18		class CrudController extends BaseController {
19
20		use DispatchesJobs, ValidatesRequests;
21
22		public $data = [];
23		public $crud;
24
25		public function __construct()
26		{
27		$this->crud = new Crud();
28		}
29
30		/**
31		* Display all rows in the database for this entity.
32		*
33		* @return Response
34		*/
35		public function index()
36		{
37		$this->crud->hasAccessOrFail('list');
38
39		$this->data['entries'] = $this->crud->getEntries();
40		$this->data['crud'] = $this->crud;
41		$this->data['title'] = ucfirst($this->crud->entity_name_plural);
42
43		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
44		return view('crud::list', $this->data);
45		}
46
47
48		/**
49		* Show the form for creating inserting a new row.
50		*
51		* @return Response
52		*/
53	View Code Duplication	public function create()
		0 ignored issues – show Duplication introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		$this->crud->hasAccessOrFail('create');
56
57		// prepare the fields you need to show
58		$this->data['crud'] = $this->crud;
59		$this->data['fields'] = $this->crud->getCreateFields();
60		$this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;
61
62		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
63		return view('crud::create', $this->data);
64		}
65
66
67		/**
68		* Store a newly created resource in the database.
69		*
70		* @param StoreRequest $request - type injection used for validation using Requests
71		* @return \Illuminate\Http\RedirectResponse
72		*/
73		public function storeCrud(StoreRequest $request = null)
74		{
75		$this->crud->hasAccessOrFail('create');
76
77
78		// insert item in the db
79		$item = $this->crud->create(\Request::except(['redirect_after_save', 'password']));
80
81
82		// show a success message
83		\Alert::success(trans('backpack::crud.insert_success'))->flash();
84
85		// redirect the user where he chose to be redirected
86		switch (\Request::input('redirect_after_save')) {
87		case 'current_item_edit':
88		return \Redirect::to($this->crud->route.'/'.$item->id.'/edit');
89
90		default:
91		return \Redirect::to(\Request::input('redirect_after_save'));
		0 ignored issues – show Bug introduced 2016-03-16 20:55 UTC by Report Bug Copy Issue Report It seems like `\Request::input('redirect_after_save')` targeting `Illuminate\Http\Request::input()` can also be of type `array`; however, `Illuminate\Routing\Redirector::to()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
92		}
93		}
94
95
96		/**
97		* Show the form for editing the specified resource.
98		*
99		* @param int $id
100		* @return Response
101		*/
102		public function edit($id)
103		{
104		$this->crud->hasAccessOrFail('update');
105
106		// get the info for that entry
107		$this->data['entry'] = $this->crud->getEntry($id);
108		$this->data['crud'] = $this->crud;
109		$this->data['fields'] = $this->crud->getUpdateFields($id);
110		$this->data['title'] = trans('backpack::crud.edit').' '.$this->crud->entity_name;
111
112		$this->data['id'] = $id;
113
114		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
115		return view('crud::edit', $this->data);
116		}
117
118
119		/**
120		* Update the specified resource in the database.
121		*
122		* @param UpdateRequest $request - type injection used for validation using Requests
123		* @return \Illuminate\Http\RedirectResponse
124		*/
125		public function updateCrud(UpdateRequest $request = null)
126		{
127		$this->crud->hasAccessOrFail('update');
128
129		// update the row in the db
130
131		$this->crud->update(\Request::get('id'), \Request::except('redirect_after_save'));
132
133		// show a success message
134		\Alert::success(trans('backpack::crud.update_success'))->flash();
135
136		return \Redirect::to($this->crud->route);
137		}
138
139
140		/**
141		* Display the specified resource.
142		*
143		* @param int $id
144		* @return Response
145		*/
146	View Code Duplication	public function show($id)
		0 ignored issues – show Duplication introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		$this->crud->hasAccessOrFail('show');
149
150		// get the info for that entry
151		$this->data['entry'] = $this->crud->getEntry($id);
152		$this->data['crud'] = $this->crud;
153		$this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name;
154
155		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
156		return view('crud::show', $this->data);
157		}
158
159
160		/**
161		* Remove the specified resource from storage.
162		*
163		* @param int $id
164		* @return string
165		*/
166		public function destroy($id)
167		{
168		$this->crud->hasAccessOrFail('delete');
169		return $this->crud->delete($id);
170		}
171
172
173		/**
174		* Reorder the items in the database using the Nested Set pattern.
175		*
176		* Database columns needed: id, parent_id, lft, rgt, depth, name/title
177		*
178		* @return Response
179		*/
180		public function reorder($lang = false)
181		{
182		$this->crud->hasAccessOrFail('reorder');
183
184		if (!$this->crud->isReorderEnabled()) {
185		abort(403, 'Reorder is disabled.');
186		}
187
188		if ($lang == false)
		0 ignored issues – show Coding Style Best Practice introduced 2016-03-16 20:55 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
189		{
190		$lang = \Lang::locale();
		0 ignored issues – show Unused Code introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `$lang` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
191		}
192
193		// get all results for that entity
194		$this->data['entries'] = $this->crud->getEntries();
195		$this->data['crud'] = $this->crud;
196		$this->data['title'] = trans('backpack::crud.reorder').' '.$this->crud->entity_name;
197
198		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
199		return view('crud::reorder', $this->data);
200		}
201
202
203		/**
204		* Save the new order, using the Nested Set pattern.
205		*
206		* Database columns needed: id, parent_id, lft, rgt, depth, name/title
207		*
208		* @return
209		*/
210		public function saveReorder()
211		{
212		$this->crud->hasAccessOrFail('reorder');
213
214		$all_entries = \Request::input('tree');
215
216		if (count($all_entries)) {
217		$count = $this->crud->updateTreeOrder($all_entries);
218		} else
219		{
220		return false;
221		}
222
223		return 'success for '.$count." items";
224		}
225
226
227		/**
228		* Used with AJAX in the list view (datatables) to show extra information about that row that didn't fit in the table.
229		* It defaults to showing some dummy text.
230		*
231		* It's enabled by:
232		* - setting: $crud->details_row = true;
233		* - adding the details route for the entity; ex: Route::get('page/{id}/details', 'PageCrudController@showDetailsRow');
234		* - adding a view with the following name to change what the row actually contains: app/resources/views/vendor/backpack/crud/details_row.blade.php
235		*/
236		public function showDetailsRow($id)
237		{
238		$this->crud->hasAccessOrFail('details_row');
239
240		$this->data['entry'] = $this->crud->getEntry($id);
241		$this->data['crud'] = $this->crud;
242
243		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
244		return view('crud::details_row', $this->data);
245		}
246
247
248
249		}
250

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( c61b79...4016a1 )

CrudController::show() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like