Backpack\CRUD\app\Http\Controllers\CrudController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	232
Duplicated Lines	10.34 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	13
Bugs	3	Features	3

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	11	1
A	create()	12	12	1
A	storeCrud()	0	21	2
A	edit()	0	15	1
A	updateCrud()	0	13	1
A	show()	12	12	1
A	destroy()	0	5	1
A	reorder()	0	21	3
A	saveReorder()	0	15	2
A	showDetailsRow()	0	10	1

<?php namespace Backpack\CRUD\app\Http\Controllers;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Support\Facades\Form as Form;
use Illuminate\Http\Request;
use Backpack\CRUD\Crud;
use Crypt;
use Alert;


// VALIDATION: change the requests to match your own file names if you need form validation
use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;

class CrudController extends BaseController {

	use DispatchesJobs, ValidatesRequests;

	public $data = [];
	public $crud;

	public function __construct()
	{
		$this->crud = new Crud();
	}

	/**
	 * Display all rows in the database for this entity.
	 *
	 * @return Response
	 */
	public function index()
	{
		$this->crud->hasAccessOrFail('list');

		$this->data['entries'] = $this->crud->getEntries();
		$this->data['crud'] = $this->crud;
		$this->data['title'] = ucfirst($this->crud->entity_name_plural);

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::list', $this->data);
	}


	/**
	 * Show the form for creating inserting a new row.
	 *
	 * @return Response
	 */
	public function create()

This method seems to be duplicated in your project.

	{
		$this->crud->hasAccessOrFail('create');

		// prepare the fields you need to show
		$this->data['crud'] = $this->crud;
		$this->data['fields'] = $this->crud->getCreateFields();
		$this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::create', $this->data);
	}


	/**
	 * Store a newly created resource in the database.
	 *
	 * @param  StoreRequest  $request - type injection used for validation using Requests
	 * @return \Illuminate\Http\RedirectResponse
	 */
	public function storeCrud(StoreRequest $request = null)
	{
		$this->crud->hasAccessOrFail('create');

		
		// insert item in the db
		$item = $this->crud->create(\Request::except(['redirect_after_save', 'password']));


		// show a success message
		\Alert::success(trans('backpack::crud.insert_success'))->flash();

		// redirect the user where he chose to be redirected
		switch (\Request::input('redirect_after_save')) {
			case 'current_item_edit':
				return \Redirect::to($this->crud->route.'/'.$item->id.'/edit');

			default:
				return \Redirect::to(\Request::input('redirect_after_save'));

It seems like \Request::input('redirect_after_save') targeting Illuminate\Http\Request::input() can also be of type array; however, Illuminate\Routing\Redirector::to() does only seem to accept string, maybe add an additional type check?

		}
	}


	/**
	 * Show the form for editing the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function edit($id)
	{
		$this->crud->hasAccessOrFail('update');

		// get the info for that entry
		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;
		$this->data['fields'] = $this->crud->getUpdateFields($id);
		$this->data['title'] = trans('backpack::crud.edit').' '.$this->crud->entity_name;

		$this->data['id'] = $id;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::edit', $this->data);
	}


	/**
	 * Update the specified resource in the database.
	 *
	 * @param  UpdateRequest  $request - type injection used for validation using Requests
	 * @return \Illuminate\Http\RedirectResponse
	 */
	public function updateCrud(UpdateRequest $request = null)
	{
		$this->crud->hasAccessOrFail('update');

		// update the row in the db

		$this->crud->update(\Request::get('id'), \Request::except('redirect_after_save'));

		// show a success message
		\Alert::success(trans('backpack::crud.update_success'))->flash();

		return \Redirect::to($this->crud->route);
	}


	/**
	 * Display the specified resource.
	 *
	 * @param  int  $id
	 * @return Response
	 */
	public function show($id)

This method seems to be duplicated in your project.

	{
		$this->crud->hasAccessOrFail('show');

		// get the info for that entry
		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;
		$this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::show', $this->data);
	}


	/**
	 * Remove the specified resource from storage.
	 *
	 * @param  int  $id
	 * @return string
	 */
	public function destroy($id)
	{
		$this->crud->hasAccessOrFail('delete');
		return $this->crud->delete($id);
	}


	/**
	 *  Reorder the items in the database using the Nested Set pattern.
	 *
	 *	Database columns needed: id, parent_id, lft, rgt, depth, name/title
	 *
	 *  @return Response
	 */
	public function reorder($lang = false)
	{
		$this->crud->hasAccessOrFail('reorder');

		if (!$this->crud->isReorderEnabled()) {
			abort(403, 'Reorder is disabled.');
		}

		if ($lang == false)

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

		{
			$lang = \Lang::locale();

$lang is not used, you could remove the assignment.

		}

		// get all results for that entity
		$this->data['entries'] = $this->crud->getEntries();
		$this->data['crud'] = $this->crud;
		$this->data['title'] = trans('backpack::crud.reorder').' '.$this->crud->entity_name;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::reorder', $this->data);
	}


	/**
	 * Save the new order, using the Nested Set pattern.
	 *
	 * Database columns needed: id, parent_id, lft, rgt, depth, name/title
	 *
	 * @return
	 */
	public function saveReorder()
	{
		$this->crud->hasAccessOrFail('reorder');

		$all_entries = \Request::input('tree');

		if (count($all_entries)) {
			$count = $this->crud->updateTreeOrder($all_entries);
		} else
		{
			return false;
		}

		return 'success for '.$count." items";
	}


	/**
	 * Used with AJAX in the list view (datatables) to show extra information about that row that didn't fit in the table.
	 * It defaults to showing some dummy text.
	 *
	 * It's enabled by:
	 * - setting: $crud->details_row = true;
	 * - adding the details route for the entity; ex: Route::get('page/{id}/details', 'PageCrudController@showDetailsRow');
	 * - adding a view with the following name to change what the row actually contains: app/resources/views/vendor/backpack/crud/details_row.blade.php
	 */
	public function showDetailsRow($id)
	{
		$this->crud->hasAccessOrFail('details_row');

		$this->data['entry'] = $this->crud->getEntry($id);
		$this->data['crud'] = $this->crud;

		// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
		return view('crud::details_row', $this->data);
	}



}