Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — v6 (#4971)
by Pedro
30:02 queued 15:18
created
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
     public function testAddButtonFluently()
286 286
     {
287 287
         $button1 = CrudButton::name('lineTest')->to('line')->view('crud::buttons.test')->type('view');
288
-        $button2 = CrudButton::add('modelFunction')->model_function(function () {
288
+        $button2 = CrudButton::add('modelFunction')->model_function(function() {
289 289
             return 'test';
290 290
         })->section('top')->makeFirst();
291 291
         $this->assertEquals($button1->toArray(), $this->crudPanel->buttons()->last()->toArray());
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
     private function getButtonByName($name)
297 297
     {
298
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
298
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
299 299
             return $value->name == $name;
300 300
         });
301 301
     }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Interfaces/UploaderInterface.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Static constructor function.
12 12
      */
13
-    public static function for(array $field, array $configuration): UploaderInterface;
13
+    public static function for (array $field, array $configuration): UploaderInterface;
14 14
 
15 15
     /**
16 16
      * Default implementation functions.
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     public function getExpirationTimeInMinutes(): int;
45 45
 
46
-    public function getFileName(string|UploadedFile $file): string;
46
+    public function getFileName(string | UploadedFile $file): string;
47 47
 
48 48
     public function getRepeatableContainerName(): ?string;
49 49
 
Please login to merge, or discard this patch.
src/resources/views/crud/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     <?php
28 28
     function tree_element($entry, $key, $all_entries, $crud)
29 29
     {
30
-        if (! isset($entry->tree_element_shown)) {
30
+        if (!isset($entry->tree_element_shown)) {
31 31
             // mark the element as shown
32 32
             $all_entries[$key]->tree_element_shown = true;
33 33
             $entry->tree_element_shown = true;
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
                 <ol class="sortable mt-0 mb-0">
71 71
                     <?php
72 72
                     $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
73
-    $root_entries = $all_entries->filter(function ($item) {
73
+    $root_entries = $all_entries->filter(function($item) {
74 74
         return $item->parent_id == 0;
75 75
     });
76 76
     foreach ($root_entries as $key => $entry) {
Please login to merge, or discard this patch.
src/app/Console/Commands/Themes/InstallsTheme.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         }
72 72
 
73 73
         // Display general error in case it failed
74
-        if (! $this->isInstalled()) {
74
+        if (!$this->isInstalled()) {
75 75
             $this->errorProgressBlock();
76 76
             $this->note('For further information please check the log file.');
77 77
             $this->note('You can also follow the manual installation process documented on Github.');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->progressBlock('Publish theme config file');
85 85
 
86 86
         // manually include the provider in the run-time
87
-        if (! class_exists(self::$addon['provider'])) {
87
+        if (!class_exists(self::$addon['provider'])) {
88 88
             include self::$addon['provider_path'] ?? self::$addon['path'].'/src/AddonServiceProvider.php';
89 89
             app()->register(self::$addon['provider']);
90 90
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
     private function getViewPathsWithFallbacks()
300 300
     {
301 301
         $type = $this->name;
302
-        $paths = array_map(function ($item) use ($type) {
302
+        $paths = array_map(function($item) use ($type) {
303 303
             return $item.'.'.$type;
304 304
         }, ViewNamespaces::getFor('buttons'));
305 305
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 
468 468
         $itemExists = $this->collection()->contains('name', $this->name);
469 469
 
470
-        if (! $itemExists) {
470
+        if (!$itemExists) {
471 471
             $this->crud()->addCrudButton($this);
472 472
             if ($this->position == 'beginning') {
473 473
                 $this->before($this->collection()->first()->name);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function afterField($targetFieldName)
138 138
     {
139
-        $this->transformFields(function ($fields) use ($targetFieldName) {
139
+        $this->transformFields(function($fields) use ($targetFieldName) {
140 140
             return $this->moveField($fields, $targetFieldName, false);
141 141
         });
142 142
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function beforeField($targetFieldName)
150 150
     {
151
-        $this->transformFields(function ($fields) use ($targetFieldName) {
151
+        $this->transformFields(function($fields) use ($targetFieldName) {
152 152
             return $this->moveField($fields, $targetFieldName, true);
153 153
         });
154 154
     }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function makeFirstField()
162 162
     {
163
-        if (! $this->fields()) {
163
+        if (!$this->fields()) {
164 164
             return false;
165 165
         }
166 166
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function removeField($name)
177 177
     {
178
-        $this->transformFields(function ($fields) use ($name) {
178
+        $this->transformFields(function($fields) use ($name) {
179 179
             Arr::forget($fields, $name);
180 180
 
181 181
             return $fields;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function removeFields($array_of_names)
191 191
     {
192
-        if (! empty($array_of_names)) {
192
+        if (!empty($array_of_names)) {
193 193
             foreach ($array_of_names as $name) {
194 194
                 $this->removeField($name);
195 195
             }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     public function removeAllFields()
203 203
     {
204 204
         $current_fields = $this->getCleanStateFields();
205
-        if (! empty($current_fields)) {
205
+        if (!empty($current_fields)) {
206 206
             foreach ($current_fields as $field) {
207 207
                 $this->removeField($field['name']);
208 208
             }
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
                 $jsonCastables = ['array', 'object', 'json'];
297 297
                 $fieldCasting = $casted_attributes[$field['name']];
298 298
 
299
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
299
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
300 300
                     try {
301 301
                         $input[$field['name']] = json_decode($input[$field['name']]);
302 302
                     } catch (\Exception $e) {
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
      */
326 326
     public function orderFields($order)
327 327
     {
328
-        $this->transformFields(function ($fields) use ($order) {
328
+        $this->transformFields(function($fields) use ($order) {
329 329
             return $this->applyOrderToFields($fields, $order);
330 330
         });
331 331
     }
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
     public function hasUploadFields()
350 350
     {
351 351
         $fields = $this->getCleanStateFields();
352
-        $upload_fields = Arr::where($fields, function ($value, $key) {
352
+        $upload_fields = Arr::where($fields, function($value, $key) {
353 353
             // check if any subfields have uploads
354 354
             if (isset($value['subfields'])) {
355 355
                 foreach ($value['subfields'] as $subfield) {
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
         $alreadyLoaded = $this->getLoadedFieldTypes();
422 422
         $type = $this->getFieldTypeWithNamespace($field);
423 423
 
424
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
424
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
425 425
             $alreadyLoaded[] = $type;
426 426
             $this->setLoadedFieldTypes($alreadyLoaded);
427 427
 
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
      */
463 463
     public function fieldTypeNotLoaded($field)
464 464
     {
465
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
465
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
466 466
     }
467 467
 
468 468
     /**
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
     {
475 475
         $fieldNamesArray = array_column($this->getCleanStateFields(), 'name');
476 476
 
477
-        return array_reduce($fieldNamesArray, function ($names, $item) {
477
+        return array_reduce($fieldNamesArray, function($names, $item) {
478 478
             if (strpos($item, ',') === false) {
479 479
                 $names[] = $item;
480 480
 
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
      */
526 526
     public function hasFieldWhere($attribute, $value)
527 527
     {
528
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
528
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
529 529
             return isset($field[$attribute]) && $field[$attribute] == $value;
530 530
         });
531 531
 
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
      */
542 542
     public function firstFieldWhere($attribute, $value)
543 543
     {
544
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
544
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
545 545
             return isset($field[$attribute]) && $field[$attribute] == $value;
546 546
         });
547 547
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name'  => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
79 79
         if ($this->holdsMultipleInputs($field['name'])) {
80
-            $result = array_map(function ($item) use ($model) {
80
+            $result = array_map(function($item) use ($model) {
81 81
                 return $model->{$item};
82 82
             }, explode(',', $field['name']));
83 83
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
101 101
 
102
-        if (! method_exists($relatedModel, $relationMethod)) {
102
+        if (!method_exists($relatedModel, $relationMethod)) {
103 103
             return $relatedModel->{$relationMethod};
104 104
         }
105 105
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                     $model = $this->setupRelatedModelLocale($model);
119 119
                     // when subfields are NOT set we don't need to get any more values
120 120
                     // we just return the plain models as we only need the ids
121
-                    if (! isset($field['subfields'])) {
121
+                    if (!isset($field['subfields'])) {
122 122
                         $result->push($model);
123 123
 
124 124
                         continue;
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
146 146
                 break;
147 147
             case 'HasOne':
148 148
             case 'MorphOne':
149
-                if (! method_exists($relatedModel, $relationMethod)) {
149
+                if (!method_exists($relatedModel, $relationMethod)) {
150 150
                     return;
151 151
                 }
152 152
 
153 153
                 $model = $relatedModel->{$relationMethod};
154 154
 
155
-                if (! $model) {
155
+                if (!$model) {
156 156
                     return;
157 157
                 }
158 158
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $relationArray = explode('.', $relationEntity);
235 235
 
236
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
236
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
237 237
             // if the string ends with `_id` we strip it out
238 238
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
239 239
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // if the subfield name does not contain a dot we just need to check
261 261
             // if it has subfields and return the result accordingly.
262 262
             foreach ((array) $subfield['name'] as $name) {
263
-                if (! Str::contains($name, '.')) {
263
+                if (!Str::contains($name, '.')) {
264 264
                     // when subfields are present, $relatedModel->{$name} returns a model instance
265 265
                     // otherwise returns the model attribute.
266 266
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Support/MacroableWithAttributes.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@
 block discarded – undo
47 47
                                         ->filter(fn ($item) => isset($item[$macro]));
48 48
 
49 49
                 $subfieldsWithMacros->each(
50
-                    function ($item) use ($subfieldsWithMacros, $macro) {
51
-                        $config = ! is_array($item[$macro]) ? [] : $item[$macro];
50
+                    function($item) use ($subfieldsWithMacros, $macro) {
51
+                        $config = !is_array($item[$macro]) ? [] : $item[$macro];
52 52
                         if ($subfieldsWithMacros->last() === $item) {
53 53
                             $this->{$macro}($config, $item);
54 54
                         } else {
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $this->getPreviousFiles($entry);
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
Please login to merge, or discard this patch.