Backpack\CRUD\app\Library\Validation\Rules\ValidUpload

Complexity

Total Complexity

8

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	4
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	validate()	0	18	7
A	field()	0	3	1

<?php

namespace Backpack\CRUD\app\Library\Validation\Rules;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Backpack\CRUD\app\Library\Validation\Rules\Support\HasFiles;
use Closure;
use Illuminate\Contracts\Validation\Rule;
use Illuminate\Contracts\Validation\ValidationRule;
use Illuminate\Support\Facades\Validator;

class ValidUpload extends BackpackCustomRule
{
    use HasFiles;

    /**
     * Run the validation rule.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @param  Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
     * @return void
     */
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        $entry = CrudPanelFacade::getCurrentEntry();

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        if (! array_key_exists($attribute, $this->data) && $entry) {
            return;
        }

        $this->validateFieldRules($attribute, $value, $fail);

        if (! empty($value) && ! empty($this->getFileRules())) {
            $validator = Validator::make([$attribute => $value], [
                $attribute => $this->getFileRules(),
            ], $this->validator->customMessages, $this->validator->customAttributes);

Accessing customAttributes on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing customMessages on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

            if ($validator->fails()) {
                foreach ($validator->errors()->messages()[$attribute] as $message) {
                    $fail($message)->translate();
                }
            }
        }
    }

    public static function field(string|array|ValidationRule|Rule $rules = []): self
    {
        return parent::field($rules);

The expression return parent::field($rules) returns the type Backpack\CRUD\app\Library\Validation\Rules\BackpackCustomRule which includes types incompatible with the type-hinted return Backpack\CRUD\app\Library\Validation\Rules\ValidUpload.

    }
}