Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by Cristian
26:50 queued 11:57
created
database/migrations/2017_09_08_000001_create_account_details_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('account_details', function (Blueprint $table) {
16
+        Schema::create('account_details', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('user_id')->unsigned();
19 19
             $table->string('nickname');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         return collect($this->fields())
62 62
             ->where('model')
63 63
             ->whereIn('relation_type', $relation_types)
64
-            ->filter(function ($item) {
64
+            ->filter(function($item) {
65 65
                 $related_model = get_class($this->model->{Arr::first(explode('.', $item['entity']))}()->getRelated());
66 66
 
67 67
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
         $related_method = Arr::last($entity_array);
215 215
 
216
-        if (! method_exists($relation_model, $related_method)) {
216
+        if (!method_exists($relation_model, $related_method)) {
217 217
             if (count($entity_array) <= 1) {
218 218
                 return $relation_field['entity'];
219 219
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 2 patches
Switch Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -184,15 +184,15 @@
 block discarded – undo
184 184
                         $item[$related_model->getKeyName()] = $related_model->getKey();
185 185
                         $return[] = $item;
186 186
             break;
187
-            case BelongsToMany::class:
188
-            case MorphToMany::class:
187
+                case BelongsToMany::class:
188
+                case MorphToMany::class:
189 189
 
190
-                    $item[$field['name']] = $related_model->getKey();
191
-                    //for any given related model, we get the pivot fields.
192
-                    foreach ($pivot_fields as $pivot_field) {
193
-                        $item[$pivot_field['name']] = $related_model->pivot->{$pivot_field['name']};
194
-                    }
195
-                    $return[] = $item;
190
+                        $item[$field['name']] = $related_model->getKey();
191
+                        //for any given related model, we get the pivot fields.
192
+                        foreach ($pivot_fields as $pivot_field) {
193
+                            $item[$pivot_field['name']] = $related_model->pivot->{$pivot_field['name']};
194
+                        }
195
+                        $return[] = $item;
196 196
             }
197 197
         }
198 198
         // we return the json encoded result as expected by repeatable field.
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         foreach ($fields as &$field) {
62 62
             // set the value
63
-            if (! isset($field['value'])) {
63
+            if (!isset($field['value'])) {
64 64
                 if (isset($field['subfields'])) {
65 65
                     $field['value'] = [];
66 66
                     foreach ($field['subfields'] as $subfield) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         // always have a hidden input for the entry id
76
-        if (! array_key_exists('id', $fields)) {
76
+        if (!array_key_exists('id', $fields)) {
77 77
             $fields['id'] = [
78 78
                 'name'  => $entry->getKeyName(),
79 79
                 'value' => $entry->getKey(),
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
             $relation_array = explode('.', $relational_entity);
101 101
 
102
-            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
102
+            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
103 103
                 return $obj->{$method} ? $obj->{$method} : $obj;
104 104
             }, $model);
105 105
 
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
      */
163 163
     private function getManyRelationAttributeValue($model, $relation_method, $field, $relation_type)
164 164
     {
165
-        if (! isset($field['pivotFields']) || ! is_array($field['pivotFields'])) {
165
+        if (!isset($field['pivotFields']) || !is_array($field['pivotFields'])) {
166 166
             return false;
167 167
         }
168 168
 
169
-        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
169
+        $pivot_fields = Arr::where($field['pivotFields'], function($item) use ($field) {
170 170
             return $field['name'] != $item['name'];
171 171
         });
172 172
         $related_models = $model->{$relation_method};
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -375,7 +375,7 @@
 block discarded – undo
375 375
         if (! is_null($relation_values) && $relationData['values'][$relationMethod][0] !== null) {
376 376
             // we add the new values into the relation
377 377
             $model_instance->whereIn($model_instance->getKeyName(), $relation_values)
378
-           ->update([$relation_foreign_key => $item->{$relation_local_key}]);
378
+            ->update([$relation_foreign_key => $item->{$relation_local_key}]);
379 379
 
380 380
             // we clear up any values that were removed from model relation.
381 381
             // if developer provided a fallback id, we use it
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     {
92 92
         $all_relation_fields = $this->getRelationFields();
93 93
 
94
-        return Arr::where($all_relation_fields, function ($value, $key) {
94
+        return Arr::where($all_relation_fields, function($value, $key) {
95 95
             return isset($value['pivot']) && $value['pivot'];
96 96
         });
97 97
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                             $field_data = json_decode($data[$field['name']], true);
156 156
 
157 157
                             //we grab from the parsed data the specific values for this pivot
158
-                            $pivot_data = Arr::first(Arr::where($field_data, function ($item) use ($pivot_id, $field) {
158
+                            $pivot_data = Arr::first(Arr::where($field_data, function($item) use ($pivot_id, $field) {
159 159
                                 return $item[$field['name']] === $pivot_id;
160 160
                             }));
161 161
 
@@ -188,12 +188,12 @@  discard block
 block discarded – undo
188 188
      */
189 189
     private function createRelationsForItem($item, $formattedData)
190 190
     {
191
-        if (! isset($formattedData['relations'])) {
191
+        if (!isset($formattedData['relations'])) {
192 192
             return false;
193 193
         }
194 194
 
195 195
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
196
-            if (! isset($relationData['model'])) {
196
+            if (!isset($relationData['model'])) {
197 197
                 continue;
198 198
             }
199 199
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
                     // we first check if there are relations of the relation
207 207
                     if (isset($relationData['relations'])) {
208 208
                         // if there are nested relations, we first add the BelongsTo like in main entry
209
-                        $belongsToRelations = Arr::where($relationData['relations'], function ($relation_data) {
209
+                        $belongsToRelations = Arr::where($relationData['relations'], function($relation_data) {
210 210
                             return $relation_data['relation_type'] == 'BelongsTo';
211 211
                         });
212 212
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                         $valuesWithRelations = $this->associateHasOneBelongsTo($belongsToRelations, $relationData['values'], $relation->getModel());
216 216
 
217 217
                         // remove previously added BelongsTo relations from relation data.
218
-                        $relationData['relations'] = Arr::where($relationData['relations'], function ($item) {
218
+                        $relationData['relations'] = Arr::where($relationData['relations'], function($item) {
219 219
                             return $item['relation_type'] != 'BelongsTo';
220 220
                         });
221 221
 
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         foreach ($belongsToFields as $relationField) {
262 262
             if (method_exists($item, $this->getOnlyRelationEntity($relationField))) {
263 263
                 $relatedId = Arr::get($data, $relationField['name']);
264
-                if (isset($relatedId) && ! is_null($relatedId)) {
264
+                if (isset($relatedId) && !is_null($relatedId)) {
265 265
                     $related = $relationField['model']::find($relatedId);
266 266
 
267 267
                     $item->{$this->getOnlyRelationEntity($relationField)}()->associate($related);
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     private function getRelationDataFromFormData($data)
316 316
     {
317 317
         // exclude the already attached belongs to relations but include nested belongs to.
318
-        $relation_fields = Arr::where($this->getRelationFields(), function ($field, $key) {
318
+        $relation_fields = Arr::where($this->getRelationFields(), function($field, $key) {
319 319
             return $field['relation_type'] !== 'BelongsTo' || $this->isNestedRelation($field);
320 320
         });
321 321
 
@@ -326,10 +326,10 @@  discard block
 block discarded – undo
326 326
             if (isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
327 327
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
328 328
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
329
-                if (! array_key_exists('model', $fieldData)) {
329
+                if (!array_key_exists('model', $fieldData)) {
330 330
                     $fieldData['model'] = $relation_field['model'];
331 331
                 }
332
-                if (! array_key_exists('parent', $fieldData)) {
332
+                if (!array_key_exists('parent', $fieldData)) {
333 333
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
334 334
                 }
335 335
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
                 // this allow developers to override that behavior and force deletion from database
344 344
                 $fieldData['force_delete'] = $relation_field['force_delete'] ?? false;
345 345
 
346
-                if (! array_key_exists('relation_type', $fieldData)) {
346
+                if (!array_key_exists('relation_type', $fieldData)) {
347 347
                     $fieldData['relation_type'] = $relation_field['relation_type'];
348 348
                 }
349 349
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 
373 373
         $relation_column_is_nullable = $model_instance->isColumnNullable($relation_foreign_key);
374 374
 
375
-        if (! is_null($relation_values) && $relationData['values'][$relationMethod][0] !== null) {
375
+        if (!is_null($relation_values) && $relationData['values'][$relationMethod][0] !== null) {
376 376
             // we add the new values into the relation
377 377
             $model_instance->whereIn($model_instance->getKeyName(), $relation_values)
378 378
            ->update([$relation_foreign_key => $item->{$relation_local_key}]);
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
                             ->where($relation_foreign_key, $item->{$relation_local_key})
387 387
                             ->update([$relation_foreign_key => $relationData['fallback_id']]);
388 388
             } else {
389
-                if (! $relation_column_is_nullable || $force_delete) {
389
+                if (!$relation_column_is_nullable || $force_delete) {
390 390
                     $model_instance->whereNotIn($model_instance->getKeyName(), $relation_values)
391 391
                             ->where($relation_foreign_key, $item->{$relation_local_key})
392 392
                             ->delete();
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
                 $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
404 404
                             ->update([$relation_foreign_key => $relationData['fallback_id']]);
405 405
             } else {
406
-                if (! $relation_column_is_nullable || $force_delete) {
406
+                if (!$relation_column_is_nullable || $force_delete) {
407 407
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})->delete();
408 408
                 } else {
409 409
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
             $created_ids = [];
434 434
 
435 435
             foreach ($items as $item) {
436
-                if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
436
+                if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
437 437
                     $entry->{$relationMethod}()->updateOrCreate([$relation_local_key => $item[$relation_local_key]], $item);
438 438
                 } else {
439 439
                     $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
             // get from $items the sent ids, and merge the ones created.
444 444
             $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
445 445
 
446
-            if (! empty($relatedItemsSent)) {
446
+            if (!empty($relatedItemsSent)) {
447 447
                 //we perform the cleanup of removed database items
448 448
                 $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
449 449
             }
Please login to merge, or discard this patch.