LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

90%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	20	5

<?php

namespace LaraCrafts\GeoRoutes\Http\Middleware;

use Closure;
use Illuminate\Http\Request;
use LaraCrafts\GeoRoutes\DeterminesGeoAccess;

class GeoRoutesMiddleware
{
    use DeterminesGeoAccess;

The trait LaraCrafts\GeoRoutes\DeterminesGeoAccess requires the property $countryCode which is not provided by LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware.

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @param string $strategy
     * @param string $countries
     * @param string|null $callback
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        $route = $request->route();

        if (!$route) {
            #TODO: Invoke the default callback.
            return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

        }

        $geo = $route->getAction('geo');

        if ($this->shouldHaveAccess($request, (array)$geo['countries'], $geo['strategy'])) {
            return $next($request);
        }

        if (array_key_exists('callback', $geo) && $callback = $geo['callback']) {

It seems like $geo can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

            return call_user_func_array($callback[0], $callback[1]);
        }

        return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

    }
}