LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::handle()

Complexity

Conditions	5
Paths	4

Size

Total Lines	20
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5.025

Importance

Changes

0

<?php
    public function handle(Request $request, Closure $next)
    {
        $route = $request->route();

        if (!$route) {
            #TODO: Invoke the default callback.
            return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

        }

        $geo = $route->getAction('geo');

        if ($this->shouldHaveAccess($request, (array)$geo['countries'], $geo['strategy'])) {
            return $next($request);
        }

        if (array_key_exists('callback', $geo) && $callback = $geo['callback']) {

It seems like $geo can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

            return call_user_func_array($callback[0], $callback[1]);
        }

        return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

    }