LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

64.29%

Importance

Changes	6
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	30	6

<?php

namespace LaraCrafts\GeoRoutes\Http\Middleware;

use Closure;
use Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator;
use LaraCrafts\GeoRoutes\DeterminesGeoAccess;

class GeoRoutesMiddleware
{
    use DeterminesGeoAccess;

The trait LaraCrafts\GeoRoutes\DeterminesGeoAccess requires the property $countryCode which is not provided by LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware.

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @param string $strategy
     * @param string $countries
     * @param string|null $callback
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        $route = $request->route();

        if (!$route) {
            #TODO: Invoke the default callback.
            return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

        }

        $constraint = $route->getAction('geo') ?? [];

        $validator = Validator::make($constraint, [
            'countries' => 'required|array|min:1',
            'countries.*' => 'string|min:2|max:2',
            'strategy' => 'required|in:allow,deny',
        ]);

        if ($validator->fails()) {
            throw new Exception("The GeoRoute constraint is invalid.");
        }

        if ($this->shouldHaveAccess($request, (array)$constraint['countries'], $constraint['strategy'])) {

(array)$constraint['countries'] of type array is incompatible with the type string expected by parameter $strategy of LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess().

The call to LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess() has too many arguments starting with $constraint['strategy'].

$request of type Illuminate\Http\Request is incompatible with the type array expected by parameter $countries of LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess().

            return $next($request);
        }

        if (array_key_exists('callback', $constraint) && $callback = $constraint['callback']) {
            return call_user_func_array($callback[0], $callback[1]);
        }

        return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

    }
}