LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::handle()

Complexity

Conditions	6
Paths	5

Size

Total Lines	30
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	7.6393

Importance

Changes	5
Bugs	0	Features	0

<?php
    public function handle(Request $request, Closure $next)
    {
        $route = $request->route();

        if (!$route) {
            #TODO: Invoke the default callback.
            return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

        }

        $constraint = $route->getAction('geo') ?? [];

        $validator = Validator::make($constraint, [
            'countries' => 'required|array|min:1',
            'countries.*' => 'string|min:2|max:2',
            'strategy' => 'required|in:allow,deny',
        ]);

        if ($validator->fails()) {
            throw new Exception("The GeoRoute constraint is invalid.");
        }

        if ($this->shouldHaveAccess($request, (array)$constraint['countries'], $constraint['strategy'])) {

(array)$constraint['countries'] of type array is incompatible with the type string expected by parameter $strategy of LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess().

The call to LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess() has too many arguments starting with $constraint['strategy'].

$request of type Illuminate\Http\Request is incompatible with the type array expected by parameter $countries of LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware::shouldHaveAccess().

            return $next($request);
        }

        if (array_key_exists('callback', $constraint) && $callback = $constraint['callback']) {
            return call_user_func_array($callback[0], $callback[1]);
        }

        return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

    }